From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 5E9D51C00 for ; Thu, 7 Dec 2017 10:16:31 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C42AE81E01; Thu, 7 Dec 2017 09:16:30 +0000 (UTC) Received: from [10.36.112.55] (ovpn-112-55.ams2.redhat.com [10.36.112.55]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 98EEA5C3FD; Thu, 7 Dec 2017 09:16:29 +0000 (UTC) To: Tiwei Bie , yliu@fridaylinux.org, dev@dpdk.org References: <20171207053059.19487-1-tiwei.bie@intel.com> <20171207053059.19487-4-tiwei.bie@intel.com> From: Maxime Coquelin Message-ID: Date: Thu, 7 Dec 2017 10:16:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171207053059.19487-4-tiwei.bie@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 07 Dec 2017 09:16:30 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 3/5] net/virtio: remove a redundant macro definition for ctrl vq X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Dec 2017 09:16:31 -0000 On 12/07/2017 06:30 AM, Tiwei Bie wrote: > VIRTIO_NET_CTRL_MAC_ADDR_SET is defined two times in > virtqueue.h, the second one is obviously not wanted. > > Signed-off-by: Tiwei Bie > --- > drivers/net/virtio/virtqueue.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h > index ab466c2db..eaf9de13e 100644 > --- a/drivers/net/virtio/virtqueue.h > +++ b/drivers/net/virtio/virtqueue.h > @@ -226,8 +226,6 @@ struct virtqueue { > #define VIRTIO_NET_CTRL_MQ_VQ_PAIRS_MIN 1 > #define VIRTIO_NET_CTRL_MQ_VQ_PAIRS_MAX 0x8000 > > -#define VIRTIO_NET_CTRL_MAC_ADDR_SET 1 > - > /** > * This is the first element of the scatter-gather list. If you don't > * specify GSO or CSUM features, you can simply ignore the header. > Reviewed-by: Maxime Coquelin Thanks, Maxime