From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EA4DDA04C7; Fri, 18 Sep 2020 09:04:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F284E1D8EA; Fri, 18 Sep 2020 09:04:39 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 760911D8E9 for ; Fri, 18 Sep 2020 09:04:38 +0200 (CEST) Received: from mx1-us1.ppe-hosted.com (unknown [10.7.65.62]) by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id E767860064; Fri, 18 Sep 2020 07:04:37 +0000 (UTC) Received: from us4-mdac16-38.ut7.mdlocal (unknown [10.7.66.157]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id EA1EE8009B; Fri, 18 Sep 2020 07:04:37 +0000 (UTC) X-Virus-Scanned: Proofpoint Essentials engine Received: from mx1-us1.ppe-hosted.com (unknown [10.7.66.30]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 60CB6280053; Fri, 18 Sep 2020 07:04:37 +0000 (UTC) Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id C1AC6100063; Fri, 18 Sep 2020 07:04:36 +0000 (UTC) Received: from [192.168.38.17] (10.17.10.39) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 18 Sep 2020 08:04:25 +0100 To: Ori Kam , Andrey Vesnovaty , "dev@dpdk.org" CC: "thomas@nvidia.net" , Slava Ovsiienko , "andrey.vesnovaty@gmail.com" , Oz Shlomo , Eli Britstein , Alex Rosenbaum , Roni Bar Yanai , Ori Kam , "NBU-Contact-Thomas Monjalon" , Ferruh Yigit References: <20200909203008.25563-1-andreyv@nvidia.com> <20200909203008.25563-2-andreyv@nvidia.com> From: Andrew Rybchenko Autocrypt: addr=arybchenko@solarflare.com; keydata= mQINBF2681gBEACbdTxu8eLL3UX2oAelsnK9GkeaJeUYSOHPJQpV7RL/iaIskqTwBRnhjXt7 j9UEwGA+omnOmqQMpeQTb/F9Ma2dYE+Hw4/t/1KVjxr3ehFaASvwR4fWJfO4e2l/Rk4rG6Yi 5r6CWU2y8su2654Fr8KFc+cMGOAgKoZTZHZsRy5lHpMlemeF+VZkv8L5sYJWPnsypgqlCG3h v6lbtfZs+QqYbFH6bqoZwBAl5irmxywGR7ZJr1GLUZZ1lfdazSY8r6Vz0/Ip/KVxGu2uxo81 QCsAj0ZsQtwji9Sds/prTiPrIjx8Fc/tfbnAuVuPcnPbczwCJACzQr4q26XATL3kVuZhSBWh 4XfO/EAUuEq5AemUG5DDTM87g7Lp4eT9gMZB6P+rJwWPNWTiV3L7Cn+fO+l9mTPnOqdzBgDe OaulKiNSft1o0DY4bGzOmM2ad2cZt0jfnbMPMTE9zsr6+RFa+M8Ct20o6U1MUE4vP6veErMK of4kZ8PdoMM+Sq1hxMPNtlcVBSP9xMmdSZPlfDYI5VWosOceEcz7XZdjBJKdwKuz70V7eac4 ITSxgNFCTbeJ03zL2MR5s0IvD9ghISAwZ6ieCjU5UATn5+63qpD0nVNLsAdb/UpfvQcKAmvj 0fKlxu/PMVkjBa7/4cfNogYOhWDKUO+1pMaFwvb6/XTo6uMpfQARAQABtCxBbmRyZXcgUnli Y2hlbmtvIDxhcnliY2hlbmtvQHNvbGFyZmxhcmUuY29tPokCVAQTAQoAPhYhBP6NPgcKRj/Y X0yXQahue0sAy4m+BQJduvNYAhsDBQkB4TOABQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKhue0sAy4m+t3gP/j1MNc63CEozZo1IZ2UpVPAVWTYbLdPjIRdFqhlwvZYIgGIgIBk3ezKL K0/oc4ZeIwL6wQ5+V24ahuXvvcxLlKxfbJ6lo2iQGC7GLGhsDG9Y2k6sW13/sTJB/XuR2yov k5FtIgJ+aHa1PDZnepnGGOt9ka9n/Jzrc9WKYapOIIyLRe9U26ikoVgyqsD37PVeq5tLWHHA NGTUKupe9G6DFWidxx0KzyMoWDTbW2AWYcEmV2eQsgRT094AZwLFN5ErfefYzsGdO8TAUU9X YTiQN2MvP1pBxY/r0/5UfwV4UKBcR0S3ZvzyvrPoYER2Kxdf/qurx0Mn7StiCQ/JlNZb/GWQ TQ7huduuZHNQKWm7ufbqvKSfbPYvfl3akj7Wl8/zXhYdLqb5mmK45HXrgYGEqPN53OnK2Ngx IgYKEWr05KNv09097jLT5ONgYvszflqlLIzC4dV245g7ucuf9fYmsvmM1p/gFnOJBJL18YE5 P1fuGYNfLP+qp4WMiDqXlzaJfB4JcinyU49BXUj3Utd6f6sNBsO8YWcLbKBV9WmA324S3+wj f4NPRp3A5E+6OmTVMLWire2ZvnYp3YvifUj1r8lhoZ2B2vKuWwiTlHOKYBEjnOQJQnqYZEF0 JQQ1xzVDBQKE01BPlA3vy6BGWe6I4psBVqMOB9lAev/H+xa4u6Z3uQINBF269JsBEAC2KB3W 8JES/fh74avN7LOSdK4QA7gFIUQ4egVL81KnxquLzzilABuOhmZf3Rq6rMHSM8xmUAWa7Dkt YtzXStjEBI/uF0mAR3mMz1RcL2Wp+WD/15HjVpA7hPjXSEsWY0K2ymPerK4yrLcfFTHdMonY JfuACCC9NtOZxrWHOJoUS+RT7AWk80q/6D2iwQ47/2dBTznVG+gSeHSes9l91TB09w6f9JX/ sT+Ud0NQfm7HJ7t2pmGI9O6Po/NLZsDogmnIpJp/WwYOZN9JK7u2FyX2UyRzR8jK42aJkRsh DXs16Cc2/eYGakjrdO3x9a+RoxN7EuFtYhGR1PzMXdUiB5i+FyddYXkYUyO43QE/3VPA5l1v TUOagzZq6aONsdNonGJkV3TIG3JmUNtM+D/+r6QKzmgoJ8w576JxEZI09I/ZFN+g7BnUmlMx 6Z3IUOXVX/SWfGFga0YajwajHz03IBhChEbYbbqndVhmshu2GFURxrfUPYWdDXEqkh+08a5U Didia9jm2Opv4oE1e1TXAePyYJl/Zyps4Cv00GObAxibvMBQCUZQ+IBnNldRBOwXXRQV2xpx P+9iO1VYA/QXn0KqRK+SH1JGRXbJYi42YFaW1gE0EU0fiR2Wb9pK+doNEjjOhlzUGuvOEAUS +4m0m3dlfEvpCV9GMr7ERRpZzh9QkQARAQABiQI8BBgBCgAmFiEE/o0+BwpGP9hfTJdBqG57 SwDLib4FAl269JsCGwwFCQlmAYAACgkQqG57SwDLib7x6g//e+eCtNnJz7qFGbjWRJYNLCe5 gQwkhdyEGk4omr3VmjGj3z9kNFy/muh4pmHUngSAnnpwZggx14N4hhKf9y8G4Dwvsqa6b1zB Jq/c4t/SBDtGW4M/E331N04PaQZpcrbTfp1KqHNknk2N7yOk4CcoLVuIZmA5tPguASV8aAfz ZwhWAwn6vUEw9552eXEAnGFGDTCbyryNwzB5jtVQOEEDjTxcCkpcXMB45Tb1QUslRTu/sBAe HhPCQSUcJHR+KOq+P6yKICGAr291PZd6Qc7C3UyE+A3pY/UfdEVWj0STBWx1qvYLaHLrI4O9 KXDgh7luLjZZafcueCaPYmNo4V2lmNb3+7S4TvqhoZS+wN+9ldRQ4gH3wmRZybN6Y/ZCqxol RaZpE3AqdWsGvIgAkD0FpmtZNii9s2pnrhw0K6S4t4tYgXGTossxNSJUltfFQZdXM1xkZhtv dBZuUEectbZWuviGvQXahOMuH2pM64mx2hpdZzPcI2beeJNHkAsGT2KcaMETgvtHUBFRlLVB YxsUYz3UZmi2JSua4tbcGd6iWVN90eb8CxszYtivfpz6o2nPSjNwg0NaVGSHXjAK0tdByZ9t SkwjC3tEPljVycRSDpbauogOiAkvjENfaPd/H26V5hY822kaclaKDAW6ZG9UKiMijcAgb9u5 CJoOyqE8aGS5Ag0EXbr1RwEQAMXZHbafqmZiu6Kudp+Filgdkj2/XJva5Elv3fLfpXvhVt0Y if5Rzds3RpffoLQZk9nPwK8TbZFqNXPu7HSgg9AY7UdCM94WRFTkUCGKzbgiqGdXZ7Vyc8cy teGW+BcdfQycDvjfy50T3fO4kJNVp2LDNdknPaZVe8HJ80Od63+9ksB6Ni+EijMkh6Uk3ulB CSLnT4iFV57KgU2IsxOQVLnm+0bcsWMcCnGfphkY0yKP+aJ6MfmZkEeaDa7kf24N14ktg50m vOGDitcxA/+XXQXOsOIDJx1VeidxYsQ2FfsKu1G8+G6ejuaLf4rV5MI/+B/tfLbbOdikM5PF pxZVgTir9q13qHumMxdme7w5c7hybW412yWAe9TsrlXktFmFjRSFzAAxQhQSQxArS6db4oBk yeYJ59mW52i4occkimPWSm/raSgdSM+0P6zdWUlxxj+r1qiLgCYvruzLNtp5Nts5tR/HRQjE /ohQYaWDSVJEsc/4eGmgwzHzmvHtXeKkasn01381A1Lv3xwtpnfwERMAhxBZ8EGKEkc5gNdk vIPhknnGgPXqKmE1aWu8LcHiY+RHAF8gYPCDMuwyzBYnbiosKcicuIUp0Fj8XIaPao6F+WTi In4UOrqrYhsaCUvhVjsTBbNphGih9xbFJ8E+lkTLL8P3umtTcMPnpsB4xqcDABEBAAGJBHIE GAEKACYWIQT+jT4HCkY/2F9Ml0GobntLAMuJvgUCXbr1RwIbAgUJCWYBgAJACRCobntLAMuJ vsF0IAQZAQoAHRYhBNTYjdjWgdaEN5MrAN+9UR5r/4d3BQJduvVHAAoJEN+9UR5r/4d3EiQP /3lyby6v49HTU94Q2Fn2Xat6uifR7kWE5SO/1pUwYzx6v+z5K2jqPgqUYmuNoejcGl0CTNhg LbsxzUmAuf1OTAdE+ZYvOAjjKQhY4haxHc4enby/ltnHfWJYWJZ9UN5SsIQLvITvYu6rqthO CYjpXJhwkj3ODmC9H1TrvjrBGc6i7CTnR8RCjMEwCs2LI2frHa4R6imViEr9ScMfUnzdABMQ B0T5MOg8NX92/FRjTldU2KovG0ML9mSveSvVHAoEBLy4UIs5nEDdNiO1opJgKb5CXvWQugub 7AR52phNdKVdEB0S4tigJT4NalyTaPiUhFEm+CzZpMQDJ5E+/OowaPRfN4HeJX+c8sB+vUAZ mkAaG75N+IEk5JKFK9Z+bBYgPgaBDFZYdWDB/TMH0ANt+KI5uYg0i12TB4M8pwKG1DEPUmWc F2YpvB3jnbwzsOpSFiJOOlSs6nOB0Sb5GRtPOO3h6XGj+6mzQd6tcL63c9TrrUkjq7LDkxCz SJ2hTYRC8WNX8Uw9skWo5728JNrXdazEYCenUWmYiKLNKLslXCFodUCRDh/sUiyqRwS7PHEA LYC/UIWLMomI0Yvju3KA5v3RQVXhL+Gx2CzSj3GDz9xxGhJB2LfRfjzPbTR/Z27UpjCkd8z0 Ro3Ypmi1FLQwnRgoOKDbetTAIhugEShaLTITzJAP/iRDJCQsrZah5tE8oIl81qKEmBJEGcdt HYikbpQe7ydcXhqTj7+IECa3O7azI5OhCxUH2jNyonJ/phUslHH2G1TTBZK8y4Hrx5RpuRNS esn3P9uKu9DHqBAL7DMsCPwb2p1VNnapD72DBmRhzS/e6zS2R4+r9yNv03Hv7VCxKkmtE63H qpS//qpjfrtsIcHAjnKDaDtL1LYCtHoweI+DOpKKULSAYp/JE6F8LNibPQ0/P3S5ZIJNC4QZ uESjFOalJwFIqGQdkQB7ltRNJENLrHc+2jKGOuyFHm/Sbvp5EMGdaeQ0+u8CY0P+y6oXenwx 7WrJz/GvbNoFhJoJ6RzxCMQrFgxrssVZ7w5HcUj94lbnJ6osdYE/WpSd50B6jet6LKh5revg u9XI9CoqsPQ1V4wKYYdllPuogCye7KNYNKuiiuSNpaF4gHq1ZWGArwZtWHjgc2v3LegOpRQF SwOskMKmWsUyHIRMG1p8RpkBQTqY2rGSeUqPSvaqjT0nq+SUEM6qxEXD/2Wqri/X6bamuPDb S0PkBvFD2+0zr5Bc2YkMGPBYPNGZiTp3UjmZlLfn3TiBKIC92jherY563CULjSsiBEJCOSvv 4VPLn5aAcfbCXJnE3IGCp/hPl50iQqu7BPOYBbWXeb9ptDjGCAThNxSz0WAXkmcjAFE8gdE6 Znk9 Message-ID: Date: Fri, 18 Sep 2020 10:04:18 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.17.10.39] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.6.1012-25672.003 X-TM-AS-Result: No-22.457600-8.000000-10 X-TMASE-MatchedRID: oCj5caaCQynmLzc6AOD8DfHkpkyUphL9Ud7Bjfo+5jTfoEW8NyvnbwdY TVAOlG+ZTm7UNJzbkHycW5kGTrPXDpy/Wj1FjkVAN19PjPJahlIUBI/UWYG7FoZCbEz8CXU9LIH ZB0nMVDGt/yeKcdsoSLgnwQ54RkubIeFIFB+CV+wD2WXLXdz+AdoKfgOoKJc2FGeSEtk4Ir21lc oibF/5wUxwpTUboUzTJvFisgM7Kw2foJvhQ6pVoDKVTrGMDe/D9e5am3m57X297L/T4JbGkuDGR KQQH0piKFGiUUecNxIxOEtgm8BKgYqEDaEbYNOrBcaL/tyWL2OmvxQk5gxkMjXSEULATMS5nL8J R8MCnhJ3NfsmGIEV3YiruQNU4W5aGPamHQPn1a/iHyvyXeXh5o8ZcR5uOw86CySgZBXFfsRcDiY 1DRnFk/Ie+YN+DAADJPTMB/XX8ndFCcBaMRT3aww5bFG3LCD6+eBf9ovw8I1fUCHPns/+PhoaJ0 DCQPZM4Ju7mYOWiN8qNkBH9kw3Wu57OgItHYSZ9FQh3flUIh7OFaObL3St2z2noOJRZ+vPN4xq+ GPR1zGrdP1E8ehH0fVhBcjWJn8SsQPFB/MDevTKy1dYiOWLmb/I3arxTrvizVgwP7ZMYf/CaBA5 v6nrh+RdnEX1rI/VkZOl7WKIImrvXOvQVlExsFZ0V5tYhzdWxEHRux+uk8jpP8tMOyYmaA== X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--22.457600-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.6.1012-25672.003 X-MDID: 1600412677-m_p09TQB6NWF Subject: Re: [dpdk-dev] [RFC 1/3] ethdev: add item/action for SFT X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/16/20 6:46 PM, Ori Kam wrote: > Hi Andrey, > > PSB > >> -----Original Message----- >> From: Andrey Vesnovaty >> Sent: Wednesday, September 9, 2020 11:30 PM >> >> Attach SFT flow context to packet with SFT action. >> Match on SFT flow context (attached to packet), >> with SFT item. Since it is the first patch which introduces SFT, it would be useful define abbreviation in the changeset description. The description does not explain what is SFT flow context. It does not explain why we should attach it using action and why we should match on it using pattern items. Please, help the reader to understand how it is supposed to be used in the future. >> >> Signed-off-by: Andrey Vesnovaty >> --- >> lib/librte_ethdev/rte_flow.h | 84 ++++++++++++++++++++++++++++++++++++ >> 1 file changed, 84 insertions(+) >> >> diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h >> index da8bfa5489..24390e6ab4 100644 >> --- a/lib/librte_ethdev/rte_flow.h >> +++ b/lib/librte_ethdev/rte_flow.h >> @@ -537,6 +537,12 @@ enum rte_flow_item_type { >> */ >> RTE_FLOW_ITEM_TYPE_ECPRI, >> >> + /** > You are missing the Meta, tag not relevant for RFC but please notice for the patch. > >> + * Matches SFT context (see fields of struct rte_flow_item_sft). >> + * >> + * See struct rte_flow_item_sft. >> + */ >> + RTE_FLOW_ITEM_TYPE_SFT, >> }; >> >> /** >> @@ -1579,6 +1585,54 @@ static const struct rte_flow_item_ecpri >> rte_flow_item_ecpri_mask = { >> }; >> #endif >> >> +/** >> + * @warning >> + * @b EXPERIMENTAL: this structure may change without prior notice >> + * >> + * RTE_FLOW_ITEM_TYPE_SFT >> + * >> + * Matches context of flow in SFT table. >> + * It looks like the content of SFT context is defined below. If so, please, say so. >> + * 5-tuple: src/dest IP + src/dest port + IP protocol. >> + * zone: application defined value cupled with 5-tuple to identify flow, cupled -> coupled >> + * example - VxLAN, VLAN. >> + * SFT: Statfull flow table Statfull -> Stateful >> + * SFT in scope of ethernet device (port) is HW offloaded lookup table ethernet -> Ethernet >> + * where key is zone + 5-tuple & value is statefull flow context. statefull -> stateful >> + * Contents of the SFT maintained by SFT PMD (see SFT PMD API in rte_sft). >> + * >> + * The structure describes SFT flow context. >> + * All the fields of the structure, except @p fid, should be considered as >> + * user defined. >> + * The @p fid assigned by RTE SFT & used as unique flow identifier. >> + * SFT context attached to packet by action ``SFT`` (see RTE_FLOW_ACTION_SFT). >> + * >> + * SFT default context defined as context attached to packet when there is no >> + * entry for the flow in SFT. The @p state has application reserved value >> + * meaning that SFT context for the packet undefined since entry wasn't found >> + * in SFT. If state 'undefined' then @p zone should be valid othervice @p fid othervice -> otherwise >> + * should be valid. >> + * >> + * Context considered virtual since the method of storing this info on packet >> + * is PMD/implementation specific & may involve mapping methods if there is >> + * 'not enough bits' to store entire contents of struct rte_flow_item_sft. >> + * >> + * Maximal value/size of each field depends on HW capabilities and considered >> + * as implementation specific. >> + */ >> +struct rte_flow_item_sft { >> + union { >> + uint32_t fid; /**< SFT flow identifier. */ >> + uint32_t zone; /**< Zone assigned to flow. */ >> + }; Is RTE_STD_C11 missing? >> + uint8_t state; /**< User defined flow state. */ >> + uint8_t fid_valid:1; /**< fid field validity bit. */ >> + uint8_t zone_valid:1; /**< zone fieald validity bit. */ fieald -> field >> + uint8_t state_valid:1; /**< state fieald validity bit. */ fieald -> field >> + uint8_t user_data_size; /**< user_data buffer size. */ >> + uint8_t *user_data; /**< Arbitrary user data. */ >> +}; >> + > This object is only used to match and not set so > why do we need the union? I understand that later when reporting to the SFT in the application layer > sometimes you will get zone while other time you will get fid. > From rte flow you are matching on given object which is 32 bit. > What are the matchable fields? (fid / zone / user_data / fid_valid ... ) > Do you think that some of the times the match will be on he fid other on the zone? > If so they should not be union. > I think zone is the responsibility of the application to save and to match. So I don't see why it is > needed here. +1 > >> /** >> * Matching pattern item definition. >> * >> @@ -2132,6 +2186,15 @@ enum rte_flow_action_type { >> * see enum RTE_ETH_EVENT_FLOW_AGED >> */ >> RTE_FLOW_ACTION_TYPE_AGE, >> + >> + /** >> + * RTE_FLOW_ACTION_TYPE_SFT >> + * >> + * Set SFT context and redirect to continue processing. >> + * >> + * See struct rte_flow_action_sft. >> + */ >> + RTE_FLOW_ACTION_TYPE_SFT, >> }; >> >> /** >> @@ -2721,6 +2784,27 @@ rte_flow_dynf_metadata_set(struct rte_mbuf *m, >> uint32_t v) >> *RTE_FLOW_DYNF_METADATA(m) = v; >> } >> >> +/** >> + * @warning >> + * @b EXPERIMENTAL: this structure may change without prior notice >> + * >> + * RTE_FLOW_ACTION_TYPE_SFT >> + * >> + * Attaches an SFT context (see struct rte_flow_item_sft) to packet. >> + * >> + * Performs lookup by *zone* and 5-tuple in SFT; if entry found the related SFT >> + * context will be attached othervise default SFT context attached (see othervise -> otherwise >> + * 'SFT default context' in struct rte_flow_item_sft description). >> + * Adding action of type ``SFT`` to the list of rule actions may impose >> + * limitations on other rule actions added to the list, depending on specific >> + * PMD implementation. >> + * >> + * For 5-tuple, zone & SFT definitions see `struct rte_flow_item_sft`. >> + */ >> +struct rte_flow_action_sft { >> + uint32_t zone; /**< Zone for lookup in SFT */ >> +}; >> + >> /* >> * Definition of a single action. >> * >> -- >> 2.26.2 > > Thanks, > Ori >