From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D7C3C41CB0; Thu, 16 Feb 2023 11:59:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3356542D12; Thu, 16 Feb 2023 11:59:51 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2067.outbound.protection.outlook.com [40.107.243.67]) by mails.dpdk.org (Postfix) with ESMTP id 68D5F40E0F; Thu, 16 Feb 2023 11:59:50 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FVqtqM5rOrewjzvss8wsc29tZvoslzMYNvdfZFgfi3vKnC95jkDkTiX/G5Yug6d7Hp6wrNwc98R8Ac3gNbCCdFzKnNbzKSSvTg30rv2VVxeSYQ0yKJFO9ovm/q7jG03RXnQocVlKo82Ivik4aJDR4onnoj+GbrCLg1ROv05pEMkeAEz0GQTT6MuNwe00tAF2LRvm5pqxSWUVJ0Vqwk4QRS1qaVoTbYuVE64DwuiK8knsKoCYqUyHoWm2ruIst68ufxwsJ8iMmzMslhwsCJVX1OE/k6CIIYa6ftSBed1v1MIIfCjcd9fm01qyY+2Y3KZVpfmYJR4dLgVIq61Ln1qqpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dIscOJm3L58kt2tYOXVz189K8MG+YlMwex5iFNlJyuw=; b=I+gMudyb7C/MMxnK32x9fINt5oGIQCRJ1EnbaqGw4tKDimAt+xIrmyiZXyNr0Xl+mAiIglfKsrEDKTXGAiugSm27RfTMTKUnKz2qN/roe0yXPTcueghpGSLNAUc7MI5MVZPPqSH1fov1vYmxUwYtNyjIhcR1cVN5wKzVEH+yT0AoDQ1AO8jRn18XBDoHeFkQlNvgdgv8RikWOB7VgTAg4o6Vr6O1MHd0Ev9q+IzWMwrULv7yicUTZzTTMdtajKv2QKD8ecAsmWHpd3OUBJZu9MnL7HeIgCG1+c04YapJq7mGySVlXRE7N/KK7YUE0RXxS1NFRYDkqODNh4yAkl7sGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dIscOJm3L58kt2tYOXVz189K8MG+YlMwex5iFNlJyuw=; b=Mito5VPC1Tk/Ci3tNEuPufXa1vRScXL2GHIOsJJSJGQRC1Yua7ACTxw3bo5srFl0hGAXNuboP2J1vDS3HfZp9v/88ap0XukEHvEYYlreOLhhVzown6UwvGhc7yXA2x2v2VWEaw+Gp49m1/PkkGmpsNxOzWGfTjVbE7tksNlOR7Y= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by IA1PR12MB7565.namprd12.prod.outlook.com (2603:10b6:208:42f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Thu, 16 Feb 2023 10:59:48 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48%7]) with mapi id 15.20.6111.013; Thu, 16 Feb 2023 10:59:48 +0000 Message-ID: Date: Thu, 16 Feb 2023 10:59:41 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH] net/nfp: support 48-bit DMA address for firmware with NFDk Content-Language: en-US To: Chaoyong He , Niklas Soderlund , Kevin Traynor Cc: "Xueming(Steven) Li" , "dev@dpdk.org" , Luca Boccassi , oss-drivers , Nole Zhang , Kevin Liu , "stable@dpdk.org" References: <20230208091544.22122-1-chaoyong.he@corigine.com> <1856a555-e7d5-6dfa-6cf0-c4e170b81482@amd.com> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO3P265CA0028.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:387::11) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|IA1PR12MB7565:EE_ X-MS-Office365-Filtering-Correlation-Id: 2265968a-6de6-4b06-7ce2-08db100ceb24 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 14aPNavQkz0m7VGgunhE+evhCes1HzIsIUhccZPKTWeOWI27kYofK9eZASOBSePVlAe+m0ch2k3U/MAAQVM+HMKuC8ZNIkj6HLGSt7qyRMTENpSfHA5kxs19X5NZ8EbmUFdREy2j46NX5y/+4ZMNBgBNseEAX5TgJNXIAs4KTxef7tjriIyeFH2b7TrA1pyd0gBZWs+64LcnCiz5/dbwmBSuY6s1dKyi1Eal8XQn9fz2xpxZtKzPo4wm0BWPW2sTRvKd+YfPuD5PqtWSARnBGgT3iob7U0HNLAVwpWxQMQTEagGEesvecVe3mCHSDdhHPtE4vxkd5ehtmMem2BMMRAeT1P+SJwaJDiFrkWQwPyMscjZObccxnlmAcdtBaPxuOlrE6mmPmyJkeXYbzxgNrrdc797ItJtFc/wvSI1NXtLKw6Uo2n1bWcgVsPyuRPWi8GA9QCXytrlg/YfkDPyOObdRDrICnxrC7YyNhiqkIHc7fK1PlthR8tamRX960RHNC+ravOHwRBxHECbpWlxKVCc70T6QO5JBCRGeXkgdXEUj274OlxDlqWGIOSgtwB5JuS0gPIfJAhK7+EqYeitjXtUWHHZYGyMLbzDCOTD4a7msFu8mGz0CMmV3yq7XSfG4zDgDgvZLbeeFVnV78QQtYQHKfKlPocCMxNkCqd2a3o+aoDaZvSZ0JCJl2VgdVQmsRa/sd3248gwn1loFLPT17w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(346002)(39860400002)(366004)(136003)(376002)(396003)(451199018)(7416002)(2906002)(8936002)(5660300002)(44832011)(41300700001)(36756003)(966005)(66476007)(4326008)(54906003)(66946007)(8676002)(6486002)(66556008)(110136005)(478600001)(316002)(6512007)(6506007)(38100700002)(31686004)(26005)(66574015)(2616005)(186003)(53546011)(6666004)(86362001)(31696002)(83380400001)(66899018)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MWtJMkJ6ek92LytJZ1pMVTk5M3ZNRmp6WHVTK2pKQWxsblU2ZStLemJ6Z0Q4?= =?utf-8?B?RlBHdDlOVmxQb3dFUldhc0Jsd1ExY01pemRJeTl4R0RDcjd3dGdtNEpqdllt?= =?utf-8?B?N0o5QVh4TXdtRXZ5eE9xc09qUVhFUWxMU0FqVW43RGFiMlFleVJCNFhNOXpU?= =?utf-8?B?ZW0yRFIwZUoxSEdUNVlLMnZQVFlncUVESmZLVGRNWHZBYUpWWmVnelFoZDA2?= =?utf-8?B?ai9DL3RPYWgwZUhWc29HdEhhTFlvNUtQazdkSk54aFVjTWxlU05ZZkxGRys5?= =?utf-8?B?RThLZm5sZnN0a2tTRFpKdk5hdjZiRk5mRit6ZFlUVVlGSW9ZYjZEUTBqYWFu?= =?utf-8?B?ZnNnN1FWUUxxVGpiSDJSNzRKelgwL1c0VHFEbGI3aGUxZklTWlQ3VnhNVnNX?= =?utf-8?B?NjlNbTcyMXlISlJPeWN1MFBQalZaSXMreEdGWTBRdnNoOS81SUl3OTIveWtu?= =?utf-8?B?RU1ZVWR4SWZteUNGWXpjL1hRcEY3QUhxUzlMeS9Neko5UXBrM1g3MnR5eW5M?= =?utf-8?B?c0tJS042Qlh3eW1JMEQva0N6QzZFMmQyTVExY3RsalFLRVdFRWlwRHpVSlh4?= =?utf-8?B?YlJVTm4ybnZtb20rZGx2dWxDSm1DOWt4RHF6S2laTlRpMzAxbDRDR3V6ZTZD?= =?utf-8?B?NWJjZm9GcFpPTklNNnVuQnBMVUd6WlJ3UlB6TldpaGlWMnlXRVlqUjZGL1cy?= =?utf-8?B?OGlBZzM2YXR1cjJCUzdwNW12cW05TkdJamllYUxyK0x2RUxUQUdTS2lSWHQ5?= =?utf-8?B?SitlaGNPbk52R1c5VjNhMXBCQU9ac1dqQUtnMk9nNjJJT0tVeFYzZ1BaY0Uy?= =?utf-8?B?T2RXWVFTY0NQbHdBT2dSVVNSMUVVRngvQ3gwRFVUWXBhSTF3WGhpYUdFbEdK?= =?utf-8?B?NTZmeGlrejJoekYxc1Nid2g2by96OS85MGExUGc1ODFxTHRGZlRKYWsvN2tH?= =?utf-8?B?K1k0c0RJY1lnTFU0MGErTTZMZ1AzYWNxVHVhMEE2TEFJVzRYdlVnVFRaYm1p?= =?utf-8?B?dHJkRVphMFJxeTlENnd6WVhRalExT2g2dG5WUWNyblVyV1ZuZ3pCekdFVFl6?= =?utf-8?B?SGpzU1VoQUkvalI4NVh4d2VnSlJlL05yMEY5aUZHYmlNRlBUNXR2QjFaNXFS?= =?utf-8?B?LzJuWElSK2gycmw2S1BRZmFVdEJNYkZ6Yi9EQlgzOWVlSnVTZEFPaHVHUENF?= =?utf-8?B?OHA2dDRsQ3Z5VzlHQlVGbmQxMWR5blg4L0RyTGk5ZVBjcTZwamxraTZjSFQr?= =?utf-8?B?eEY0eFVIN0ZYKzlKTWhaR0NYWlpzZlVNR0RwMWRkMWo2a0xHRWlBZ0RicjE1?= =?utf-8?B?dHRmSkdkVFFHYnF2TlNWcmVIU3pHTGdzYmJVUU1Bd29FNWV6c25BNzhzdUN6?= =?utf-8?B?TTl5UE9TV2tGRnB2c3NKVjRqNVowR1ZDWlk1V1haYW9Rc1M2OEkzTjQwRmlj?= =?utf-8?B?RDd5cUpXUktDZy80Q0poNXNxVTR1Yysxb1FuV0JuYjR1L25IcUlId2Z5NGpl?= =?utf-8?B?a0V2OVpzSkpha2EyMHBxQlRZaWp1TU5WOERBelJLay93cENpM3A3SmJveVN3?= =?utf-8?B?Qk8rU011a0Rjd0RKblJlQnozeDN1MUVRcFNtRlJDOCtVYXl4eWt5RGFGTHdD?= =?utf-8?B?dVdlK1JCT0FYSTdpN0NYTktGTENmSXZMaFdUaUR4MEt1OHNBR2RtcjY4VmEx?= =?utf-8?B?VHRpMjk2WUxRdklaTlZtMW9sUzZESTRLdC9MUm8xcjNST2kwcyt5dVJuZHVG?= =?utf-8?B?L3hOQjh1Vk1VYnNiUnFYTk93SGFjZWxyNEhJbHpkcXpSTWRxQmlubkIvWHo2?= =?utf-8?B?SjFqdkRkYkhFUWpOb0s1UmdEOGVYVmNhTGUxKytkekVKZjVGZ3h0aXhWUG5K?= =?utf-8?B?S0hvdGRQdllxeE1qQnhONjEvMG9qcUtsTWpxdysweEdrMnJQVWhNY2hQbWVE?= =?utf-8?B?QUljMGF4MlRKTlQrblFZa3NmdEFKUmlKaEVYanozcjkyM045SExZajNEclFV?= =?utf-8?B?RlhkVjJBVWdORytoR1BHMmY3NlRudFZxZU1MNmIvVGx6Y2Qrb3VIMDFUNExH?= =?utf-8?B?VkVzdmtrTUJzcEFZZEVsbXBhQmI1cEo1Zk1QWlJxK05JNmpFaTl1cktDS3Nv?= =?utf-8?Q?XSmLEmUt9ypaimVrq+fgLH9kD?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2265968a-6de6-4b06-7ce2-08db100ceb24 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 10:59:47.5776 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bcoNaMY4brora22OfHiKnSAdfK1bj+xY/GAY/dlx6CmPe2VOK4pPYHGOnd08SLYI X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7565 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/16/2023 10:41 AM, Chaoyong He wrote: > > >> -----Original Message----- >> From: Niklas Soderlund >> Sent: Thursday, February 16, 2023 6:37 PM >> To: Kevin Traynor >> Cc: Ferruh Yigit ; Xueming(Steven) Li >> ; Chaoyong He ; >> dev@dpdk.org; Luca Boccassi ; oss-drivers > drivers@corigine.com>; Nole Zhang ; Kevin Liu >> ; stable@dpdk.org >> Subject: Re: [PATCH] net/nfp: support 48-bit DMA address for firmware with >> NFDk >> >> Hi Kevin, >> >> Thanks for your input. >> >> On 2023-02-16 10:28:34 +0000, Kevin Traynor wrote: >>> On 15/02/2023 18:28, Ferruh Yigit wrote: >>>> On 2/15/2023 5:47 PM, Niklas Söderlund wrote: >>>>> Hi Ferruh, >>>>> >>>>> Thanks for your continues effort in dealing with NFP patches. >>>>> >>>>> On 2023-02-15 13:42:01 +0000, Ferruh Yigit wrote: >>>>>> On 2/8/2023 9:15 AM, Chaoyong He wrote: >>>>>>> From: Peng Zhang >>>>>>> >>>>>>> 48-bit DMA address is supported in the firmware with NFDk, so >>>>>>> enable this feature in PMD now. But the firmware with NFD3 >>>>>>> still just support 40-bit DMA address. >>>>>>> >>>>>>> RX free list descriptor, used by both NFD3 and NFDk, is also >>>>>>> modified to support 48-bit DMA address. That's OK because the >>>>>>> top bits is always set to 0 when assigned with 40-bit DMA address. >>>>>>> >>>>>>> Fixes: c73dced48c8c ("net/nfp: add NFDk Tx") >>>>>>> Cc: jin.liu@corigine.com >>>>>>> Cc: stable@dpdk.org >>>>>>> >>>>>> >>>>>> Why a backport is requested? As far as I understand this is not >>>>>> fixing anything but extending device capability. Is this a fix? >>>>> >>>>> I agree this is a bit of a grey zone. We reasoned this was a fix >>>>> as we should have done this from the start in the commit that >>>>> added support for NFDk. Are you OK moving forward with this as a >>>>> fix or would you prefer we resubmit without the request to backport? >>>>> >>>> >>>> I am not sure, is this change have any potential to change behavior >>>> for existing users? >>>> Like if one of your user is using 22.11.1 release, and if this patch >>>> backported to next LTS version, 22.11.2, will user notice any difference? >>>> >>>> >>>> @Luca, @Kevin, what is your comment as LTS maintainers? >>>> >>> >>> A bit difficult to know. If NFDk is not practicably usable without it, >>> then it could be considered a fix. If it's just extending to add >>> nice-to-have functionality then probably it is not a fix. >> >> I think we can treat this as a nice-to-have and not something that makes >> NFDk unusable. As stated above, we marked this as a Fix as we *really* >> should have done this in the commit which added NFDk support. >> >> @Ferruh, would you prefer we send a v2 or will you drop the Fixes and CC >> tags when/if applying? >> > > Actually, the DPDK app using the nfp card with a firmware of NFDk will coredump without this patch. > And that's the directly reason we consider backport this patch. > It has been long since NFDk FW support added, how a crash missed until this point, is it crashing in a edge case or something? >>> >>> It would need to ensure that it is tested on 22.11 branch and there >>> are no regressions. It is only relevant to DPDK 22.11 LTS so Cc >>> Xueming who will ultimately decide. >>> >>> A guide below on some things to consider for this type of backport is here: >>> http://doc.dpdk.org/guides/contributing/stable.html#what-changes-shoul >>> d-be-backported >>> >>>>>> >>>>>>> Signed-off-by: Peng Zhang >>>>>>> Reviewed-by: Chaoyong He >>>>>>> Reviewed-by: Niklas Söderlund >>>>>> >>>>> >>>> >>> >> >> -- >> Kind Regards, >> Niklas Söderlund