From: Akhil Goyal <akhil.goyal@nxp.com>
To: Hemant Agrawal <hemant.agrawal@nxp.com>, dev@dpdk.org
Cc: pablo.de.lara.guarch@intel.com, dpdk-up@NXP1.onmicrosoft.com
Subject: Re: [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix the default aead assignments
Date: Mon, 16 Apr 2018 14:40:21 +0530 [thread overview]
Message-ID: <ceaf3072-d221-cc88-5385-3e7f18682e1d@nxp.com> (raw)
In-Reply-To: <1523438147-11739-1-git-send-email-hemant.agrawal@nxp.com>
On 4/11/2018 2:45 PM, Hemant Agrawal wrote:
> The code is incorrectly updating the authxform instead of
> aead xforms.
>
> Fixes: b79e4c00af0e ("cryptodev: use AES-GCM/CCM as AEAD algorithms")
> Cc: stable@dpdk.org
>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
> examples/l2fwd-crypto/main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c
> index 4d8341e..38e0c7e 100644
> --- a/examples/l2fwd-crypto/main.c
> +++ b/examples/l2fwd-crypto/main.c
> @@ -1474,8 +1474,8 @@ l2fwd_crypto_default_options(struct l2fwd_crypto_options *options)
> options->aead_iv_random_size = -1;
> options->aead_iv.length = 0;
>
> - options->auth_xform.aead.algo = RTE_CRYPTO_AEAD_AES_GCM;
> - options->auth_xform.aead.op = RTE_CRYPTO_AEAD_OP_ENCRYPT;
> + options->aead_xform.aead.algo = RTE_CRYPTO_AEAD_AES_GCM;
> + options->aead_xform.aead.op = RTE_CRYPTO_AEAD_OP_ENCRYPT;
>
> options->aad_param = 0;
> options->aad_random_size = -1;
>
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
next prev parent reply other threads:[~2018-04-16 9:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-11 9:15 Hemant Agrawal
2018-04-16 9:10 ` Akhil Goyal [this message]
2018-04-17 14:46 ` De Lara Guarch, Pablo
2018-04-17 15:03 ` De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ceaf3072-d221-cc88-5385-3e7f18682e1d@nxp.com \
--to=akhil.goyal@nxp.com \
--cc=dev@dpdk.org \
--cc=dpdk-up@NXP1.onmicrosoft.com \
--cc=hemant.agrawal@nxp.com \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).