From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77ADE41BAB; Thu, 2 Feb 2023 10:13:40 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1E67E406A2; Thu, 2 Feb 2023 10:13:40 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 6BA6440689 for ; Thu, 2 Feb 2023 10:13:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675329217; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1hrSLOoiWJX1/sz0muFlW7W60Ve6DI8nHLircledv4Q=; b=JtELu5olR5YAOsAkiXz/M6j1yLN1wKRtv9yeVe393DkYefEoJ5vw3WdYP6eSgoYwhtMipn oRYXIWp9L0prcoo2+ayhNX1cnxvAHLCJBMkKnFccO2kc3a6afU0l1DGbUd5csoVtMhK2rr 6TP7ObuK4TkvzhJUHDUEXoSV4/qvWPI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-411-jF4zjr3pNMuvTN4b-qM8wg-1; Thu, 02 Feb 2023 04:13:35 -0500 X-MC-Unique: jF4zjr3pNMuvTN4b-qM8wg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5A36A811E9C; Thu, 2 Feb 2023 09:13:34 +0000 (UTC) Received: from [10.39.208.22] (unknown [10.39.208.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B2272404BEC0; Thu, 2 Feb 2023 09:13:32 +0000 (UTC) Message-ID: Date: Thu, 2 Feb 2023 10:13:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v2 1/3] vhost: remove redundant copy for packed shadow used ring To: Cheng Jiang , chenbo.xia@intel.com Cc: dev@dpdk.org, jiayu.hu@intel.com, xuan.ding@intel.com, wenwux.ma@intel.com, yuanx.wang@intel.com, xingguang.he@intel.com References: <20221220004415.29576-1-cheng1.jiang@intel.com> <20230113025653.16583-1-cheng1.jiang@intel.com> <20230113025653.16583-2-cheng1.jiang@intel.com> From: Maxime Coquelin In-Reply-To: <20230113025653.16583-2-cheng1.jiang@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/13/23 03:56, Cheng Jiang wrote: > In the packed ring enqueue data path of the current asynchronous > Vhost design, the shadow used ring is first copied to the sync > shadow used ring, and then it will be moved to the async shadow > used ring for some historical reasons. This is completely unnecessary. > This patch removes redundant copy for the shadow used ring. The async > shadow used ring will be updated directly. > > Signed-off-by: Cheng Jiang > --- > lib/vhost/virtio_net.c | 66 ++++++++++++++++++++---------------------- > 1 file changed, 31 insertions(+), 35 deletions(-) > Reviewed-by: Maxime Coquelin Thanks, Maxime