From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9DCEEA052A; Wed, 27 Jan 2021 02:10:06 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4CC70140D6F; Wed, 27 Jan 2021 02:10:06 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 19439140D6D for ; Wed, 27 Jan 2021 02:10:04 +0100 (CET) IronPort-SDR: BAYX7Mic0JMisLSbEh2xrAQO2TaVubKtS9dPj8ojoA84cG7x0H+EuqjCH/6AappdvXoy6YDqlb WnYt8GNKLQzA== X-IronPort-AV: E=McAfee;i="6000,8403,9876"; a="244076218" X-IronPort-AV: E=Sophos;i="5.79,378,1602572400"; d="scan'208";a="244076218" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2021 17:10:03 -0800 IronPort-SDR: Yb1n8hWMWEUV661ixGo5adontVGonqupQ71IbMVL+W5EIa9cC4pJT27GrlDiMNjRQzzyUm+abW dwWXbZ2WcHsg== X-IronPort-AV: E=Sophos;i="5.79,378,1602572400"; d="scan'208";a="362203439" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.20.116]) ([10.252.20.116]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2021 17:10:01 -0800 To: Nalla Pradeep , Thomas Monjalon , Ray Kinsella , Neil Horman Cc: jerinj@marvell.com, sburla@marvell.com, dev@dpdk.org References: <20210126213051.57281-1-pnalla@marvell.com> From: Ferruh Yigit Message-ID: Date: Wed, 27 Jan 2021 01:09:58 +0000 MIME-Version: 1.0 In-Reply-To: <20210126213051.57281-1-pnalla@marvell.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3 01/11] net/octeontx_ep: add build and doc infrastructure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/26/2021 9:30 PM, Nalla Pradeep wrote: > Adding bare minimum PMD library and doc build infrastructure > and claim the maintainership for octeontx end point PMD. > > Signed-off-by: Nalla Pradeep Hi Nalla, As I quickly checked many comments not addressed, can you please add a change log to the commits to help to trace what is changed in new version? Also for the ones not changed can you please comment on the previous version, so we can be clear if the comment is missed or ignored or not changed and why? Sending new versions as reply to previous version, using 'git send-email' '--reply-to' option helps keeping them in same email thread and helps following previous comments and the history. Would you mind sending a v4 as a reply to v2 with as mentioned above? Thanks, ferruh