From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7FBFBA0540; Mon, 20 Jul 2020 10:57:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 88FAE25B3; Mon, 20 Jul 2020 10:57:04 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 64EA31DBB for ; Mon, 20 Jul 2020 10:57:02 +0200 (CEST) IronPort-SDR: AAHMmAG5huD9VCoDX2lT0eY6QdbDZKepKQGGHGRsJA9mui8RbnP6d23mBhXnCCFyArHT3x8dpn 74mHgPSZWDyw== X-IronPort-AV: E=McAfee;i="6000,8403,9687"; a="137973955" X-IronPort-AV: E=Sophos;i="5.75,374,1589266800"; d="scan'208";a="137973955" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2020 01:57:01 -0700 IronPort-SDR: JHfxH390Lj4gmTDFH6Blg6XLsKIWrxIFcMD98+vtCD6sYN5cb+XxLP+irsxJ4yngSb5AgOZo0Y FjJE5JTi71CA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,374,1589266800"; d="scan'208";a="431543383" Received: from jguo15x-mobl.ccr.corp.intel.com (HELO [10.67.68.178]) ([10.67.68.178]) by orsmga004.jf.intel.com with ESMTP; 20 Jul 2020 01:56:59 -0700 To: zhihongx.peng@intel.com, beilei.xing@intel.com Cc: dev@dpdk.org, declan.doherty@intel.com References: <20200720024214.13972-1-zhihongx.peng@intel.com> From: Jeff Guo Message-ID: Date: Mon, 20 Jul 2020 16:56:59 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200720024214.13972-1-zhihongx.peng@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Subject: Re: [dpdk-dev] [DPDK] net/i40e: add the VLAN capabilities of NIC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" hi,  zhihong On 7/20/2020 10:42 AM, zhihongx.peng@intel.com wrote: > From: Peng Zhihong > > The rte_eth_dev_set_vlan_offload function will check whether the NIC has > the set vlan feature. If it has not, it will return failure. So need "...has the set vlan feature..." , that need to refine. > to add all the vlan feature flags of the NIC. > > Fixes: e0cb96204b71 (net/i40e: add support for representor ports) > Cc: declan.doherty@intel.com > > Signed-off-by: Peng Zhihong > --- > drivers/net/i40e/i40e_vf_representor.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/i40e/i40e_vf_representor.c b/drivers/net/i40e/i40e_vf_representor.c > index b07b35c03..083bc1a5f 100644 > --- a/drivers/net/i40e/i40e_vf_representor.c > +++ b/drivers/net/i40e/i40e_vf_representor.c > @@ -46,7 +46,8 @@ i40e_vf_representor_dev_infos_get(struct rte_eth_dev *ethdev, > DEV_RX_OFFLOAD_QINQ_STRIP | > DEV_RX_OFFLOAD_IPV4_CKSUM | > DEV_RX_OFFLOAD_UDP_CKSUM | > - DEV_RX_OFFLOAD_TCP_CKSUM; > + DEV_RX_OFFLOAD_TCP_CKSUM | > + DEV_RX_OFFLOAD_VLAN_FILTER; > dev_info->tx_offload_capa = > DEV_TX_OFFLOAD_MULTI_SEGS | > DEV_TX_OFFLOAD_VLAN_INSERT |