From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 16FDDA04B1; Wed, 23 Sep 2020 19:45:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DCF911D9DA; Wed, 23 Sep 2020 19:45:41 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 0A47D1D9C7 for ; Wed, 23 Sep 2020 19:45:38 +0200 (CEST) IronPort-SDR: R03polWRarcVcKPpfPSSfdTr3hqRz0dXtNP3bN3QRDyTkXdbaFA8/ca15WlcAthDFoxuMOtrC2 hdBDQ9Z9hdxg== X-IronPort-AV: E=McAfee;i="6000,8403,9753"; a="140989904" X-IronPort-AV: E=Sophos;i="5.77,293,1596524400"; d="scan'208";a="140989904" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2020 10:45:34 -0700 IronPort-SDR: bAYBMPyhTdqhXo7ybfUwsN6hKzZbIAQSYW8rMuKjH6SZKPdm6+gfVmeZCbgnsMs6DIX+tZIf+b cRnMj11UuBlA== X-IronPort-AV: E=Sophos;i="5.77,293,1596524400"; d="scan'208";a="305468568" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.218.147]) ([10.213.218.147]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2020 10:45:33 -0700 To: Andrew Rybchenko , dev@dpdk.org References: <1600764594-14752-1-git-send-email-arybchenko@solarflare.com> <1600767288-12109-1-git-send-email-arybchenko@solarflare.com> From: Ferruh Yigit Message-ID: Date: Wed, 23 Sep 2020 18:45:30 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 MIME-Version: 1.0 In-Reply-To: <1600767288-12109-1-git-send-email-arybchenko@solarflare.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 00/60] common/sfc_efx: support Riverhead NIC family X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/22/2020 10:33 AM, Andrew Rybchenko wrote: > Riverhead is a new NIC family, the first one with EF100 architecture. > Control interface is an MCDI similar to EF10. Datapath interface is > completely new. > > The patch series is build tested with and without EFSYS_OPT_RIVERHEAD > enabled. > > EF10-based NICs are tested with the patch series applied with and > without EFSYS_OPT_RIVERHEAD enabled. > > net/sfc patches will follow. > > v2: > - fix spelling in few patches > - use tabs to indent instead of spaces > > Andrew Rybchenko (41): > common/sfc_efx/base: add EF100 registers definitions > common/sfc_efx/base: update MCDI headers > common/sfc_efx/base: add event queue operation to do polling > common/sfc_efx/base: add efsys option for Riverhead > common/sfc_efx/base: add Riverhead NIC family > common/sfc_efx/base: update registers check for Riverhead > common/sfc_efx/base: use EF10 MCDI methods for Riverhead > common/sfc_efx/base: use EF10 PHY methods for Riverhead > common/sfc_efx/base: move 14b prefix check out of caps get > common/sfc_efx/base: remove PF count get from caps get > common/sfc_efx/base: factor out helper to get board config > common/sfc_efx/base: set NIC features in generic place > common/sfc_efx/base: factor out MCDI entity reset helper > common/sfc_efx/base: add Riverhead support to NIC module > common/sfc_efx/base: use dummy tunnel ops for Riverhead > common/sfc_efx/base: use EF10 filter methods for Riverhead > common/sfc_efx/base: use EF10 MAC methods for Riverhead > common/sfc_efx/base: add interrupts module for Riverhead > common/sfc_efx/base: move EvQ init/fini wrappers to generic > common/sfc_efx/base: move EvQ create generic checks > common/sfc_efx/base: prepare to merge EvQ init functions > common/sfc_efx/base: merge versions of init EvQ wrappers > common/sfc_efx/base: add event queue module for Riverhead > common/sfc_efx/base: handle MCDI events on Riverhead > common/sfc_efx/base: move RxQ init/fini wrappers to generic > common/sfc_efx/base: move TxQ init/fini wrappers to generic > common/sfc_efx/base: switch TxQ init to extended version > common/sfc_efx/base: maintain RxQ counter in generic code > common/sfc_efx/base: free Rx queue structure in generic code > common/sfc_efx/base: move Rx index check to generic code > common/sfc_efx/base: implement Rx control path for Riverhead > common/sfc_efx/base: implement Tx control path for Riverhead > common/sfc_efx/base: fix Tx descriptor DMA sync on Riverhead > common/sfc_efx/base: handle Rx events for Riverhead > common/sfc_efx/base: handle Tx complete on Riverhead > common/sfc_efx: do not include libefx headers from efsys.h > common/sfc_efx/base: add API to get Rx prefix information > common/sfc_efx/base: group RxQ parameters into a structure > common/sfc_efx/base: choose smallest Rx prefix on Riverhead > common/sfc_efx/base: use EF10 EVB methods for Riverhead > common/sfc_efx/base: allocate vAdaptor on Riverhead > > Andy Moreton (7): > common/sfc_efx/base: add option for extended width events > common/sfc_efx/base: add 256bit type > common/sfc_efx/base: support creation of extended width EvQ > common/sfc_efx/base: poll extended width event queues > common/sfc_efx/base: handle normal events in extended width > common/sfc_efx/base: add option for descriptor proxy queues > common/sfc_efx/base: handle descriptor proxy queue events > > Igor Romanov (9): > common/sfc_efx/base: add function control window concept > common/sfc_efx/base: add function control window lookup API > common/sfc_efx/base: add efsys API to find a memory BAR > common/sfc_efx/base: add Xilinx capabilities table lookup > common/sfc_efx/base: add NIC magic check on BAR lookup > common/sfc_efx/base: introduce UDP tunnel destruct operation > common/sfc_efx/base: introduce states for UDP tunnel entries > common/sfc_efx/base: support UDP tunnel operations for EF100 > common/sfc_efx/base: replace PCI efsys macros with functions > > Ivan Malov (3): > common/sfc_efx/base: complete EvQ creation on Riverhead > common/sfc_efx/base: indicate support for TSO version 3 > common/sfc_efx/base: report restrictions for TSO version 3 > Can you please check following checkpatch warnings, there are many warnings but most of them ignored because of base files, but below ones can be fixed I think: WARNING:TYPO_SPELLING: 'inital' may be misspelled - perhaps 'initial'? #7796: FILE: drivers/common/sfc_efx/base/efx_regs_mcdi.h:24607: +/* The inital producer index for this queue's used ring. If this queue is being WARNING:TYPO_SPELLING: 'inital' may be misspelled - perhaps 'initial'? #7803: FILE: drivers/common/sfc_efx/base/efx_regs_mcdi.h:24614: +/* The inital consumer index for this queue's available ring. If this queue is WARNING:TYPO_SPELLING: 'endianess' may be misspelled - perhaps 'endianness'? #199: FILE: drivers/common/sfc_efx/base/efx.h:2794: + * Location and endianess of a field in Rx prefix. WARNING:TYPO_SPELLING: 'requries' may be misspelled - perhaps 'requires'? #74: FILE: drivers/common/sfc_efx/base/efx_pci.c:328: + * Xilinx Capabilities Table requries 32bit aligned reads.