From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A4CBBA3160 for ; Wed, 9 Oct 2019 09:55:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3550D1D16A; Wed, 9 Oct 2019 09:55:18 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id CC8171D167 for ; Wed, 9 Oct 2019 09:55:16 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 4ED9C10005E; Wed, 9 Oct 2019 07:55:15 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 9 Oct 2019 08:55:09 +0100 To: "Su, Simei" , "Zhang, Qi Z" , "Ye, Xiaolong" , "Yigit, Ferruh" CC: "dev@dpdk.org" References: <1570164362-64775-1-git-send-email-simei.su@intel.com> <1570604240-97643-1-git-send-email-simei.su@intel.com> <1570604240-97643-3-git-send-email-simei.su@intel.com> <9a54b5b8-8364-36e6-ff9a-6e4b6cd3aeda@solarflare.com> <65F28F834D25B54B9EC1999B623071B30C4637A4@SHSMSX104.ccr.corp.intel.com> From: Andrew Rybchenko Message-ID: Date: Wed, 9 Oct 2019 10:55:06 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <65F28F834D25B54B9EC1999B623071B30C4637A4@SHSMSX104.ccr.corp.intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24964.003 X-TM-AS-Result: No-5.331200-8.000000-10 X-TMASE-MatchedRID: UuaOI1zLN1jmLzc6AOD8DfHkpkyUphL9Ud7Bjfo+5jTVEYfep7SzpuMN Q/xRdQ+dsOgv3K25H2lPaSCGuTUzHH/BjdQS1Tt2DDlsUbcsIPoiyyRgkoGSpBHFkFAjR1tn5A9 pdKtow17qMNZsGUCbYVTc4Z0AZzK6YlldA0POS1I6n9A7T5Z+J0qAhuLHn5fEjFFYmmGGytxLj4 83upWI8/OBRT+axaCefoUCihtltY5wYKSOfcZadnYZxYoZm58FMHi1Ydy2WEjfv+b0FmD8oLJnP h8w+R5ofK8SWgggeS6mmCZmjD3OPxN+JiqkEYnphL9NX2TqmkB9m5tDcb5SYUYza41dGqxSMRO6 upoJau7s6H1VzAgFU5GTpe1iiCJq71zr0FZRMbBuHY1mnovlhPoA9r2LThYYKrauXd3MZDU6iB5 nOeIQYWQvAEcdHmGaOdKZGWnlHzIvfuxIjobLmwySd2GVpvGAsu5LKD0mZaO56RZnNgTmJfBXa2 GAQoYm/BpXYG+Z44QrzxvBh2nlswbEQIfFpkwHBtlgFh29qnpKzBwu5JpklnOUuoTXM7r4Qwymt xuJ6y0= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--5.331200-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24964.003 X-MDID: 1570607716-KdNcZHFUQjQf Subject: Re: [dpdk-dev] [PATCH v11 2/3] ethdev: extend RSS offload types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/9/19 10:42 AM, Su, Simei wrote: > Hi, Andrew > >> -----Original Message----- >> From: Andrew Rybchenko [mailto:arybchenko@solarflare.com] >> Sent: Wednesday, October 9, 2019 3:18 PM >> To: Su, Simei ; Zhang, Qi Z ; Ye, >> Xiaolong ; Yigit, Ferruh >> Cc: dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v11 2/3] ethdev: extend RSS offload types >> >> On 10/9/19 9:57 AM, Simei Su wrote: >>> This patch reserves several bits as input set selection from the high >>> end of the 64 bits. It is combined with exisiting ETH_RSS_* to >>> represent RSS types. >>> >>> Signed-off-by: Simei Su >>> Reviewed-by: Qi Zhang >>> Acked-by: Ori Kam [snip] >>> a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h >>> index 7722f70..ef59ed5 100644 >>> --- a/lib/librte_ethdev/rte_ethdev.h >>> +++ b/lib/librte_ethdev/rte_ethdev.h >>> @@ -4034,6 +4048,27 @@ int rte_eth_dev_adjust_nb_rx_tx_desc(uint16_t port_id, >>> void * >>> rte_eth_dev_get_sec_ctx(uint16_t port_id); >>> >>> +/** >>> + * If SRC_ONLY and DST_ONLY of the same level are used >>> + * simultaneously, it is the same case as none of them >>> + * are added. >>> + * >>> + * @param rss_hf >>> + * RSS types with SRC/DST_ONLY. >>> + * @return >>> + * RSS types. >>> + */ >>> +static inline uint64_t >>> +strip_out_src_dst_only(uint64_t rss_hf) >> Inline function in public header without corresponding prefix is a bad idea. >> Please, move it to C file and I think that inline should be removed. >> Let the compiler do its job. > Because I also need to check simultaneous use of SRC/DST_ONLY in PMD driver. > In order to call strip_out_src_dst_only() function directly in driver, > I put it in header file and declare it as inline function. At bare minimum it should have rte_eth_dev_ prefix. Also from the name it is not clear that it is about RSS etc. Not sure why you need it in driver as well, hopefully I'll see. Andrew.