From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 617211B19F for ; Thu, 5 Oct 2017 10:38:53 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Oct 2017 01:38:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,480,1500966000"; d="scan'208";a="906986980" Received: from dhunt5-mobl1.ger.corp.intel.com (HELO [10.237.220.44]) ([10.237.220.44]) by FMSMGA003.fm.intel.com with ESMTP; 05 Oct 2017 01:38:51 -0700 To: santosh , dev@dpdk.org Cc: konstantin.ananyev@intel.com, jingjing.wu@intel.com, Nemanja Marjanovic , Rory Sexton References: <1506342429-199695-1-git-send-email-david.hunt@intel.com> <1507108515-186477-1-git-send-email-david.hunt@intel.com> <1507108515-186477-3-git-send-email-david.hunt@intel.com> From: "Hunt, David" Message-ID: Date: Thu, 5 Oct 2017 09:38:51 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v4 2/9] lib/librte_power: add extra msg type for policies X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Oct 2017 08:38:54 -0000 Hi Santosh, On 4/10/2017 4:36 PM, santosh wrote: > Hi David, > > > On Wednesday 04 October 2017 02:45 PM, David Hunt wrote: >> Signed-off-by: Nemanja Marjanovic >> Signed-off-by: Rory Sexton >> Signed-off-by: David Hunt >> --- > my 2cent: > General comment on implementation approach: > IMO, we should avoid PMD details in common lib area. > example: file channel_commons.h has ifdef clutter referencing > i40e pmds all over. > > Perhaps we should introduce opaque handle example void * or introduce pmd > specific callback/handle which points to PMD specific metadata in power library. > > Example: > struct channel_packet { > void *pmd_specific_metadata; > } > > Or someway via callback (I'm not sure at the moment) > so that we could hide PMD details in common area. > > Thanks. I would agree that PMD specific details are good left to the PMDs, however I think that the initial example should be OK as is, and as new PMDs are added, we can find commonality between them which stays in the example, and any really specific stuff can be pushed back behind an opaque. What about the v5 I submitted (without the #ifdef's)? Are you OK with that for this release, and we can fine tune as other PMDS are added in future releases? Regards, Dave.