From: Ferruh Yigit <ferruh.yigit@intel.com>
To: liqingqing <liqingqing3@huawei.com>,
xuanziyang2@huawei.com, cloud.wangxiaoyun@huawei.com,
zhouguoyang@huawei.com
Cc: Hushiyuan <hushiyuan@huawei.com>,
wangshuo47@huawei.com, Liusirui <liusirui@huawei.com>,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] net/hinic: fix secondary process's using coredump.
Date: Mon, 14 Sep 2020 14:21:33 +0100 [thread overview]
Message-ID: <cf10c4c9-a855-cd28-88cb-5b4e4e15c403@intel.com> (raw)
In-Reply-To: <ff08ad4b-bddd-f9be-d3e2-06dc0ca86623@intel.com>
On 9/1/2020 12:44 PM, Ferruh Yigit wrote:
> On 8/8/2020 8:45 AM, liqingqing wrote:
>> fix coredump when secondary process using the hinic port.
>> the reason is that during the stage of
>> secondary process port initialization,
>> it lack the initialization of "eth_dev->dev_ops".
>>
>> Signed-off-by: liqingqing <liqingqing3@huawei.com>
>
> Hi,
>
> Overall patch looks good but can you please add your name and surname to the
> sign off, to make it following syntax:
> Signed-off-by: Name Surname <liqingqing3@huawei.com>
>
> Also what do you think about following patch title:
> "net/hinic: fix crash in secondary process"
>
Hi Ziyang, Xiaoyun, Guoyang,
Can you please review the patch, also can you please help on getting the
correct sign off?
next prev parent reply other threads:[~2020-09-14 13:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-08 7:20 [dpdk-dev] [PATCH] net/hinic: fix coredump when secondary process using the hinic port liqingqing
2020-08-08 7:45 ` [dpdk-dev] [PATCH v2] net/hinic: fix secondary process's using coredump liqingqing
2020-09-01 11:44 ` Ferruh Yigit
2020-09-14 13:21 ` Ferruh Yigit [this message]
[not found] ` <12de74a8-9b1c-d664-0ea3-89c80f69b9e2@huawei.com>
[not found] ` <f3b34a16-9fca-e2e2-d11a-7f55c35268de@huawei.com>
2020-10-09 7:47 ` [dpdk-dev] [PATCH v3] " l00283554
2020-10-13 8:46 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf10c4c9-a855-cd28-88cb-5b4e4e15c403@intel.com \
--to=ferruh.yigit@intel.com \
--cc=cloud.wangxiaoyun@huawei.com \
--cc=dev@dpdk.org \
--cc=hushiyuan@huawei.com \
--cc=liqingqing3@huawei.com \
--cc=liusirui@huawei.com \
--cc=wangshuo47@huawei.com \
--cc=xuanziyang2@huawei.com \
--cc=zhouguoyang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).