From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 885C3A04C7; Mon, 14 Sep 2020 15:21:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 786EAFFA; Mon, 14 Sep 2020 15:21:41 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id A33C7160 for ; Mon, 14 Sep 2020 15:21:39 +0200 (CEST) IronPort-SDR: +fkDAwTJlWyNkBb0UAu+S6eaZXfcj76ZXiztbPYMXzcreMH5YwkycrAN7EF6FPhK0gJ+H294jT FR0no8DptpQA== X-IronPort-AV: E=McAfee;i="6000,8403,9743"; a="146814740" X-IronPort-AV: E=Sophos;i="5.76,426,1592895600"; d="scan'208";a="146814740" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2020 06:21:38 -0700 IronPort-SDR: JaMhn5ZIVu2g8V7Cszl0PnpO8YUNWJVTIZzvhSN0UiNy/izgyFwMMYVk19CbqN/c62YVPD373u bXUKgosH+i2A== X-IronPort-AV: E=Sophos;i="5.76,426,1592895600"; d="scan'208";a="507138911" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.247.225]) ([10.213.247.225]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2020 06:21:36 -0700 From: Ferruh Yigit To: liqingqing , xuanziyang2@huawei.com, cloud.wangxiaoyun@huawei.com, zhouguoyang@huawei.com Cc: Hushiyuan , wangshuo47@huawei.com, Liusirui , dev@dpdk.org References: <5147753f-bb23-ee21-5ba8-4eb8ef908225@huawei.com> <238443d2-512d-185d-945e-6c77815f7888@huawei.com> Message-ID: Date: Mon, 14 Sep 2020 14:21:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] net/hinic: fix secondary process's using coredump. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/1/2020 12:44 PM, Ferruh Yigit wrote: > On 8/8/2020 8:45 AM, liqingqing wrote: >> fix coredump when secondary process using the hinic port. >> the reason is that during the stage of >> secondary process port initialization, >> it lack the initialization of "eth_dev->dev_ops". >> >> Signed-off-by: liqingqing > > Hi, > > Overall patch looks good but can you please add your name and surname to the > sign off, to make it following syntax: > Signed-off-by: Name Surname > > Also what do you think about following patch title: > "net/hinic: fix crash in secondary process" > Hi Ziyang, Xiaoyun, Guoyang, Can you please review the patch, also can you please help on getting the correct sign off?