From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CE7FB41CEC; Mon, 20 Feb 2023 17:09:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BD82B43081; Mon, 20 Feb 2023 17:09:44 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 80AB940395 for ; Mon, 20 Feb 2023 17:09:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676909383; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FqtNy9NUTa69OdIsvbuMh6CM8zTj/2p78TRFZ7iby/w=; b=OE6AYUcDGnboPtgcFm+mRP5gJENJb4MW+DnGws+QSxL12YaLdtL3m0YNOhZBH+DA/3yEJb QdkpjTBcon3o4hNaX5hEeSGg8pJvAswjoQyoGt/s9tVK+c20dAG6QzjLyLW8roeE9MOmCl KtPvGxehTjjmNP5X4UvwCebwwvtp8uc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-556-uSKTT6TjNbCLCEe4Fy6yFA-1; Mon, 20 Feb 2023 11:09:41 -0500 X-MC-Unique: uSKTT6TjNbCLCEe4Fy6yFA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2F5E9802D2F; Mon, 20 Feb 2023 16:09:41 +0000 (UTC) Received: from [10.39.208.21] (unknown [10.39.208.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A42A2492B00; Mon, 20 Feb 2023 16:09:39 +0000 (UTC) Message-ID: Date: Mon, 20 Feb 2023 17:09:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 02/16] test/bbdev: extend HARQ tolerance To: Hernan Vargas , dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com, stable@dpdk.org References: <20230215170949.60569-1-hernan.vargas@intel.com> <20230215170949.60569-3-hernan.vargas@intel.com> From: Maxime Coquelin In-Reply-To: <20230215170949.60569-3-hernan.vargas@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/15/23 18:09, Hernan Vargas wrote: > HARQ memory implementation could have different size assumptions. > Extending HARQ tolerance to cover different implementations. > > Fixes: 335c11fd276 ("app/bbdev: support HARQ validation") > Cc: stable@dpdk.org > > Signed-off-by: Hernan Vargas > --- > app/test-bbdev/test_bbdev_perf.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c > index 027f32cbf1..74e7e13940 100644 > --- a/app/test-bbdev/test_bbdev_perf.c > +++ b/app/test-bbdev/test_bbdev_perf.c > @@ -95,6 +95,7 @@ > #define K0_3_1 56 /* K0 fraction numerator for rv 3 and BG 1 */ > #define K0_3_2 43 /* K0 fraction numerator for rv 3 and BG 2 */ > > +#define HARQ_MEM_TOLERANCE 256 > static struct test_bbdev_vector test_vector; > > /* Switch between PMD and Interrupt for throughput TC */ > @@ -2090,13 +2091,17 @@ validate_op_harq_chain(struct rte_bbdev_op_data *op, > uint16_t data_len = rte_pktmbuf_data_len(m) - offset; > total_data_size += orig_op->segments[i].length; > > - TEST_ASSERT(orig_op->segments[i].length < > - (uint32_t)(data_len + 64), > + TEST_ASSERT(orig_op->segments[i].length < (uint32_t)(data_len + HARQ_MEM_TOLERANCE), > "Length of segment differ in original (%u) and filled (%u) op", > orig_op->segments[i].length, data_len); > harq_orig = (int8_t *) orig_op->segments[i].addr; > harq_out = rte_pktmbuf_mtod_offset(m, int8_t *, offset); > > + /* Cannot compare HARQ output data for such cases */ > + if ((ldpc_llr_decimals > 1) && ((ops_ld->op_flags & RTE_BBDEV_LDPC_LLR_COMPRESSION) > + || (ops_ld->op_flags & RTE_BBDEV_LDPC_HARQ_6BIT_COMPRESSION))) > + break; > + > if (!(ldpc_cap_flags & > RTE_BBDEV_LDPC_INTERNAL_HARQ_MEMORY_FILLERS > ) || (ops_ld->op_flags & > @@ -2172,7 +2177,7 @@ validate_op_harq_chain(struct rte_bbdev_op_data *op, > > /* Validate total mbuf pkt length */ > uint32_t pkt_len = rte_pktmbuf_pkt_len(op->data) - op->offset; > - TEST_ASSERT(total_data_size < pkt_len + 64, > + TEST_ASSERT(total_data_size < pkt_len + HARQ_MEM_TOLERANCE, > "Length of data differ in original (%u) and filled (%u) op", > total_data_size, pkt_len); > Reviewed-by: Maxime Coquelin Thanks, Maxime