From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id F3CD02C72 for ; Tue, 20 Jun 2017 15:58:27 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0ORU00DXBMTETM40@mailout1.w1.samsung.com> for dev@dpdk.org; Tue, 20 Jun 2017 14:58:26 +0100 (BST) Received: from eusmges1.samsung.com (unknown [203.254.199.239]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20170620135825eucas1p2c13d2e1e03df8b7d58c39989b3600e8c~J2SVwyWyH0702307023eucas1p2S; Tue, 20 Jun 2017 13:58:25 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1.samsung.com (EUCPMTA) with SMTP id 7C.7F.14140.40A29495; Tue, 20 Jun 2017 14:58:28 +0100 (BST) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20170620135825eucas1p238a2c83597dcdcdbd35a69cf27ab9df6~J2SVFHNWt0701107011eucas1p2O; Tue, 20 Jun 2017 13:58:25 +0000 (GMT) X-AuditID: cbfec7ef-f796a6d00000373c-3b-59492a04084d Received: from eusync1.samsung.com ( [203.254.199.211]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id BE.30.17452.10A29495; Tue, 20 Jun 2017 14:58:25 +0100 (BST) Received: from [106.109.129.180] by eusync1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0ORU0003IMTCD500@eusync1.samsung.com>; Tue, 20 Jun 2017 14:58:25 +0100 (BST) To: Thomas Monjalon Cc: dev@dpdk.org, Hemant Agrawal , Sergio Gonzalez Monroy , Bruce Richardson , David Marchand , Heetae Ahn , Yuanhan Liu , Jianfeng Tan , Neil Horman , Yulong Pei From: Ilya Maximets Message-id: Date: Tue, 20 Jun 2017 16:58:23 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-version: 1.0 In-reply-to: <2889333.ySLvsRWIRF@xps> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrOKsWRmVeSWpSXmKPExsWy7djP87osWp6RBj+7+S1urLK3WNHRzmLx 7tN2Jotpn2+zW6x8vJHN4kr7T3aL7tlf2CxuNZ9ks1gx4QijxacHJ1gsWpbsZLL49uA7swOP x8X+O4wevxYsZfW48e8Wm8fiPS+ZPI7dnMbusfHdDiaPvi2rGD2ufF/NGMARxWWTkpqTWZZa pG+XwJXx4U0DS8Ft3oqzrSINjO+5uhg5OSQETCTebp7DDmGLSVy4t56ti5GLQ0hgGaPEldd7 mSGcz4wSq461s3QxcoB1rOpLAGkAK5rSzwxhv2CUuN1gCGILC7hLvDtyngnEFhHQlLj9fRYj yBxmgUnMEgs+/2EFSbAJ6EicWn2EEcTmFbCT+L97BVgDi4CqxMRFy8BqRAUiJK7P2QJVIyjx Y/I9sBs4gWqu9wqDhJkFDCRmTDnMBGHLS2xe8xbsZgmBR+wSP9duYIS4WVZi0wFmiCddJLYc bYJ6WFji1fEtULaMRGfHQSaI3mZGiYZVlxghnAmMEl+alzNBVNlLnLp5FWobn8SkbdOZIRbw SnS0CUGUeEjcaTrFAmE7Shya+p0REogzmSRebr3BPoFRfhaSf2YheWIWkicWMDKvYhRJLS3O TU8tNtQrTswtLs1L10vOz93ECExOp/8df7+D8WlzyCFGAQ5GJR7eCGXPSCHWxLLiytxDjBIc zEoivPckgEK8KYmVValF+fFFpTmpxYcYpTlYlMR5eU9dixASSE8sSc1OTS1ILYLJMnFwSjUw 6r45o1GTbsLYF603a1q74qarr/5v2SjUODvTwfxrmL3Ym/fnpzAa397A4uN2VqNB6Mn58ytP KxWWhsw9Yyrt7vsz4POSvmktl45czY147bGf5VVivPK8f+XLc3cs+2m9I/5B/hWOlUWdiZvc NaL5Ans2PPug8vtqYefR+IL8yckHfvEtW3f0rxJLcUaioRZzUXEiAE74z8xKAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrGIsWRmVeSWpSXmKPExsVy+t/xy7qMWp6RBvNecVjcWGVvsaKjncXi 3aftTBbTPt9mt1j5eCObxZX2n+wW3bO/sFncaj7JZrFiwhFGi08PTrBYtCzZyWTx7cF3Zgce j4v9dxg9fi1Yyupx498tNo/Fe14yeRy7OY3dY+O7HUwefVtWMXpc+b6aMYAjys0mIzUxJbVI ITUvOT8lMy/dVik0xE3XQkkhLzE31VYpQtc3JEhJoSwxpxTIMzJAAw7OAe7BSvp2CW4ZH940 sBTc5q042yrSwPieq4uRg0NCwERiVV9CFyMnkCkmceHeerYuRi4OIYEljBIHv1xkgnBeMEq0 NDeygVQJC7hLvDtyngnEFhHQlLj9fRYjRNFMJokJh48zgzjMAlOYJRa/f8oKUsUmoCNxavUR RhCbV8BO4v/uFWDdLAKqEhMXLQOrERWIkHjYuYsdokZQ4sfkeywg53EC1VzvFQYxmQX0JO5f 1AKpYBaQl9i85i3zBEaBWUgaZiFUzUJStYCReRWjSGppcW56brGhXnFibnFpXrpecn7uJkZg nG479nPzDsZLG4MPMQpwMCrx8DIoekYKsSaWFVfmHmKU4GBWEuG9JwEU4k1JrKxKLcqPLyrN SS0+xGgK9MFEZinR5HxgCskriTc0MTS3NDQytrAwNzJSEuct+XAlXEggPbEkNTs1tSC1CKaP iYNTqoEx1rVuq6+1xzt9owgnARd3mZeOHz9bBm4q8fsek/rLad7Bp3nfJ31Z9N3rxHGmRQs4 vxziDuK6sd9V3TeRbVccB4PCgnpte+7VAaIfOI/c9OuX8lLTmPjtXyjbFbUr//o36FZvuH96 67ZLrSZ5tcUCz+Und52wSmT7sjr0UYNg16vwaUaHw+4psRRnJBpqMRcVJwIAMxcyRukCAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170620135825eucas1p238a2c83597dcdcdbd35a69cf27ab9df6 X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?UTF-8?B?SWx5YSBNYXhpbWV0cxtTUlItVmlydHVhbGl6YXRpb24gTGFi?= =?UTF-8?B?G+yCvOyEseyghOyekBtMZWFkaW5nIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?SWx5YSBNYXhpbWV0cxtTUlItVmlydHVhbGl6YXRpb24gTGFi?= =?UTF-8?B?G1NhbXN1bmcgRWxlY3Ryb25pY3MbTGVhZGluZyBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0NJU0hRG0MxMEdEMDFHRDAxMDE1NA==?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170620130715epcas5p45db9c20aedb6ff05d7231790f3d24c0e X-RootMTR: 20170620130715epcas5p45db9c20aedb6ff05d7231790f3d24c0e References: <1496736832-835-1-git-send-email-i.maximets@samsung.com> <3ccc716f-27ae-55a4-0751-c60b5329d7a4@nxp.com> <2889333.ySLvsRWIRF@xps> Subject: Re: [dpdk-dev] [PATCH v5 0/2] Balanced allocation of hugepages X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jun 2017 13:58:28 -0000 On 20.06.2017 16:07, Thomas Monjalon wrote: > 19/06/2017 13:10, Hemant Agrawal: >>>>> On Thu, Jun 08, 2017 at 02:21:58PM +0300, Ilya Maximets wrote: >>>>>> So, there are 2 option: >>>>>> >>>>>> 1. Return back config option RTE_LIBRTE_EAL_NUMA_AWARE_HUGEPAGES >>>>>> from the first version of the patch and disable it by default. >>>>>> >>>>>> 2. Keep patch as it is now and make everyone install libnuma >>>>>> for successful build. >>> >> +1 for option 1 >> It will be a issue and undesired dependency for SoCs, not supporting >> NUMA architecture. >> >> It can be added to the config, who desired to use it by default. > > Yes I agree, it cannot be a dependency for architectures which > do not support NUMA. > Please can we rework the patch so that only one node is assumed > if NUMA is disabled for the architecture? We're still don't have dynamic build time configuration system. To make get/set_mempolicy work we need to include and have libnuma for successful linkage. This means that the only option to not have libnuma as dependency is to return back configuration option RTE_LIBRTE_EAL_NUMA_AWARE_HUGEPAGES as it was in the first version of the patch. There is, actually, the third option (besides 2 already described): 3. Return back config option RTE_LIBRTE_EAL_NUMA_AWARE_HUGEPAGES from the first version of the patch and *enable* it by default. In this case anyone who doesn't want to have libnuma as dependency will be able to disable the config option manually. Thomas, what do you think? Bruce? Sergio? P.S. We're always able to implement syscall wrappers by hands without any external dependencies, but I don't think it's a good decision.