From: "Hu, Jiayu" <jiayu.hu@intel.com> To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, yang_y_yi <yang_y_yi@163.com> Cc: "dev@dpdk.org" <dev@dpdk.org>, "olivier.matz@6wind.com" <olivier.matz@6wind.com>, "thomas@monjalon.net" <thomas@monjalon.net>, "yangyi01@inspur.com" <yangyi01@inspur.com> Subject: Re: [dpdk-dev] [PATCH] gso: fix free issue of mbuf gso segments attach to Date: Thu, 15 Oct 2020 05:14:35 +0000 Message-ID: <cf33f4b88dcf44cf890fb8e6163ddb36@intel.com> (raw) In-Reply-To: <SN6PR11MB3310BA07C362EEAA2235DD899A050@SN6PR11MB3310.namprd11.prod.outlook.com> > -----Original Message----- > From: Ananyev, Konstantin <konstantin.ananyev@intel.com> > Sent: Wednesday, October 14, 2020 8:06 PM > To: yang_y_yi <yang_y_yi@163.com>; Hu, Jiayu <jiayu.hu@intel.com> > Cc: dev@dpdk.org; olivier.matz@6wind.com; thomas@monjalon.net; > yangyi01@inspur.com > Subject: RE: Re:RE: [PATCH] gso: fix free issue of mbuf gso segments attach to > > > > From: yang_y_yi <yang_y_yi@163.com> > > Sent: Wednesday, October 14, 2020 3:56 AM > > To: Hu, Jiayu <jiayu.hu@intel.com> > > Cc: Ananyev, Konstantin <konstantin.ananyev@intel.com>; dev@dpdk.org; > olivier.matz@6wind.com; thomas@monjalon.net; > > yangyi01@inspur.com > > Subject: Re:RE: [PATCH] gso: fix free issue of mbuf gso segments attach to > > > > I think it isn't a good idea to free it in rte_gso_segment, maybe application > will continue to use this pkt for other purpose, rte_gso_segment > > can't make decision for application without any notice, it is better to return > this decision right backt to application. > > > > I think, if user wants to keep original packet, he can always call > rte_pktmbuf_refcnt_update(pkt, 1) > just before calling gso function. > > Also, as I remember in some cases it is not safe to do free() for input packet > (as pkt_out[] can contain input pkt itself). Would it also be user responsibility > to determine > such situations? In what case will pkt_out[] contain the input pkt? Can you give an example? Thanks, Jiayu > > P.S. Please don't reply on the top. > > Konstantin > > > > > > > > >
next prev parent reply other threads:[~2020-10-15 5:14 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-10 3:10 yang_y_yi 2020-10-13 7:28 ` Hu, Jiayu 2020-10-13 15:39 ` Ananyev, Konstantin 2020-10-14 1:00 ` Hu, Jiayu 2020-10-14 2:56 ` yang_y_yi 2020-10-14 12:05 ` Ananyev, Konstantin 2020-10-15 5:14 ` Hu, Jiayu [this message] 2020-10-15 16:16 ` Ananyev, Konstantin 2020-10-16 0:53 ` Hu, Jiayu 2020-10-16 8:31 ` Ananyev, Konstantin 2020-10-19 3:17 ` Hu, Jiayu 2020-10-19 6:44 ` yang_y_yi 2020-10-19 8:47 ` Ananyev, Konstantin 2020-10-20 1:16 ` yang_y_yi 2020-10-19 2:29 ` yang_y_yi 2020-10-19 2:20 ` yang_y_yi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cf33f4b88dcf44cf890fb8e6163ddb36@intel.com \ --to=jiayu.hu@intel.com \ --cc=dev@dpdk.org \ --cc=konstantin.ananyev@intel.com \ --cc=olivier.matz@6wind.com \ --cc=thomas@monjalon.net \ --cc=yang_y_yi@163.com \ --cc=yangyi01@inspur.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git