From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 3B5BA2C6E for ; Mon, 15 Jan 2018 11:41:13 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jan 2018 02:41:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,363,1511856000"; d="scan'208";a="21577164" Received: from unknown (HELO [10.237.221.96]) ([10.237.221.96]) by fmsmga004.fm.intel.com with ESMTP; 15 Jan 2018 02:41:10 -0800 To: "De Lara Guarch, Pablo" , "dev@dpdk.org" Cc: "Ananyev, Konstantin" , "Yigit, Ferruh" , "Gonzalez Monroy, Sergio" , "Doherty, Declan" , "akhil.goyal@nxp.com" References: <1513083027-11741-1-git-send-email-radu.nicolau@intel.com> <1513083027-11741-3-git-send-email-radu.nicolau@intel.com> From: Radu Nicolau Message-ID: Date: Mon, 15 Jan 2018 10:41:09 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH 3/3] examples/ipsec_secgw: create session mempools for ethdevs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jan 2018 10:41:14 -0000 On 1/8/2018 11:03 AM, De Lara Guarch, Pablo wrote: > >> -----Original Message----- >> From: Nicolau, Radu >> Sent: Tuesday, December 12, 2017 12:50 PM >> To: dev@dpdk.org >> Cc: Ananyev, Konstantin ; Yigit, Ferruh >> ; Gonzalez Monroy, Sergio >> ; De Lara Guarch, Pablo >> ; Doherty, Declan >> ; akhil.goyal@nxp.com; Nicolau, Radu >> >> Subject: [PATCH 3/3] examples/ipsec_secgw: create session mempools for >> ethdevs >> >> Also moved offloaded packets from cryptodev queues >> >> Signed-off-by: Radu Nicolau >> --- >> examples/ipsec-secgw/ipsec-secgw.c | 42 >> +++++++++++++++++++++++++++++++++++++- >> examples/ipsec-secgw/ipsec.c | 31 ++++++++++++++-------------- >> examples/ipsec-secgw/ipsec.h | 4 ++-- >> 3 files changed, 58 insertions(+), 19 deletions(-) >> >> diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec- >> secgw/ipsec-secgw.c >> index c98454a..08d5b5a 100644 >> --- a/examples/ipsec-secgw/ipsec-secgw.c >> +++ b/examples/ipsec-secgw/ipsec-secgw.c >> @@ -1244,7 +1244,7 @@ cryptodevs_init(void) >> struct rte_cryptodev_config dev_conf; >> struct rte_cryptodev_qp_conf qp_conf; >> uint16_t idx, max_nb_qps, qp, i; >> - int16_t cdev_id; >> + int16_t cdev_id, port_id; > These two variables should be uint16_t (port_id is actually uint8_t). If unsigned then line = 0; cdev_id--)> will not work correctly. > > For the rest of the patch: Akhil, could you review it? > > Thanks, > Pablo