From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30070.outbound.protection.outlook.com [40.107.3.70]) by dpdk.org (Postfix) with ESMTP id B46261B466 for ; Tue, 9 Oct 2018 12:51:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MP3qgUtRYkyC6QX921xWqyF3le/asRaa8n9WpIm2Ywk=; b=hst4TOLFvzdISD0cgYb0bWv8K4ZZdmu7uzFp7vfj1uEQBBQQlP+kOT8uaMi4A2Rtayv2OVs0YXpS20tBNMKLG4A+nVLuJpzzPHkuw/mN84nRsqGIKrZwgA2GdI+zJMKbeGUDlbL7A+hRWKT/YRVKfT8D6pStSEHTQZV27DWBVgs= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; Received: from [10.232.134.144] (14.143.30.134) by DB7PR04MB4892.eurprd04.prod.outlook.com (2603:10a6:10:18::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1207.26; Tue, 9 Oct 2018 10:51:02 +0000 To: Junxiao Shi , dev@dpdk.org References: <201810022008.w92K8B2r031185@lectura.cs.arizona.edu> From: Akhil Goyal Message-ID: Date: Tue, 9 Oct 2018 16:20:49 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <201810022008.w92K8B2r031185@lectura.cs.arizona.edu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [14.143.30.134] X-ClientProxiedBy: BM1PR01CA0111.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00::27) To DB7PR04MB4892.eurprd04.prod.outlook.com (2603:10a6:10:18::23) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2f55b12e-ffe8-4923-2b19-08d62dd51b2f X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB7PR04MB4892; X-Microsoft-Exchange-Diagnostics: 1; DB7PR04MB4892; 3:IhdEwe4PBogA/UWigreH1yXbUDxvrewJyOuhJllQ42kyv3bA3BH0tW4/BJIHZNhnMuy+PFYugbAqPJJaiNmt9DrEDUoW5DHzM+2kCATw6ykNqnx593n4Sae+ElBbXILb9tonobIlv4vr3b/jXeNfgxyHtzasm+A/7gYft596+nvdQGM+jGqI0u8dEJ3rnpxhYj3gWRm8AXQBVdd9qpqtQejoqUDlKmk/x7ZKbJnp3wxCxJEhxrEmoZvdUURD6I4M; 25:kyVpF3I2zGWlTb3JHAasKChCI9q5JnZ+kq8s6pcz6CkyRUy7Lm4Op1oXwR/IhtdeTWRrMut6Z5/cWTIercNuV4j0y8nZLVtxS3eLOHq+sH6Rx/k0gxi7oz/6y0liULwMHOF9FskzJqotRpFcTGJL2hqWUL5TwQEeFCI41fPsrSdeCwOeOUKf/3Mjw6MihfF/AfLGvCyUB8lwA4ti0uiB0U8RNcw9Vl/pMsyZg7sqpYgHicOjlilx3xlPCkD7/N+4g1+p7+dyVGSjuwgXDsHOyJuM+skkkHbwxcsijNGya5Zaf5y1ry23FYm2t6pIrLXDtPemDra/R1hPozSlP+ACvQ==; 31:vYY45hhrm4MdCxOCsFx23URoGyyiNlR5f8WQTMzmGwpsvpxHqD4Fi0HM0WdZTMyo+q3DmeLUjK81MlevLGdbGr+A0M6n4Fx6FGYPy2KdJYYRYKzrv2J/3YLAOcSW2KtGefnR8nErD+CSVfpyOLvJpef0E9X9HK0vDMUYCi+2Lr6GVqynbfAfSW55BgM+/cXxtfyrPTiHtSAWqNplDBH/+OYh6kmgN0jKnNOvqJR5qk0= X-MS-TrafficTypeDiagnostic: DB7PR04MB4892: X-Microsoft-Exchange-Diagnostics: 1; DB7PR04MB4892; 20:a1IrNgVGceHR0SierUlT1JOCgPjF8s2eQO0uulVhVSeubfk/ORlHo4cylnwXo8T/diOq0Hy0Q2oKYX40YI4PnMl7V82+PS/W0h1u50ntVEjg/eTwVC7rH/gy/v76V6gdpPCKnig5wTjJqmwlMlqd1nULFA6c8fSloHLMTATRzwVvCtnl2iVb/rLn/Wxl2TiEjADcTXTcsRphc2x9K5EAZEGufgMVERJoNb6OJovlYh1UmA/VtdnbtR9NPi3ADkvmfrKbtQtJg0p6/BFT8aSnefAqtTMc6VVvlbbKVhqM9aJITpiMQo/+N5cAKCrZ6Fu7fznOXYppavVzV7eTHeYHKjvgfit9o8OLT9qOrHCT+785Zf9wuYJqUOz6s2g+ZHyu67fRg65s1EqzsFgntTf9RSoeyIKYJ7IDN3CX50uam6MNT1Ct1cG4MogkjQCspYeKPSusBerMLQsMNDrcb/Yy79ZzS1/TjKuPbdoK1YwlOYLCnFOjf2nO8O/p7N9Lm0Zo; 4:PLOxI6QvXNc1g4rzvVtZIcpgZZwzxH4Dnq+qMJcwAbBjGbj2ZAWA/bSX4OKeIEKvMxyIoXecWSPPvBJEUm71BpKFrrkBPe0Q3wzUcyx6DQ93hnD9NEJaOxHSPfGrVaLsuQVpp1ZIkxOS1v9GGl2IrplYp00Nh/zYLT/k1vJIOLQ/vRIn8xdZdIUUXVt6UopVX9ldf28SZwmz8CmrVLZpYNt1hkz5hSTx72DqSQETN86MzjNV7OTmbaAStKKTks4eiIvGFnmZGz43rBMZyfF/gw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(10201501046)(3231355)(944501410)(52105095)(6055026)(149066)(150057)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(201708071742011)(7699051); SRVR:DB7PR04MB4892; BCL:0; PCL:0; RULEID:; SRVR:DB7PR04MB4892; X-Forefront-PRVS: 08200063E9 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(396003)(376002)(366004)(346002)(39860400002)(136003)(199004)(189003)(76176011)(6116002)(26005)(68736007)(81156014)(316002)(186003)(65956001)(81166006)(44832011)(66066001)(8676002)(3846002)(65806001)(11346002)(50466002)(2906002)(8936002)(956004)(2870700001)(2616005)(31696002)(478600001)(476003)(229853002)(6246003)(446003)(77096007)(53936002)(305945005)(16526019)(58126008)(16576012)(6486002)(7736002)(64126003)(67846002)(105586002)(55236004)(5009440100003)(6666003)(3260700006)(25786009)(23676004)(386003)(2486003)(52146003)(31686004)(5660300001)(52116002)(36756003)(47776003)(86362001)(97736004)(65826007)(106356001)(486006)(53546011)(110426005); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR04MB4892; H:[10.232.134.144]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjdQUjA0TUI0ODkyOzIzOm5tRk9aM0xqYmVMdjQwWHNXS3A5OEFXWkht?= =?utf-8?B?SUpuQ2t5NGxZUFQ1WEMxdU1nRUpNbUUxWWJUNEV4eVdEcmFqbGZLZU1mZTJr?= =?utf-8?B?M0ZydnI3MEdaeHkzVlBJQ0xHNE5taFBlTnZHdVZoTGJUN3hBcVhyeEkwc0Jj?= =?utf-8?B?WElXWSs5UXlpZENOYUJOMUU2OGh6TDJVRTFYeGNDTXc3U2I2NTlLS1V4QjI0?= =?utf-8?B?K0hEUlZXemNHNGpjaDhBVjVVQWNjOCtnd3haakJ5cXd6ZzROZnI3MGxzNFRD?= =?utf-8?B?TlpqaHR3cDhPQ3ZMdmRSWVpaaHQ5Y0NLaVkrUVg3SC85VXFBYTBTN2ZrQVNJ?= =?utf-8?B?QXVBNG04R3QrMTg4eU9jTU1rTEl1ODk0UVZhV2FDNXhwRjY2T3M1alhwcitJ?= =?utf-8?B?WnRiS3NmRmJLMG50bG11YTdHN3JVbmZjb29kRGtOOVlZdFJmN010eUJFc0hM?= =?utf-8?B?TUJmUUU2cEtUK2VER0xEK1d0Z3RROU5JM1J6N2lNY1liS0laT1dZcUdvUmg5?= =?utf-8?B?eXdMdjlvSWN1YWVGYlJKSk9BQm9RWkk5UFhzZUNBSStINnExZ0x5UklDRXBM?= =?utf-8?B?MGZuaEllUUVxWnE5bVYrWitBZEtLZ3poTDFaZGJ4M2tjWWhNS2xhNjlsVzhD?= =?utf-8?B?TkZucFdabElMeFpSVGsxZHVXaGlJZzU2Q1RaM3k3K2FpTFY4L2xic2NPM29J?= =?utf-8?B?Q2tjTi9EN05WOUdCRDFOV2xuQTFlZ1BPbExVU2xzV3dMU090ekExLzVTaHVW?= =?utf-8?B?MnA2SGZ2ZEVyTlVSUmRjcE9pRDFDNXVYL0tGM0ZBcmdwMEtQQzlZUHVOelNx?= =?utf-8?B?TkU4c3JUeGJIQVM2MlBTZnZYMzY3NzZ2TlkyRVFHa20xbzRZVDNOS2NSLzVs?= =?utf-8?B?djQzaGR2dml3VUZEeXQyYTdFbW1SVVpUQ1ZwUW42eGVQUE1aWTJLUHo0M1Iy?= =?utf-8?B?NXl0ZGdnQmdKbG9ZRE55eEtqQ1JCMWZTUlNPOVdRdElQU3Y1eUt5UXJDcXkw?= =?utf-8?B?eXlhTTZPWUVsSDA0ZEZENnMwRzd1UFBZQklLTTU3SlQ2UjdzcUJiNjFRU1pt?= =?utf-8?B?RHRJL2MwZ0pYSWNicWZvQ0pWRy9BWUhsTWt6RTE1WUlUSEV2bk95SHhKL1Jn?= =?utf-8?B?UWEvR3NsVnZBWWhSR2dvV2pKUmNiN2hLYTdoODZ6ckdYdDF6eERGaVoyUnBS?= =?utf-8?B?N2F4UmFVVXppVzJFOTlBeFhJYnBpSHluUk9walo1U0tCNDljaUl5dWM5ODNT?= =?utf-8?B?WHMwUXhGOGhzSjk2a3lHUHpubFRRUExoazNOUkRKQks5SWxIUVdDODJ6aU1t?= =?utf-8?B?WncrU2gxaEtNVzQ4Rk5UeW9ub1NqRkt6T2VRNWtna1IvbzBxMEw0aWVWV3dM?= =?utf-8?B?My8rbXlmYWpUc0dyRXkxc3Z5VmJ3K05xdnQ4VlpNTFg3RE9OdC9ieExaRXZ1?= =?utf-8?B?Y2FvMlpMVEFQWXl2eTdWczlNZmkvQ2czZGwzaVUyRUtEdVN5cm04YkJqbEhl?= =?utf-8?B?UUoxQ2JuMHJXaGVpejdOcVZzd2VzaVkwNUQ1Yi9XRHVVNXA3S2hKNWRKbW5X?= =?utf-8?B?Lzh3U1VTVTJIK2Z1T1dyRnV4bVFJMDNIWW54TVFQOHdlVnUrcDFpWFhMRjI5?= =?utf-8?B?TkN3eVF0N0JaRzgzU0g2VUhkYm1URUw1NWcrcmY4ak1BcG4xUU9LaCtjbkQy?= =?utf-8?B?QVJJZ3AzTkpoNUtlK0swMERXOXZDOC9TaEdwK0hYNlAyOWtyU3EyRnJWZXJs?= =?utf-8?B?VENVN1dDS0VGYVc0WUVSUFBrSFc4TUlWOHFPR3RVaThibHB6YjAwWVZrOFYy?= =?utf-8?B?RGJ3SURNeWhMWVlCMitPYVNWN2dvYnQvVCs3bDdlcHlqRUhtQWx6UEl1aDA2?= =?utf-8?B?ZlFWL2NuUS9XUEZHaVBBRVNVMmNFa3pkNDBuNVBjWHJKeGJKTnNORm5RK3RC?= =?utf-8?B?VEk5QXRpZUFUaXFJOWRpZDcvdmlZU0JRK3BnOCtDL25ZeUN5dVdEbFplUjVF?= =?utf-8?B?OStTMXhtVnAzS2lQeTVweEJtVVZHTkU1V29ORlUzaDB6NnVhTEx2VWhaQlAy?= =?utf-8?Q?5JzI=3D?= X-Microsoft-Antispam-Message-Info: W/Je7KAI9n5VuF98Fb1ofm8IG0YFtrYRfwY7SkKZ4ZcaJp50I+eOE0o7gFdn26vVu+kuBW8AcGJxo8gX+ryrXslCHMBpJoRIoyilBorb3MgUDAcch+gGhgGiQfp9J/AXay4wMFYr5/nzcqVoN226DnD/IjeQVFSJ8ilUIS+ZSatlivkicecxVDfn1eU6W9rQOjMOJZ9fGPFjdFXdDbIOf6jKbryynD9+lMTkN9knADGTxZpk3eFt4XQrTGNUFaHE0NHWOz+FSPg6f91LIg/pmPUh7YBGF1D1vuFYMT33O+xrgdwaVDPC/4xCSZGIXo1GumMgIM58EFOnmPrBIBNAOJ9ZR67YuDqI1FlnPSbnAbA= X-Microsoft-Exchange-Diagnostics: 1; DB7PR04MB4892; 6:Fqo8mCRKYWYEMH6b1LPm0ZUatVq8UTKhM7PeulOawAxmWGqcL9vB+iS4/nheKo6J5KDeJ9WIvbmN2lAj4Luw9iXSsehuPxMqs3W+P9OxqhCdU3fTDsb2ztEIu/3pFn6CzOeJySlHMsVCx4xmBN43vghEInvvgdJcuTkiuOpHpiY/mT++Scr26evlFUz2VirfJ4cEPfpS2ldhw7cDU7AF/4hujyIxv2Idc4ipUBFv5Vu8kylUXhrZPUGseoaUy/G5YZUto/TfUXag1CVsink1Nyv3Xwjt4ywFNR/m3Mu2eJK85seGovIDcyqSatsx6Y4EqBGhpZyjMNme/jWMt1Y7cII7RydkgRjh230CoSLBN2hf33EFkgtuzmCfTSje0sxo0qaS46ZuL1biXICRiDs/otV6W8p7GgxC83tFDPpcqakBMMzX6XWxextqYTDzAbqCXDcijTTxBWrOFR0KhzNJ7g==; 5:yDexUDNSqatSxA+jSNPofvK+t+lD9XPl5FemGz20n3zrrpje5G0eF67hxdv253DFN1IWbipgI/+r3kiYhkYglCRNzMGPoOTYUUAHG+go1JAHrsM40LO1+ZMmjHaLKjze4ZZ8ilE39kR5tdLBWbt7amAd89MdlxfFS/PSB9Fj39s=; 7:u7D8FOFcATRarb6CeGddP3WsnUNt/D1V1PztSSofRA3yvtYI24WDhDIMuGrNyFFT4skEHMxAOaQKdclliIMrpwdxISw1ma6svR5s5OgmXS256xyFRYLdyUbY045Qit0Og8J5xZ8ohuewkCxIcs4y2weSjDa+7D942DjHDGkPL412CR3oTVa+JYeJcphRJGAq7l8Gf3MLSYRXW7R5lCQLW5FXj96/addjsEFYLyWb0Ze54S+yaxxpOnfcJ0CXxLQ8 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Oct 2018 10:51:02.0439 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2f55b12e-ffe8-4923-2b19-08d62dd51b2f X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4892 Subject: Re: [dpdk-dev] [PATCH] crypto: recognize OP_TYPE_UNDEFINED in rte_crypto_op_pool_create X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Oct 2018 10:51:05 -0000 Hi  Junxiao, On 10/3/2018 12:35 AM, Junxiao Shi wrote: > Signed-off-by: Junxiao Shi > --- > lib/librte_cryptodev/rte_cryptodev.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c > index 63ae23f..3d6f474 100644 > --- a/lib/librte_cryptodev/rte_cryptodev.c > +++ b/lib/librte_cryptodev/rte_cryptodev.c > @@ -1477,6 +1477,8 @@ rte_crypto_op_pool_create(const char *name, enum rte_crypto_op_type type, > elt_size += sizeof(struct rte_crypto_sym_op); > } else if (type == RTE_CRYPTO_OP_TYPE_ASYMMETRIC) { > elt_size += sizeof(struct rte_crypto_asym_op); > + } else if (type == RTE_CRYPTO_OP_TYPE_UNDEFINED) { > + elt_size += RTE_MAX(sizeof(struct rte_crypto_sym_op), sizeof(struct rte_crypto_asym_op)); > } else { > CDEV_LOG_ERR("Invalid op_type\n"); > return NULL; Could you please explain the need for this change. If there is some type which is missing, we can add that. defining the size of undefined op type does not make sense. -Akhil