From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0082.outbound.protection.outlook.com [104.47.0.82]) by dpdk.org (Postfix) with ESMTP id D2D441041 for ; Tue, 18 Sep 2018 14:31:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JDx5q9pvtUdKCVVDZE3CVpmhR42TgWIew8N4tpv/iM4=; b=LhI4KIk2V+vcIoHHv7dr9d8uTmVq3EnH70mDn3b7JXZ7sexLo2vEzvt4mNuDFgxNHT9wfWe6xVTv+dfyZTbWEgoFJsX2DgzpqLGURkV8J4dGb04pd7xGkDwhB1/WDXQhfjht2jHug778OpE53byY/iwnbg3F9v6bpa63fVfScnI= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; Received: from [10.232.134.144] (14.143.30.134) by AM6PR04MB4885.eurprd04.prod.outlook.com (2603:10a6:20b:6::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1143.18; Tue, 18 Sep 2018 12:31:33 +0000 To: "Joseph, Anoob" , Anoob Joseph , Pablo de Lara , Thomas Monjalon Cc: Ankur Dwivedi , Jerin Jacob , Narayana Prasad , dev@dpdk.org, Murthy NSSR , Nithin Dabilpuram , Ragothaman Jayaraman , Srisivasubramanian S , Tejasree Kondoj References: <1528476325-15585-1-git-send-email-anoob.joseph@caviumnetworks.com> <1536033560-21541-1-git-send-email-ajoseph@caviumnetworks.com> <1536033560-21541-2-git-send-email-ajoseph@caviumnetworks.com> <8421735d-1357-e444-9924-390f23827f3e@nxp.com> <95e172a1-2f81-3e8f-7fba-8373e64428d8@caviumnetworks.com> <06b2d39f-5d9a-d1e2-f3bb-5238e40e6406@nxp.com> <23e3b8a8-32f9-cd91-bef9-c03eff0d4e46@caviumnetworks.com> From: Akhil Goyal Message-ID: Date: Tue, 18 Sep 2018 18:01:21 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <23e3b8a8-32f9-cd91-bef9-c03eff0d4e46@caviumnetworks.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [14.143.30.134] X-ClientProxiedBy: BM1PR01CA0076.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:1::16) To AM6PR04MB4885.eurprd04.prod.outlook.com (2603:10a6:20b:6::20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 58a807e3-a7f6-4f4c-301a-08d61d62ac9b X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534165)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM6PR04MB4885; X-Microsoft-Exchange-Diagnostics: 1; AM6PR04MB4885; 3:XZNcGgd07XkSTpogpdrTaqmlhOOJvxB5YvKvrTaOM66JHcFiOnKGJmiupUbfV5t28InJIVXNOZHuVkn+jDeUsr+O8kIZHuQMfrfk/fOLApgJXzS4Sfh8U1bt/BCpkwlONgOXxx11CT+Hz9AtAjxLytH0y5a/z+I8tE1Zmeg8NCJfZ9tzg0EQXg9rSfgU7RhXTtAjUrnU3pAZoV9nppmuH+aCgVIehlrn59hQm0fe5h3kvrKQGpIi8ZCZs0++4ysT; 25:lPE+cWUCspeMNxYmkrj0L7ua6bqHl0cnJvmEHJ6x+u89LbWXVBJ9PDXPNf1lKZ72BNzL0deOHVtjKr+DfyuHo4MuLVOW753xZqfyB1epgDd5e9el5xhO3JGC5ZrUZlMI03WOOMuffmqdfh7GXTRBb85DmUDfXu+n1aNVKsmUDbUp+rq9eNZpKZ/M7xvFSdsJ1bgRiAnm3uYQ1qEZpvgRjmTgUcFO3UKdVxptRVJa33ZFHz4Io96VoUGhtcX8vnTmr5DLHLBHndEQtq3JP0ZrqMk0K3E0E6y9oMfr5Go8rq89so98gV+fnDGVpzBimtjkwH6TjxNKr0eBBKegCZV89Q==; 31:Woz9QzjGvfrP+v7hIrd+q0ofOIiyEOP9MatqrPOtv9+Vs3xXVWm8+12i7w3/NAS1hYt7wdDNKzuWzpRUu4puns7VWz7gOIq+HZpr7TfhNPEVTJmQj4ecwoSDYdhaVUW7p677ZNpZ/FnbYLMyjy+jkQb/5u6pnK41CsfXYBwgiCf9PzVORUhLHDUl2dBE8LW9sYUIwtczXAPPlL5TW8zaXCwWwJ9A2jOd4i6+NvZmQ8Y= X-MS-TrafficTypeDiagnostic: AM6PR04MB4885: X-Microsoft-Exchange-Diagnostics: 1; AM6PR04MB4885; 20:5KBdn2GsJF02lZpSWbYxxmM7Qa5kUCn2rqpnFmT2CP5LBwscf0b+tvdhG5ed0N3XkHQmpG2xvFWEbAVkoLlsyU9R3yeLYgoS3fvy1F8iTGTABEmbvL2PZ9NhEB+vnwoX9RBcAEd0ag8j0/+AIUtK6eJmG5i2FLksENt3z1hA6JTWGXvEPTPSa/vKLTjKxCrJj7tjZkqSuFssP24waHtAz+aSoGH6vI4Y/BjkyBwUhXegXL6DJgffPfV7258dj4CYtutgSOHVBunNKsFgy6HDEdbWgpGkgJo3KDFfrNZM5pNR6Uk9Cp5HSkkEHrhTMPZoPYeihm30tyNmup4EOklK1ChXGmOFPTQjbAKPQ1G56YK+qHBMpQPA+3w33Bk1JMi30jCMLwMtQ6JkGHZVm///AfWqnTCv240ZkxRjtZVGJc1eh3J6nq5fTWQwlQmgQt0E0dWG0J5YpYnq7KjaICv8hIPcL3ctcQH4QK5+maszlmRds1JG5Y8ZLI5lLlId1i50; 4:RsTftKG7jpAHu51Y5rzmE9sNHipX7lAX+aG4dUhMCdH8Qb2oNi4/mp1uIaRpjx7Obd2u4EVMkky5ReZg2nXIMTj8kE6Sop4shFysWF7t/r1O945duFpJruTt46UEgzDWIzEHxHXmFpgxUTI9fhKVP4xveM18ssnBL2MR982GeHYVjLBA8fVHmp6ik7FfIonTcFBVQ0bGaGATRjKF63eqqLMDomCDMhSN2f2GHHphB+VSgOrMwhFnhauK8TU3PNZFPp43VxSlQOIV45yFVPAmlA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231355)(944501410)(52105095)(93006095)(93001095)(3002001)(10201501046)(6055026)(149027)(150027)(6041310)(20161123564045)(20161123558120)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699050); SRVR:AM6PR04MB4885; BCL:0; PCL:0; RULEID:; SRVR:AM6PR04MB4885; X-Forefront-PRVS: 0799B1B2D7 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(396003)(136003)(39860400002)(366004)(346002)(376002)(51444003)(199004)(189003)(14444005)(36756003)(4326008)(6666003)(3260700006)(65826007)(5660300001)(25786009)(478600001)(64126003)(97736004)(50466002)(68736007)(47776003)(6116002)(3846002)(93886005)(5009440100003)(186003)(65806001)(65956001)(26005)(66066001)(16526019)(77096007)(106356001)(2906002)(305945005)(7416002)(67846002)(105586002)(54906003)(110136005)(58126008)(76176011)(6246003)(52116002)(386003)(446003)(53936002)(476003)(16576012)(31686004)(2616005)(956004)(44832011)(486006)(316002)(6486002)(8676002)(86362001)(229853002)(52146003)(8936002)(31696002)(81156014)(81166006)(2870700001)(7736002)(23676004)(2486003)(53546011)(11346002)(110426005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR04MB4885; H:[10.232.134.144]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTTZQUjA0TUI0ODg1OzIzOmpVTG5peVZqN1RQckRwWFdQYVpMT0xpc01y?= =?utf-8?B?UnVNQ29Jb2JkRnpFdVpLVlpFaXFQbG9iQzNWdVRTOVRxSUR4OGVaaVlnTCs0?= =?utf-8?B?bGRudjQ4ZG5HYXN6Q2diTlluVnR4OXhKTnhBdXhteHVNZmZjbkQxMGhLODh2?= =?utf-8?B?YlFqYVd4TzFZQS92NE1tVXNEemhYZ3Y2d1B0N2NQK1lRNEJQelc4dWdqNmhG?= =?utf-8?B?bUgxRGdzS0d4aVA5dmNqS0tiL2U5bUdtZm1McU1xUGN5eXYxc0pldlNKOHpn?= =?utf-8?B?aDRIMy83YUVVOXZaZnNBd1VkazViK1VsQUc5VXMxNWVUM05TRjZKQ3BkREdi?= =?utf-8?B?bDFETFFFWkJGcUlVazFLb0src1dQZE1pMGJ3ZzM5bzBDWGY5RzlaOGIvNEJP?= =?utf-8?B?MmJLTi9jQnBNenV0Yi9EbXgwNDYxdFF5QjdJNldCNXlGN21teGFTNktuRGVh?= =?utf-8?B?ZTJyUTJJeCtEMXJMY2dZc0JMdENkb3BEcitvaFgra0Jxb01VTWxIL0tBa2d3?= =?utf-8?B?TUpBeFVrcTEra212ZDkxN2M5aWhLSExJM0tRZlZKRUMzWXVsbWpISkNQUFo0?= =?utf-8?B?TkNlTHBZdnZEQXBMQnZTTURkTitrWVBDYnhRbHN4c2xsWURkUGRlTkVySmJQ?= =?utf-8?B?UWFVcG5YTk1pek80R0NxeFFVdWZKSXNuTGE0T0hxYnFFVGhvQUVsZldYUWZQ?= =?utf-8?B?UmhrU09tRjFmUWdUSW52NngvQ3AvcytIckhjM2lxREppSDh0eVMzZCt1RkZ0?= =?utf-8?B?amxwUHk3RVhSci9GQjNtVHJVNlRrSHB6OVh2aStUYnlWMkNEakJnK1dmL05Q?= =?utf-8?B?Z3k4Q1B4dkNIY3RsbG90dGJVYm93OER3UjQ3Wlg4TmdLbHlXRzJTNGROWFEw?= =?utf-8?B?WWx2cDJQN29KaXVpYkdwMVhsZUt5MXJMQWdFZ1JIaUd3NXBidlFVYW00TGE1?= =?utf-8?B?WHFBL0o5WU5hTjAvY2JxTklWK29LNXJVVTZLa1ZnYzgzZkhNOGxRQnFkUXR2?= =?utf-8?B?eU4waTFrODlWQ1ZrY3pIcUlUdDJteENkbWdpcVV1N1B1VkJQOXlxekdndzAy?= =?utf-8?B?MjJWcnFLNkNiY01tN1NEWnN2aG53cmZ2djNTMlk0NWYwV2RBZHhPbm8vaURv?= =?utf-8?B?TW1kS2lLN2N1L2JQZUplNEhXUnhSeUN0UThkMjZKYTh4eVd0ZU1NMVM4UVky?= =?utf-8?B?amtnb1F6RnNENTFRaHY3SGhoVUJMNGNOSmtaNHpuR3ZXZUJWZEpZRUpWd1Ft?= =?utf-8?B?VS85cWNlYXphRE1iQkZ4K2R6M042Q1Q2T0hXR1BSUHkrTWhrN0VZZmcwMnpH?= =?utf-8?B?RUF3SkRIYXUyS0pRUnVjaUd4QVZITDVMSE1ubDZYMVdnM1lVeSttOTRnWUt3?= =?utf-8?B?eTdHRnZjbCtQZTFxRFZxdnBGZnpmZTVSbWF2Z2RJaXJhZUc3VEYzdGRFR084?= =?utf-8?B?T1ZQVm5GY1E5dlJmVFJ5T2p3NDA2SGoxeFRGUTYxME56TWMyQlgweldxRitE?= =?utf-8?B?L21tR1g1SmYxSkczVmtPUzBGQnZZUzVQTlFuOEtCQ2pEVlFKZ01aOUdBSERJ?= =?utf-8?B?TmFSTFhZaHNJVko4cDVRRC9MdSs5ZTRja1A3bVcxUE9lelArTWJLUXp6THlP?= =?utf-8?B?MmUrYkRaM2xUYk9tSXlPaGtKUFVBRWU4VDNUYzlmTVEyd0ZLZVZ4azMxVjIw?= =?utf-8?B?a1NZcVdwNmx1Z1ozLzJXajZRWlB5MUNPeG5jRVBUU1hIeUxpUmRyTFhwMG1F?= =?utf-8?B?c1lCcUJpeHFwUmVoQzI2bTQrUUNRNklTL3A1aktZOWJsOG5BQ3RCUkV6QzNG?= =?utf-8?B?VzJpWDg0VElGaDZ4cmpMNUJTeEJsMWpKV2Z4bzFReHNybFFvOUdpNDhVcnhU?= =?utf-8?B?RG50WFVNcnRDWW5MelJ4R1JsT21VK0NqUnVDSFpqOEJ0UTQrN1hDTGw1dzUz?= =?utf-8?B?bnluc2VNcGJFc1JVTktFUmhlcWZyejUza09mR3ZERzVHbjVPZUJXdmJncFZk?= =?utf-8?B?aHRFSFYrQzU0VjJ2bG52S3gwVUtDUzdqOVJxb2E5eWJETkNYSDBBc2lZL09I?= =?utf-8?B?NVIrZk1SWUtmcHcySURraTlJdlA5RU9TT3h3bkdrdkpna1g3QTduM1V0SVpo?= =?utf-8?B?Rm55S0t0WUt3dHdjcnVXNk81d3NFd0toZUtYaDRQbkJxS2d1MFgzS2NHWGtw?= =?utf-8?Q?GmY9wJMLv6qY8OQweETmkV9ofIrCk2DUQ+Zj4MT9Ls=3D?= X-Microsoft-Antispam-Message-Info: 2tkhkHwOMAJ8BgOgwON7lpMoNZy5nPPA0o3/m8UHW3inOL1nP/WmJl6tWCBprF1MDHLc9DBsqTQgZ7/jHmpkkbAEKK5e9m6occtr7NE+RoQHTg1jElmXJgmXsrCtWrfPQoxwrACJrOvKv0MhrNsrtUaM1ue9aCN4ByAf2ts9DmtZA4uoHStwDUIB0IFvSAh62wBFFa3YGdtEG+abVuflpO5RjEAffrdyReVCPJF/MdSLT4dln4195u3qpk06Sq+KdkLPisEPtTUkb9WLoI/bvfn41/drOHs89RLDS2+2yBGuoML1xj3h1zYRuSyyRfMQSBsq5eJFMUCHlni+bXg626eiYEqzhI9WEF+sAIAzu90= X-Microsoft-Exchange-Diagnostics: 1; AM6PR04MB4885; 6:1bwjxjQ0pKiGjD0ZQUao4Ru9NA1YCSTrwme2k61lnTePoZQYTrYrOL7AluoEP08J4EmZJGYJ9ItJgBaPgBH5AlE7yp67rbs8oddkc+RwOzQYZ1AFVMFRho63iz0wG3kCLCkEfQ4dmPcPkl92OBdm4MH0f3az6ZQHINSbLMVmqMzAvqH6UrdhzqruqhfA0oE94IXNQv4c+x1gy2TJ/LkklQwAhBe/wAzxqPqBAe8/MC1TSvsSC9nyfpB7rcFv+2DJXcoQ0+x9z8R2q9UsBb/4URBRKWYnDiCJPOR/2/TjaLGrIOyS+1CeYyL3IdKXNNLcylX85zPw2Xi0PUXrZBzEwwKEAeSg/Oc/h0GsW9AQ5LoWejle1zvpWJFExvUY1H4ysj6b86FEsOoN9tTv8T1E7T45ryBF8xqYNzRPk4xA5UXInUaztndmd356KOpiA127XVWt1cenX1GpAD+vtMWABA==; 5:8QeEV9Eql/S2dAi+vnoKJamJ1eEeAZFzvbrDcZV/yhvXcQc4LtXqp36HkBqSfxyZkWqZW+ACD9oSdMjjGJhJdXyBLmn79H4fP7u6UisbF+MtsHkblXu2SXLMh0MjSlGRuXbxHA5sBgbna40pqgFLJHi7VBL6hPgZeapeznLIn5M=; 7:Nr7o5eTrFlaYhenHNVlyaWNV8BrSYkRZZDuLT7cjHiPKaFpQzhLWl3DuzuUq3iWklJ2tp4t1kkokaCtwfzi9tP0EycqYnQPradP0gfaqtrxLhuctJdhRpKxnmw/jv9NtqNVtmgVbOrx89Q8uhw6Dz2P20/kRJIRVte8ZXOj+JhbtxnoGHpEAEZr9XiC28jciG1TXGLC1YB1ylsnPrjFNPnT+3KCiHFXhOEAz8+D6qdn8dDx1RtboR/7/5XWc8VGS SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2018 12:31:33.6089 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 58a807e3-a7f6-4f4c-301a-08d61d62ac9b X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4885 Subject: Re: [dpdk-dev] [PATCH v2 01/33] config: add Cavium OcteonTX crypto PMD skeleton X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Sep 2018 12:31:38 -0000 Hi Anoob, On 9/17/2018 7:43 PM, Joseph, Anoob wrote: > Hi Akhil, > > > On 17-09-2018 17:50, Akhil Goyal wrote: >> External Email >> >> On 9/17/2018 5:12 PM, Joseph, Anoob wrote: >> >>> Hi Akhil, >>> On 17-09-2018 16:07, Akhil Goyal wrote: >>>> External Email >>>>>> I think it would be better to squash the makefile related changes in >>>>>> the 3/33 patch as the code >>>>>> is actually added in that and here the code is not getting compiled >>>>>> here. >>>>> So the changes in the following files has to be moved to patch 3/33? >>>>>    drivers/crypto/Makefile >>>>>    drivers/crypto/meson.build >>>>>    drivers/crypto/octeontx/Makefile >>>>>    drivers/crypto/octeontx/meson.build >>>>>    mk/rte.app.mk >>>>> I think this patch will just have MAINTAINER edit (even that might be >>>>> required to be moved to 3/33?) & changes to config/common_base, after >>>>> that. Is that fine? >>>> In my opinion, you do not need this patch as separate one. >>>> config/common_base can also be added in the 3/33. >>> In that case 02/33 patch would become the first patch right? The same >>> problem would be there too, I guess. The macros added in that patch >>> gets >>> used only in 03/33 patch. Is that fine? >> >> I think that would be fine. Better to have a 03/33 patch before 02/33 >> if it doesn't have dependencies. > 03/33 patch is dependent on 02/33 patch. Shall I proceed with merging > 01/33 to 03/33 and make 02/33 the first patch? >> >>> The first patch would be a shell patch for most PMD additions. That's >>> the reason we started this way. If you want it changed, will do so. >>> Please do let me know what will be the right approach. >> >> For the makefiles, you would be compiling the empty files which does >> not have any code. That does not make any sense to me. > With 01/33 there won't be any files compiled. We are just adding the > library (which would be empty) >> >> Normally, when we submit a new PMD, we add the basic PMD probe/remove >> in the first patch and add it into build system. Maintainers is also >> updated for the new PMD. >> >> Further ops are added later in the patchset. >> >> Hardware specific header files/ functions are added before they are >> used in the driver in a single/multiple logical patches. >> >> In the end, documentation is added along with release note and >> MAINTAINERS update for documentation files. > I shall proceed with merging 01/33 to 03/33, if you can confirm making > 02/33 the first patch is fine. Or please do let me know if you have > any other suggestions. > I see that the 2/33 is adding the logging macros. I believe that can also be merged in the 03/33. Also I missed one comment on the documentation patch.. Please add your pmd doc entry in index.rst as well. > Anoob >