From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD6FDA04B5; Mon, 11 Jan 2021 11:21:31 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 413D1140CBA; Mon, 11 Jan 2021 11:21:31 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 82CCA140CB5 for ; Mon, 11 Jan 2021 11:21:29 +0100 (CET) IronPort-SDR: ixQ0+TAv+NaTg4jy8JRo/wlLBdB7HeGj+rrty1GESi7k+QvRkjupXDpBw0otrErscySKc/5Y7P O3tMtIGBjkkQ== X-IronPort-AV: E=McAfee;i="6000,8403,9860"; a="157616185" X-IronPort-AV: E=Sophos;i="5.79,338,1602572400"; d="scan'208";a="157616185" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2021 02:21:25 -0800 IronPort-SDR: 3Ndxmm47YqxDsFof1xMDVLyoLe4xtjGDyDzX/au6abJJ8cxqojssgaLZ9P/GkicJ/YuwdLop2u 9+DDx4MXq/Vw== X-IronPort-AV: E=Sophos;i="5.79,338,1602572400"; d="scan'208";a="363098054" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.213.221.56]) ([10.213.221.56]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2021 02:21:21 -0800 To: David Marchand Cc: dev , Thomas Monjalon , "Ananyev, Konstantin" , Gage Eads , Timothy McDaniel , David Hunt , Bruce Richardson , chris.macnamara@intel.com, Ray Kinsella , "Yigit, Ferruh" References: <1604315406-27669-1-git-send-email-liang.j.ma@intel.com> From: "Burakov, Anatoly" Message-ID: Date: Mon, 11 Jan 2021 10:21:09 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v12 00/11] Add PMD power management X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11-Jan-21 8:52 AM, David Marchand wrote: > On Mon, Jan 11, 2021 at 9:44 AM David Marchand > wrote: >> >> On Fri, Jan 8, 2021 at 5:42 PM Burakov, Anatoly >> wrote: >>> Why does aarch64 build fail there? The functions in question are in the >>> version map file, but the build complains that they aren't. >> >> From what I can see, this series puts rte_power_* symbols in a .h. >> So it will be seen as symbols exported by any library including such a header. >> >> The check then complains about this as it sees exported symbols >> unknown of the library version.map. > > Quick fix: > > diff --git a/lib/librte_eal/arm/include/rte_power_intrinsics.h > b/lib/librte_eal/arm/include/rte_power_intrinsics.h > index 39e49cc45b..9e498e9ebf 100644 > --- a/lib/librte_eal/arm/include/rte_power_intrinsics.h > +++ b/lib/librte_eal/arm/include/rte_power_intrinsics.h > @@ -13,35 +13,6 @@ extern "C" { > > #include "generic/rte_power_intrinsics.h" > > -/** > - * This function is not supported on ARM. > - */ > -void > -rte_power_monitor(const struct rte_power_monitor_cond *pmc, > - const uint64_t tsc_timestamp) > -{ > - RTE_SET_USED(pmc); > - RTE_SET_USED(tsc_timestamp); > -} > - > -/** > - * This function is not supported on ARM. > - */ > -void > -rte_power_pause(const uint64_t tsc_timestamp) > -{ > - RTE_SET_USED(tsc_timestamp); > -} > - > -/** > - * This function is not supported on ARM. > - */ > -void > -rte_power_monitor_wakeup(const unsigned int lcore_id) > -{ > - RTE_SET_USED(lcore_id); > -} > - > #ifdef __cplusplus > } > #endif > diff --git a/lib/librte_eal/arm/meson.build b/lib/librte_eal/arm/meson.build > index d62875ebae..6ec53ea03a 100644 > --- a/lib/librte_eal/arm/meson.build > +++ b/lib/librte_eal/arm/meson.build > @@ -7,4 +7,5 @@ sources += files( > 'rte_cpuflags.c', > 'rte_cycles.c', > 'rte_hypervisor.c', > + 'rte_power_intrinsics.c', > ) > diff --git a/lib/librte_eal/arm/rte_power_intrinsics.c > b/lib/librte_eal/arm/rte_power_intrinsics.c > new file mode 100644 > index 0000000000..998f9898ad > --- /dev/null > +++ b/lib/librte_eal/arm/rte_power_intrinsics.c > @@ -0,0 +1,31 @@ > +#include > +#include > + > +/** > + * This function is not supported on ARM. > + */ > +void > +rte_power_monitor(const struct rte_power_monitor_cond *pmc, > + const uint64_t tsc_timestamp) > +{ > + RTE_SET_USED(pmc); > + RTE_SET_USED(tsc_timestamp); > +} > + > +/** > + * This function is not supported on ARM. > + */ > +void > +rte_power_pause(const uint64_t tsc_timestamp) > +{ > + RTE_SET_USED(tsc_timestamp); > +} > + > +/** > + * This function is not supported on ARM. > + */ > +void > +rte_power_monitor_wakeup(const unsigned int lcore_id) > +{ > + RTE_SET_USED(lcore_id); > +} > > > HTH. > > OK, will add into v14 so. Thanks! -- Thanks, Anatoly