From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3B5F1A0547; Tue, 19 Oct 2021 14:40:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 235434115B; Tue, 19 Oct 2021 14:40:57 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id D6C0C410FA for ; Tue, 19 Oct 2021 14:40:54 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10141"; a="314697298" X-IronPort-AV: E=Sophos;i="5.87,384,1631602800"; d="scan'208";a="314697298" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2021 05:40:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,384,1631602800"; d="scan'208";a="494077812" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga008.jf.intel.com with ESMTP; 19 Oct 2021 05:40:53 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 19 Oct 2021 05:40:53 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 19 Oct 2021 05:40:52 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 19 Oct 2021 05:40:52 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.107) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 19 Oct 2021 05:40:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wq2jbqP8ysygKRj5CuPt/ZG413kIwPf060DeP7xpgtKjbC5F4S5mUiHzV+9KhhXxvEwatxdT0Z3SP/PXnZDo9fQ5Y6hbq0JhbiggdYDG8TOLWPqIvXWIe9vgyCf1Q/JAp9HcM7k31vOo9C9l6Jyjj/qCdg7tiaOG59IhsP0ncM+B188YuK3JmmEF4wcbnqjIML0cr53M9729mjggscRXR+DMb4TttLI3C0Q98JVCCdl/mQi/zS0i68sEbhu75HTbXE5BEnrkYAGKBjXxtLsXsiwOe/KuP20in1j8oGwZJ0nevPd0AQmEBntVR3PCd7xLQK85LG58sigeSv9fb6Jwpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=epTS6qjL3dFZ1PFhRYZqixOcoLxRldKkzwKkicifUyI=; b=lHK7y83UlBSIM1lngiaX+0LwU9TWn6V2U3v1h2PWXD0L/DkD/YZLY6OvvK5HuwkscCtHMJTjRgPkFlV9XJ61sOkE74zj6d6ZqafTol8AGnljfdqQQhrqn4ociq18I3ZNSvpqhrmL937Y8virYg267LHjMNltglDDpGU8WMl43xb65BKLjCXz9HeTvmhcCwNiu0g4fScdY97/bY63Nmhw6mxou/KwZDETcfPODjujXPIPy8hVH8bdiKc+x1Xv36WlrQWVg45uWiOxFJziOO4sA+5D9J32x7CBCo6sqJFRuw6m5zpu75r3+Q2iG3SGv6lwiFBapo7ohzhlb1kuvd2DBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=epTS6qjL3dFZ1PFhRYZqixOcoLxRldKkzwKkicifUyI=; b=fhBye85beumYLv4ku6YXJWurPkul0nJ9YSKNKuwql4+mBkIWZBJ02eVhh6qqLKt5/wv5qPN9mXP8NiTiWWcB3hA5NyPQd7DXfr3EYcICCGSMDLoKtfx5htFucUTGTfaLe6OphWWyLcZAw/hkDIpy+MGE9mRAmn/0PAGsk1aiHpQ= Authentication-Results: semihalf.com; dkim=none (message not signed) header.d=none;semihalf.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5015.namprd11.prod.outlook.com (2603:10b6:510:39::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.18; Tue, 19 Oct 2021 12:40:51 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4608.018; Tue, 19 Oct 2021 12:40:51 +0000 Message-ID: Date: Tue, 19 Oct 2021 13:40:45 +0100 Content-Language: en-US To: Michal Krawczyk CC: , , , , , Thomas Monjalon , David Marchand , "Stephen Hemminger" References: <20211015162701.16324-1-mk@semihalf.com> <20211019105629.11731-1-mk@semihalf.com> <20211019105629.11731-7-mk@semihalf.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211019105629.11731-7-mk@semihalf.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DBBPR09CA0021.eurprd09.prod.outlook.com (2603:10a6:10:c0::33) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DBBPR09CA0021.eurprd09.prod.outlook.com (2603:10a6:10:c0::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend Transport; Tue, 19 Oct 2021 12:40:49 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ea36e49b-6fe9-4377-2bbc-08d992fdaf27 X-MS-TrafficTypeDiagnostic: PH0PR11MB5015: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4941; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AxxWQbDmfyS1eX3pYqdsByP/+nCVxMpkV71lpjkGDq04zKG/hDJ8hSW/SZwnEsu709LbSJNGq6+9gKlZZuDpI5DgW7GGHjoCborNNar/dsH8R2DWZglHyNxU1YiGacPwDYIqN7lQy/NSwCZ3G4f7/17/3zHrAxz3nYcswSMk3iZfp9aNWTuhRXaXzahkqRlHi6tvhIqS0cJ8Q6xqqbnxFqR0ALe3DBO43FRFgmU/Uh/is1CXsvnlT2Xv96hKGM8zlA9LPN8FTbSKU64U+S258UHxqK2xour/GwNdjhB7naBLGVwDx4DT1geD5ez4gcmnwc3SP5AsUZkFf+wnYCFYt5fQz7J8PG1rk4kqA2GA9vvbGDikSeYXh9Zfmr/HS0z0aH7b8ajT4WZfBhAx4ckjjcHmnROs65hMm301D+ywVPts/PNqY7qvAfb6dA2vc8SmsGRlKynF/SwGcsOZs1uIcOqgsodnfjHYQcVZBb1pnl78z2ahrDWDc3ksh06lXlSAavFJVMXYDBzH4OJAR0klMckxlh2U/7V0BoefVDvzTNdsNcWgR5GSwX/S7LWNFSUXwWwT6fkG1yxQRG94Yv+SB5hCWJTVsRd0JjDDhEkzrghWMw3CeREVlrFyquhAay6sdti5PjFXUuRT53X0lQY4vuAUxwnqHH59KEo8FKUhgAbUXt4Vs8dVXlSswgPQOyGgkycqP4emLNoI5z05COiKcA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(54906003)(44832011)(66946007)(66476007)(66556008)(2616005)(956004)(31696002)(6916009)(86362001)(2906002)(31686004)(5660300002)(316002)(6486002)(4326008)(16576012)(38100700002)(83380400001)(6666004)(186003)(26005)(82960400001)(53546011)(508600001)(8676002)(8936002)(36756003)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bFVIVElyWEZKeGhaM3BkeFdHQmRQWVBXZFZ4eGp1V3lNbXV6RmhmblE1SytZ?= =?utf-8?B?N2xWRzdERzRMRCtnRThKN1JVTmNxTVVNQ2NtcjVYZTFvWWh1WFhiRnI0c0Mw?= =?utf-8?B?VndSVTgwcyt6aGhoREVtajdpVnVzdFliZUZ3a1RCZnljdVc3VHJsSExxK0Jt?= =?utf-8?B?T3hmT245WTd4ZlVrK0plMEIwTXkwM0pJZ3V2b2R3eG8vOGx3VlZ6RnFybEdj?= =?utf-8?B?cm52ajN3OGlZZTZ5ajRCUkhOZnc1dEdtcWFYd0pyZ0FaNEFVY3hGWkJiYm9t?= =?utf-8?B?aHZEWVVEYktZc2JsdnBKRU56TEt5cm1kRW5JalNYUHVzbGFiejE3MmJwdS83?= =?utf-8?B?c0RQV1VWN1h4WjlkRk9zdDlONE0xeldUNUl6YWlrbFVRUS9xSEJtNFVNMzlW?= =?utf-8?B?MnJPNXpyazlMbndnUlBHMURmRStPbm5OanFmRGliNHlLeGovMldLd2J0bk9a?= =?utf-8?B?YnF6YXM5MTh5WHc0Z1laZEc0Q0FWWlNrNnNOQUdUMjE4ODFDUUpkMXJydlZv?= =?utf-8?B?SGJyVUN0dG1rTW9xcmpKY1o0MjZlWVJMWGJYUmYwbmZPcWlqUktNZTBhREJz?= =?utf-8?B?MVg4aDhjRFBrSlpOVHRsK1U5Wk1wNTJDeUo0MkZSMS9weDRDMS9QUTFlSzRC?= =?utf-8?B?cVFuTWZGM1VoVmJMV3JLSWNZTTlhdGllbWdJUXJ4allGOHhYUXRoUkhZdkVY?= =?utf-8?B?MUgrdkhjVExrSi8zWVpvRFVYYVNXQy9aZndwNThOc3FRL1JncWRlVGdISFJL?= =?utf-8?B?aXA3WE52OGJHNWpDOXBVNEFQcTBQYVkzR25zcjVacUhBVEVzVGdURmNIR3pO?= =?utf-8?B?ZnhQUnYxaFlyL2dFVjY4TE1oYnl2WllxaWZNM3FPMjJDNFhVekdXL2xRV1o4?= =?utf-8?B?cGdlOWkvTmFqNGlVN1kvMitVVnNsMERrbmlqUVJKbHRsS0pJVDRVVHVPTlNX?= =?utf-8?B?bTlNVThzSkZQR2ZwTWU3eXNXUDhyNjhjdHJHb0x5MytpVTE3eDVwVWtWZjA3?= =?utf-8?B?YXlST2N6YVhGTk5qQnE4cWxNd3doQi9PZk5scVNMNmJ5NHQrdEdtS08yaVJU?= =?utf-8?B?OUFBa2wwRjZjcElvVmxJMmwwZFdVcUl4ajdUa2xrZWUyZVNKZ1Y2QVlIU3li?= =?utf-8?B?VHE0aTVEdlkweGNlOEpLVHB5ZUljdjZCYjBZNFBwMGZDT05RK1ptRXhlZHRM?= =?utf-8?B?blNkWkptMVhLWkg4RHJKaTg4SEtQZk11aUtNcm1ObXhtbG4zYzh5SURQZ1N3?= =?utf-8?B?TnBFMFFrZmhFTFU2a2M2bFJkM0lYR0RpZ1d4dy80MHJJRG9mUnVua3JRcW5o?= =?utf-8?B?eGVJblByWStiVWJYTVN5S1JtT1RKU2RyanR2TFkvTEFVSjlrZHZGNHp3TGxG?= =?utf-8?B?QVdOeE16WFVJejl4N21BRWszSXFNRmJOUjBXV1JNR2RHZ2RmWklDTmhnU1hm?= =?utf-8?B?VVJQeHQ5dzUwL3o1UjJUL2ZvT2RJUHpmU3h1VEJtWWlFOWkrb3pKNFdjYStp?= =?utf-8?B?RUpZSUJNZ2VHMnk3eTEzZkFOUk9qWFEwMnVmcGhtU3dGWkFBRUVWVmxQRkFn?= =?utf-8?B?dTM0RjI0bWR4RXRUbGtRKyt4UEZENm9YK25XOThVdERHMlBxMU1BZ1Rkbjg1?= =?utf-8?B?TUdqNlRjZjJURGNCWHFtaVJ6RmpLSHNOR3lzTWM2YjFCMHBqR0lIYllPL1E4?= =?utf-8?B?VEUxRTd0SEVpRGY5U1JEN1d4a1l2bUJxS1o1T1k2aWZBdUVlVEhFTmZZWFI2?= =?utf-8?Q?AunMW+UaJOyTXTfcnsOuY1Xa3ExiMY6yXaf7gOj?= X-MS-Exchange-CrossTenant-Network-Message-Id: ea36e49b-6fe9-4377-2bbc-08d992fdaf27 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 12:40:51.5066 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qhhuZpjCedfKIzAaj/423vORh5oM3rVLboULotmz3BGuQjWKaKsef4sKw6ZIjhDgqxRa2SgahQ0fRY7GMJpKiA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5015 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 6/7] net/ena: add check for missing Tx completions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/19/2021 11:56 AM, Michal Krawczyk wrote: > +static int check_for_tx_completion_in_queue(struct ena_adapter *adapter, > + struct ena_ring *tx_ring) > +{ > + struct ena_tx_buffer *tx_buf; > + uint64_t timestamp; > + uint64_t completion_delay; > + uint32_t missed_tx = 0; > + unsigned int i; > + int rc = 0; > + > + for (i = 0; i < tx_ring->ring_size; ++i) { > + tx_buf = &tx_ring->tx_buffer_info[i]; > + timestamp = tx_buf->timestamp; > + > + if (timestamp == 0) > + continue; > + > + completion_delay = rte_get_timer_cycles() - timestamp; > + if (completion_delay > adapter->missing_tx_completion_to) { > + if (unlikely(!tx_buf->print_once)) { > + PMD_TX_LOG(WARNING, > + "Found a Tx that wasn't completed on time, qid %d, index %d. Missing Tx outstanding for %" PRIu64 " msecs.\n", This line is too long, normally we allow long line for logs, but the intention there is to enable user to search a log message in the code; when line is broken search fails. But when there is a format specifier in the log, it already break the search and there is no point to keep the string in single line, which reduces code readability. I will break the line while merging.