From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
dev@dpdk.org, Harry van Haaren <harry.van.haaren@intel.com>,
Ciara Power <ciara.power@intel.com>,
Kevin Laatz <kevin.laatz@intel.com>
Cc: arybchenko@solarflare.com
Subject: Re: [dpdk-dev] [PATCH] ethdev: fix xstat name of basic stats per queue
Date: Thu, 8 Oct 2020 16:41:53 +0100 [thread overview]
Message-ID: <cfa9e124-1120-9600-5816-32953c991d23@intel.com> (raw)
In-Reply-To: <20201007214848.249516-1-thomas@monjalon.net>
On 10/7/2020 10:48 PM, Thomas Monjalon wrote:
> As described in doc/guides/prog_guide/poll_mode_drv.rst,
> the naming scheme for the xstats is parts separated with underscore:
> * direction
> * detail 1
> * detail 2
> * detail n
> * unit
> where detail 1 can be "q" followed with a queue number.
> It means the name of the stats per queue should be rx_qN_* or tx_qN_*.
>
> The second underscore was missing so far.
> Fixing the basic xstat names may be considered an API change,
> that's why it should not be backported.
>
> While fixing this mistake, some examples of the naming scheme
> are given as part of the API documentation of rte_eth_xstat_name.
> More proposals about standardizing statistics:
> http://fast.dpdk.org/events/slides/DPDK-2019-09-Ethernet_Statistics.pdf
>
> Fixes: bd6aa172cf35 ("ethdev: fetch extended statistics with integer ids")
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
no objection,
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> doc/guides/rel_notes/release_20_11.rst | 8 +++++++-
> lib/librte_ethdev/rte_ethdev.c | 4 ++--
> lib/librte_ethdev/rte_ethdev.h | 7 +++++++
> 3 files changed, 16 insertions(+), 3 deletions(-)
>
> diff --git a/doc/guides/rel_notes/release_20_11.rst b/doc/guides/rel_notes/release_20_11.rst
> index cdf20404c9..d0d77c5d3d 100644
> --- a/doc/guides/rel_notes/release_20_11.rst
> +++ b/doc/guides/rel_notes/release_20_11.rst
> @@ -200,7 +200,13 @@ API Changes
>
> * ethdev: ``rte_eth_rx_descriptor_done()`` API has been deprecated.
>
> -* Renamed internal ethdev APIs:
> +* ethdev: Renamed basic statistics per queue. An underscore is inserted
> + between the queue number and the rest of the xstat name:
> +
> + * ``rx_qN*`` -> ``rx_qN_*``
> + * ``tx_qN*`` -> ``tx_qN_*``
> +
As far as I remember collect plugin was using xstat output, does this rename
affects it? Or any other telemetry application relying on xstats.
Harry, Ciara, Kevin, do you know anything that will be affected from rename?
next prev parent reply other threads:[~2020-10-08 15:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 21:48 Thomas Monjalon
2020-10-08 9:09 ` Bruce Richardson
2020-10-08 9:10 ` Kevin Traynor
2020-10-08 10:29 ` Asaf Penso
2020-10-09 21:00 ` Ferruh Yigit
2020-10-09 21:01 ` Ferruh Yigit
2020-10-08 15:41 ` Ferruh Yigit [this message]
2020-10-09 8:32 ` Power, Ciara
2020-10-09 8:36 ` Pattan, Reshma
2020-10-09 9:02 ` David Marchand
2020-10-09 9:08 ` Pattan, Reshma
2020-10-09 16:53 ` Kevin Laatz
2020-10-09 19:15 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfa9e124-1120-9600-5816-32953c991d23@intel.com \
--to=ferruh.yigit@intel.com \
--cc=arybchenko@solarflare.com \
--cc=ciara.power@intel.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=kevin.laatz@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).