From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C5B51A09E4;
	Thu, 28 Jan 2021 17:56:23 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id ABD3F40682;
	Thu, 28 Jan 2021 17:56:23 +0100 (CET)
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by mails.dpdk.org (Postfix) with ESMTP id C8A684067A
 for <dev@dpdk.org>; Thu, 28 Jan 2021 17:56:21 +0100 (CET)
IronPort-SDR: IkeY/ABGzlfR5kEsc4VCG9EDS6+m9oZtoC0drQuEU5Dnk5Ikk9991GoLWzHJZX+0uhf5yjfZzl
 fuwC/oa1/T/w==
X-IronPort-AV: E=McAfee;i="6000,8403,9878"; a="180346560"
X-IronPort-AV: E=Sophos;i="5.79,383,1602572400"; d="scan'208";a="180346560"
Received: from orsmga008.jf.intel.com ([10.7.209.65])
 by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 28 Jan 2021 08:56:19 -0800
IronPort-SDR: HfK71SRZBh6iGy1APAaFOsDMW9ZG0k+JCOG0bZvwbVDH20lqRo5D5AmIc1VoVgUBrnwUVXv3Kn
 9JQj/raKNcog==
X-IronPort-AV: E=Sophos;i="5.79,383,1602572400"; d="scan'208";a="388896719"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.197.127])
 ([10.213.197.127])
 by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 28 Jan 2021 08:56:17 -0800
To: Nalla Pradeep <pnalla@marvell.com>,
 Radha Mohan Chintakuntla <radhac@marvell.com>,
 Veerasenareddy Burru <vburru@marvell.com>
Cc: jerinj@marvell.com, sburla@marvell.com, dev@dpdk.org
References: <20210118093602.5449-1-pnalla@marvell.com>
 <20210128152220.214485-6-pnalla@marvell.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <cfb9f538-61ae-e605-5b48-772679dec251@intel.com>
Date: Thu, 28 Jan 2021 16:56:15 +0000
MIME-Version: 1.0
In-Reply-To: <20210128152220.214485-6-pnalla@marvell.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH v5 05/11] net/octeontx_ep: add dev info get
 and configure
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 1/28/2021 3:22 PM, Nalla Pradeep wrote:
> Add device information get and device configure operations.
> 
> Signed-off-by: Nalla Pradeep <pnalla@marvell.com>

<...>

> +static int
> +otx_ep_dev_configure(struct rte_eth_dev *eth_dev)
> +{
> +	struct otx_ep_device *otx_epvf = OTX_EP_DEV(eth_dev);
> +	struct rte_eth_dev_data *data = eth_dev->data;
> +	struct rte_eth_rxmode *rxmode;
> +	struct rte_eth_txmode *txmode;
> +	struct rte_eth_conf *conf;
> +
> +	conf = &data->dev_conf;
> +	rxmode = &conf->rxmode;
> +	txmode = &conf->txmode;
> +	if (eth_dev->data->nb_rx_queues > otx_epvf->max_rx_queues ||
> +	    eth_dev->data->nb_tx_queues > otx_epvf->max_tx_queues) {
> +		otx_ep_err("invalid num queues\n");
> +		return -ENOMEM;

I can see there are a few more 'ENOMEM' return are remaining, can you please 
scan all code for improper return value usage?