From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 31BF5A0524; Thu, 30 Jan 2020 13:57:08 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E3A801BFFC; Thu, 30 Jan 2020 13:57:06 +0100 (CET) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id BA77A1BFFA for ; Thu, 30 Jan 2020 13:57:05 +0100 (CET) Received: by mail-wr1-f66.google.com with SMTP id y11so3909586wrt.6 for ; Thu, 30 Jan 2020 04:57:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=aYZykSeMfKDoqYQS+ziU8m0R0lj3YHj6fq1zsQ4AGc4=; b=sJGPrYmMVgzySg1jZeWglm/HS71l+0NQTHo85ynaCjzKHhA3t7psRMGD4HGPdXfY0R 6lkdXwAaMEPf7ePq/uWSWVTz2BJ4tWAIwxwKV1x/rL8Jjphu285IKp60X9+Zzmny5nWu tu/+l8a3Cwq4U4F+UvR0Y/ZjiJFEBFNft0QWNJjYOxdbDvkPLvYWAtSZHcmGQu7qBpwt CT3X1hOyovVje4WoqexUUv54tRWoJf1+ewGawwXTvkYLaWBQGOP7SE4Krncid4MzcpGJ Eu/YLxPDF+Dt2bwKYYMQ9Q9wvqieVdB27+F11V7tRlRvbe13+x1ovK05E54I0DQhOriF q7WQ== X-Gm-Message-State: APjAAAUW86G+4MIo3PNiH1ZRKu8A5/OWYzl5BsQTSMvtdZEzG6bD3We+ 0zV6//tAKAmfYnv3eR7uPkY= X-Google-Smtp-Source: APXvYqzrXwKbwAClxq+b5hJcTql1GPW6dhc8YWBWwQv67B+voGEv5e6z5Rtlmi/hdQq+jQ7Tx8Dl8A== X-Received: by 2002:adf:a41c:: with SMTP id d28mr5777682wra.410.1580389025375; Thu, 30 Jan 2020 04:57:05 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id y185sm6647318wmg.2.2020.01.30.04.57.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jan 2020 04:57:04 -0800 (PST) Message-ID: From: Luca Boccassi To: Thomas Monjalon , Ferruh Yigit Cc: Neil Horman , Cristian Dumitrescu , Eelco Chaudron , dev@dpdk.org, David Marchand , Bruce Richardson , Ian Stokes , Andrzej Ostruszka Date: Thu, 30 Jan 2020 12:57:04 +0000 In-Reply-To: <1948601.PIDvDuAF1L@xps> References: <20200129122953.2016199-1-ferruh.yigit@intel.com> <20200129164350.3724793-1-ferruh.yigit@intel.com> <1948601.PIDvDuAF1L@xps> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [RFC v2] meter: fix ABI break due to experimental tag removal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 2020-01-30 at 13:33 +0100, Thomas Monjalon wrote: > Hi, >=20 > I disagree with the need of this patch. > The symbol was experimental, meaning we can change it. > Removing experimental tag is not an ABI break. Hi, This symbol change was requested for backport in 19.11.x, and experimental or not I'm not too keen on backward incompatible changes to the public interface in an _LTS point release_. The compromise was to see if we could support both symbols version, which makes the change backward compatible. If you prefer not to have this patch in mainline I'm also fine in taking it just for the LTS. I agree with you that it is not required for mainline releases (although nicer for me if it's a backport rather than a new change). > 29/01/2020 17:43, Ferruh Yigit: > > Duplicated the existing symbol and versioned one as experimental > > and > > other as stable. >=20 > [..] > > --- a/lib/librte_meter/rte_meter_version.map > > +++ b/lib/librte_meter/rte_meter_version.map > > @@ -20,4 +20,12 @@ DPDK_20.0.1 { > > rte_meter_trtcm_rfc4115_color_blind_check; > > rte_meter_trtcm_rfc4115_config; > > rte_meter_trtcm_rfc4115_profile_config; > > + > > } DPDK_20.0; > > + > > +EXPERIMENTAL { > > + global: > > + > > + rte_meter_trtcm_rfc4115_config; > > + rte_meter_trtcm_rfc4115_profile_config; > > +}; >=20 >=20 >=20 >=20 >=20 --=20 Kind regards, Luca Boccassi