DPDK patches and discussions
 help / color / mirror / Atom feed
From: Kevin Laatz <kevin.laatz@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: <dev@dpdk.org>, <bruce.richardson@intel.com>,
	<mb@smartsharesystems.com>,  <lizh@nvidia.com>,
	<matan@nvidia.com>, <stephen@networkplumber.org>,
	<lihuisong@huawei.com>,
	Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
	"Sunil Kumar Kori" <skori@marvell.com>
Subject: Re: [PATCH v8] eal: add bus cleanup to eal cleanup
Date: Tue, 4 Oct 2022 16:36:33 +0100	[thread overview]
Message-ID: <cfda5c01-99ec-51fd-8076-bc62e6249749@intel.com> (raw)
In-Reply-To: <CAJFAV8yvjVSd033YP8Egu143Q12Q0zVWVmSsYJJv4u_40fAeGw@mail.gmail.com>

On 04/10/2022 16:28, David Marchand wrote:
> On Tue, Oct 4, 2022 at 3:08 PM Kevin Laatz <kevin.laatz@intel.com> wrote:
>> During EAL init, all buses are probed and the devices found are
>> initialized. On eal_cleanup(), the inverse does not happen, meaning any
>> allocated memory and other configuration will not be cleaned up
>> appropriately on exit.
>>
>> Currently, in order for device cleanup to take place, applications must
>> call the driver-relevant functions to ensure proper cleanup is done before
>> the application exits. Since initialization occurs for all devices on the
>> bus, not just the devices used by an application, it requires a)
>> application awareness of all bus devices that could have been probed on the
>> system, and b) code duplication across applications to ensure cleanup is
>> performed. An example of this is rte_eth_dev_close() which is commonly used
>> across the example applications.
>>
>> This patch proposes adding bus cleanup to the eal_cleanup() to make EAL's
>> init/exit more symmetrical, ensuring all bus devices are cleaned up
>> appropriately without the application needing to be aware of all bus types
>> that may have been probed during initialization.
>>
>> Contained in this patch are the changes required to perform cleanup for
>> devices on the PCI bus and VDEV bus during eal_cleanup(). There would be an
>> ask for bus maintainers to add the relevant cleanup for their buses since
>> they have the domain expertise.
>>
>> Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
>> Acked-by: Morten Brørup <mb@smartsharesystems.com>
>> Reviewed-by: Bruce Richardson <bruce.richardson@intel.com>
>>
> Thanks for the rebase.
> Most of it lgtm, just one question/comment.
>
> [snip]
>
>> diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c
>> index a1bb5363b1..b9a7792c19 100644
>> --- a/lib/eal/freebsd/eal.c
>> +++ b/lib/eal/freebsd/eal.c
>> @@ -896,6 +896,7 @@ rte_eal_cleanup(void)
>>          rte_mp_channel_cleanup();
>>          rte_trace_save();
>>          eal_trace_fini();
>> +       eal_bus_cleanup();
>>          /* after this point, any DPDK pointers will become dangling */
>>          rte_eal_memory_detach();
>>          rte_eal_alarm_cleanup();
> Do you have a reason to put the bus cleanup after the traces are
> stored and the trace subsystem is uninitialised?
>
> With the current location for eal_bus_cleanup(), it means that this
> function (and any code it calls) is not traceable.
> To be fair, I don't think we have any trace points in this code at the
> moment, but we might have in the future.

No reason for doing it after trace un-init. I'll move and resend.

Thanks!



  reply	other threads:[~2022-10-04 15:36 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-19 16:14 [RFC] " Kevin Laatz
2022-04-19 16:36 ` Stephen Hemminger
2022-04-20  6:55 ` Morten Brørup
2022-04-22  9:18   ` Kevin Laatz
2022-04-22 12:14     ` Morten Brørup
2022-04-22 16:27 ` [RFC v2] " Kevin Laatz
2022-05-24  9:08 ` [PATCH v3] " Kevin Laatz
2022-05-24  9:25 ` [PATCH v4] " Kevin Laatz
2022-05-24  9:38   ` Bruce Richardson
2022-05-24 15:19     ` Kevin Laatz
2022-05-24 14:48   ` Stephen Hemminger
2022-05-24 15:20     ` Kevin Laatz
2022-05-25 10:39 ` [PATCH v5] " Kevin Laatz
2022-05-25 11:12   ` Bruce Richardson
2022-05-26  8:36     ` Kevin Laatz
2022-06-01 17:02 ` [PATCH v6] " Kevin Laatz
2022-06-01 17:03   ` Bruce Richardson
2022-06-02  2:06   ` lihuisong (C)
2022-06-03 14:35     ` Kevin Laatz
2022-06-03 14:36 ` [PATCH v7] " Kevin Laatz
2022-06-03 15:11   ` Stephen Hemminger
2022-06-03 15:39     ` Bruce Richardson
2022-06-04  2:07   ` lihuisong (C)
2022-06-07 11:09   ` Thomas Monjalon
2022-06-07 15:12     ` David Marchand
2022-06-13 15:58       ` Bruce Richardson
2022-10-03 12:35         ` David Marchand
2022-10-03 14:39           ` Kevin Laatz
2022-10-04 13:11 ` [PATCH v8] " Kevin Laatz
2022-10-04 15:28   ` David Marchand
2022-10-04 15:36     ` Kevin Laatz [this message]
2022-10-04 16:50 ` [PATCH v9] " Kevin Laatz
2022-10-05  7:45   ` David Marchand
2022-10-05  9:41     ` Thomas Monjalon
2022-10-05 11:03       ` Kevin Laatz
2022-10-05 12:06         ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cfda5c01-99ec-51fd-8076-bc62e6249749@intel.com \
    --to=kevin.laatz@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=lihuisong@huawei.com \
    --cc=lizh@nvidia.com \
    --cc=matan@nvidia.com \
    --cc=mb@smartsharesystems.com \
    --cc=skori@marvell.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).