From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 33AAD1BAF7 for ; Thu, 10 May 2018 15:57:18 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 May 2018 06:57:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,385,1520924400"; d="scan'208";a="54774266" Received: from rhorton-mobl1.ger.corp.intel.com (HELO [163.33.230.88]) ([163.33.230.88]) by orsmga001.jf.intel.com with ESMTP; 10 May 2018 06:57:16 -0700 To: Anatoly Burakov , dev@dpdk.org References: <777ae6b10a7524e188c07ba14e576fc7b0e21018.1524729978.git.anatoly.burakov@intel.com> <7844071bf096c83cf2e92eb4bc759cf013ba47f0.1525366407.git.anatoly.burakov@intel.com> From: Remy Horton Organization: Intel Shannon Limited Message-ID: Date: Thu, 10 May 2018 14:57:15 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <7844071bf096c83cf2e92eb4bc759cf013ba47f0.1525366407.git.anatoly.burakov@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 2/3] malloc: allow reserving biggest element X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 May 2018 13:57:18 -0000 On 03/05/2018 18:18, Anatoly Burakov wrote: [..] > Signed-off-by: Anatoly Burakov [..] > + for (idx = 0; idx < RTE_HEAP_NUM_FREELISTS; idx++) { > + for (elem = LIST_FIRST(&heap->free_head[idx]); > + !!elem; elem = LIST_NEXT(elem, free_list)) { Why the double-negation? Otherwise, see no issues. Acked-by: Remy Horton