From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ferruh.yigit@intel.com> Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 8F1B12BF2 for <dev@dpdk.org>; Thu, 24 Jan 2019 14:54:45 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jan 2019 05:54:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,516,1539673200"; d="scan'208";a="132720979" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.22]) ([10.237.221.22]) by orsmga001.jf.intel.com with ESMTP; 24 Jan 2019 05:54:42 -0800 To: Thomas Monjalon <thomas@monjalon.net> Cc: Kuba Kozak <kubax.kozak@intel.com>, deepak.k.jain@intel.com, bruce.richardson@intel.com, michalx.k.jastrzebski@intel.com, jacekx.piasecki@intel.com, dpdk-dev <dev@dpdk.org>, Stephen Hemminger <stephen@networkplumber.org>, Kevin Traynor <ktraynor@redhat.com>, David Marchand <david.marchand@redhat.com> References: <1499691101-184293-2-git-send-email-kubax.kozak@intel.com> <1499940470-31628-1-git-send-email-kubax.kozak@intel.com> <0d99715f-d628-3719-edcc-62991f91e7f2@intel.com> <3950735.e0BHBgFYen@xps> From: Ferruh Yigit <ferruh.yigit@intel.com> Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJVBBMBAgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBNI2U4dCLsKE45mBx/kz60PfE2EfBQJbughWBQkHwjOGAAoJEPkz60Pf E2Eft84QAIbKWqhgqRfoiw/BbXbA1+qm2o4UgkCRQ0yJgt9QsnbpOmPKydHH0ixCliNz1J8e mRXCkMini1bTpnzp7spOjQGLeAFkNFz6BMq8YF2mVWbGEDE9WgnAxZdi0eLY7ZQnHbE6AxKL SXmpe9INb6z3ztseFt7mqje/W/6DWYIMnH3Yz9KzxujFWDcq8UCAvPkxVQXLTMpauhFgYeEx Nub5HbvhxTfUkapLwRQsSd/HbywzqZ3s/bbYMjj5JO3tgMiM9g9HOjv1G2f1dQjHi5YQiTZl 1eIIqQ3pTic6ROaiZqNmQFXPsoOOFfXF8nN2zg8kl/sSdoXWHhama5hbwwtl1vdaygQYlmdK H2ueiFh/UvT3WG3waNv2eZiEbHV8Rk52Xyn2w1G90lV0fYC6Ket1Xjoch7kjwbx793Kz/RfQ rmBY8/S4DTGn3oq3dMdQY+b6+7VMUeLMMh2CXYO9ErkOq+qNTD1IY+cBAkXnaDbQfz0zbste ZGWH74FAZ9nCpDOqbRTrBL42aMGhfOWEyeA1x7+hl6JZfabBWAuf4nnCXuorKHzBXTrf7u7p fXsKQClWRW77PF1VmzrtKNVSytQAmlCWApQIw20AarFipXmVdIjHmJPU611WoyxZPb4JTOxx 5cv9B+nr/RIB+v5dcStyHCCwO1be7nBDdCgd4F6kTQPLuQINBFfWTL4BEACnNA29e8TarUsB L5n6eLZHXcFvVwNLVlirWOClHXf44o2KnN3ww+eBEmKVfEFo9MSuGDNHS8Zw1NiGMYxLIUgd U6gGrVVs/VrQWL82pbMk6jCj98N+BXIri+6K1z+AImz7ax7iF1kDgRAnFWU0znWWBgM2mM8Y gDjcxfXk4sCKnvf6Gjo08Ey5zmqx7dekAKU2EEp8Q1EJY3jbymLdZWRP4AFFMTS1rGMk0/tt v71NBg1GobCcbNfn9chK/jhqxYhAJqq86RdJQkt3/9x1U1Oq0vXCt4JVVHmkxePtUiuWTTt+ aYlUAsKYZsWvncExvw77x2ArYDmaK0yfjh37wp0lY7DOJHFxoyT8tyWZlLci/VMRG2Ja33xj 0CN4C1yBg+QDeV3QFxQo42iA/ykdXPUR3ezmsND3XKvVLTC4DNb3V/EZQ7jBj64+bEK0VW4G B31VP00ApNQvSoczsIOAKdk97RNbpmPw6q10ILIB+9T1xbnFYzshzGF17oC0/GENIHATx8vZ masOZoDiOZQpeneLgnFE9JfzhLTxv6wNZcc/HLXRQVTkDsQr8ERtkAoHCf1E5+b5Yr7pfnE4 YuhET746o25S53ELUYPIs49qoJsEJL34/oexMfPGyPIlrbufiNyty5jc/1MRwUlhJlJ5IOHy ZUa+6CLR7GdImusFkPJUJwARAQABiQI8BBgBAgAmAhsMFiEE0jZTh0IuwoTjmYHH+TPrQ98T YR8FAlu6CHAFCQXE7zIACgkQ+TPrQ98TYR9nXxAAqNBgkYNyGuWUuy0GwDQCbu3iiMyH1+D7 llafPcK4NYy1Z4AYuVwC9nmLaoj+ozdqS3ncRo57ncRsKEJC46nDJJZYZ5LSJVn63Y3NBF86 lxQAgjj2oyZEwaLKtKbAFsXL43jv1pUGgSvWwYtDwHITXXFQto9rZEuUDRFSx4sg9OR+Q6/6 LY+nQQ3OdHlBkflzYMPcWgDcvcTAO6yasLEUf7UcYoSWTyMYjLB4QuNlXzTswzGVMssJF/vo V8lD1eqqaSUWG3STF6GVLQOr1NLvN5+kUBiEStHFxBpgSCvYY9sNV8FS6N24CAWMBl+10W+D 2h1yiiP5dOdPcBDYKsgqDD91/sP0WdyMJkwdQJtD49f9f+lYloxHnSAxMleOpyscg1pldw+i mPaUY1bmIknLhhkqfMmjywQOXpac5LRMibAAYkcB8v7y3kwELnt8mhqqZy6LUsqcWygNbH/W K3GGt5tRpeIXeJ25x8gg5EBQ0Jnvp/IbBYQfPLtXH0Myq2QuAhk/1q2yEIbVjS+7iowEZNyE 56K63WBJxsJPB2mvmLgn98GqB4G6GufP1ndS0XDti/2K0o8rep9xoY/JDGi0n0L0tk9BHyoP Y7kaEpu7UyY3nVdRLe5H1/MnFG8hdJ97WqnPS0buYZlrbTV0nRFL/NI2VABl18vEEXvNQiO+ vM8= Message-ID: <cff15723-fb99-a04b-54bc-689b5728666f@intel.com> Date: Thu, 24 Jan 2019 13:54:41 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <3950735.e0BHBgFYen@xps> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v5 0/3] EAL change for using a config file for DPDK X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 24 Jan 2019 13:54:46 -0000 On 1/23/2019 8:26 PM, Thomas Monjalon wrote: > 23/01/2019 20:31, Ferruh Yigit: >> On 7/13/2017 11:07 AM, kubax.kozak at intel.com (Kuba Kozak) wrote: >>> This patchset introduce a mechanism for running dpdk application with >>> parameters provided by configuration file. >>> >>> A new API for EAL takes a config file data type - either loaded from >>> file, or built up programmatically in the application - and extracts >>> DPDK parameters from it to be used when eal init is called. >>> This allows apps to have an alternative method to configure EAL, >>> other than via command-line parameters. >>> >>> Reworked applications are used to demonstrate the new eal API. >>> If a --cfgfile-path <path> option is passed into command line non >>> EAL section, then the file is loaded and used by app. If a file >>> called config.ini is present in current working directory, and >>> no --cfgfile-path option is passed in, config.ini file will be >>> loaded and used by app. >>> >>> Patch "app/testpmd: add parse options from JSON cfg file" >>> demonstrates the usage of JSON instead of INI file format. >>> JSON file can be called the same way as above, >>> through --cfgfile-path <path> argument. >>> --- >>> this patch depends on: >>> "Rework cfgfile API to enable apps config file support" >>> >>> v5: >>> changed define "RTE_DEVTYPE_VIRTUAL" to "RTE_DEVTYPE_UNDEFINED" >>> due to compilation errors (changes on current master). >>> >>> v4: >>> Code optimalisation in parse_vdev_devices() function. >>> Moved some functions from librte_eal/bsdapp and librte_eal/linuxapp >>> to the librte_eal/common. >>> Bug fixes. >>> >>> v3: >>> split one patchset into two distinct patchsets: >>> 1. cfgfile library and TEST app changes >>> 2. EAL changes and examples (this patchset depends on cfgfile) >>> >>> v2: >>> lib eal: >>> Rework of rte_eal_configure(struct rte_cfgfile *cfg, char *prgname). >>> Now this function load data from cfg structure and did initial >>> initialization of EAL arguments. Vdev argument are stored in different >>> subsections eg. DPDK.vdev0, DPDK.vdev1 etc. After execution of this >>> function it is necessary to call rte_eal_init to complete EAL >>> initialization. There is no more merging arguments from different >>> sources (cfg file and command line). >>> Added non_eal_configure to testpmd application. >>> Function maintain the same functionality as rte_eal_configure but >>> for non-eal arguments. >>> Added config JSON feature to testpmd last patch from patchset contain >>> example showing use of .json configuration files. >>> >>> lib cfgfile: >>> Rework of add_section(), add_entry() new implementation >>> New members allocated_entries/sections, free_entries/sections >>> in rte_cfgfile structure, change in array of pointers >>> **sections, **entries instead of *sections[], *entries[] >>> Add set_entry() to update/overwrite already existing entry in cfgfile >>> struct >>> Add save() function to save on disc cfgfile structure in INI format >>> Rework of existing load() function simplifying the code >>> Add unit test realloc_sections() in TEST app for testing realloc/malloc >>> of new API functions, add test for save() function >>> >>> Kuba Kozak (3): >>> eal: add functions parsing EAL arguments >>> app/testpmd: add parse options from cfg file >>> app/testpmd: add parse options from JSON cfg file >> >> This patchset is idle more than a year now. >> It solves problem of eal parameters, it doesn't remove them but at least moves >> from command line to config file. >> >> The patch seems mostly done, but what is the status of it, do we want to >> continue it? >> And if we want to continue it can this be a good candidate for GCOS? > > I think we must focus on reorganization of EAL first. > When the options parsing will be better isolated, > and accessible from API independant of rte_eal_init, > then we could provide some helpers to use those APIs > for a config file, a custom command line or anything else. Is there any actions do we need to take when patches are rejected?