From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE445A00C4; Fri, 1 Jul 2022 15:54:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ACB1B40A7D; Fri, 1 Jul 2022 15:54:09 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id D5A6C4069D for ; Fri, 1 Jul 2022 15:54:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656683647; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=II1FKKaWzrrjJXVY6luukJPb+FTTX80hSiOpYZeLguU=; b=a+iA/ny2c6sFBl+ABpML1i2Yju6akyscaJTRzRAi+djlEWUDRA7vok+qSSwkiSwlVSnswu 1O49lcdJ3U0ddbxhQh1pUpkqCK5wH0L5Sl0WA7b77cAvTgt0dI27fR9mTvM3ukhwdtW45S LuI0t6foNkuxCYn9tOh7WFqPAdBhGio= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-619-hiEASbaCOPas8dr56yFdjg-1; Fri, 01 Jul 2022 09:54:02 -0400 X-MC-Unique: hiEASbaCOPas8dr56yFdjg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E9B59800882; Fri, 1 Jul 2022 13:54:00 +0000 (UTC) Received: from [10.39.208.30] (unknown [10.39.208.30]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E05882166B26; Fri, 1 Jul 2022 13:53:59 +0000 (UTC) Message-ID: Date: Fri, 1 Jul 2022 15:53:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] net/virtio: fix socket nonblocking mode affects initialization To: Yuan Wang , chenbo.xia@intel.com, dev@dpdk.org Cc: jiayu.hu@intel.com, xingguang.he@intel.com, stable@dpdk.org References: <20220617024229.706826-1-yuanx.wang@intel.com> From: Maxime Coquelin In-Reply-To: <20220617024229.706826-1-yuanx.wang@intel.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/17/22 04:42, Yuan Wang wrote: > The virtio-user initialization requires unix socket to receive backend > messages in block mode. However, vhost_user_update_link_state() sets > the same socket to nonblocking via fcntl, which affects all threads. > Enabling the rxq interrupt can causes both of these behaviors to occur > concurrently, with the result that the initialization may fail > because no messages are received in nonblocking socket. > > Thread 1: > virtio_init_device() > --> virtio_user_start_device() > --> vhost_user_set_memory_table() > --> vhost_user_check_reply_ack() > > Thread 2: > virtio_interrupt_handler() > --> vhost_user_update_link_state() > > Fix that by replacing O_NONBLOCK with the recv per-call option > MSG_DONTWAIT. > > Fixes: ef53b6030039 ("net/virtio-user: support LSC") > Cc: stable@dpdk.org > > Signed-off-by: Yuan Wang > --- > drivers/net/virtio/virtio_user/vhost_user.c | 15 +-------------- > 1 file changed, 1 insertion(+), 14 deletions(-) > Applied to dpdk-next-virtio/main. Thanks, Maxime