From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 34B185582 for ; Tue, 5 Jul 2016 12:45:04 +0200 (CEST) Received: by mail-wm0-f47.google.com with SMTP id a66so146905573wme.0 for ; Tue, 05 Jul 2016 03:45:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=7ShCsuEwOpySa80GIclqOHA+vd3r6hEekwwlwEQjbjg=; b=aR+aMldiJ4YIwSk5G5w9PWCnBfXmFgEMbD4KwfsH3GTe/3f4A2qKjZGI2WWafthRc+ LeY2JR5c04Dr49fYTMRYwbhoB9pHwEyWqbtbj6iS3J8ITIwDBwjP7QP2wvxcHEKem7BA G7sJ7DUY/CHxEcQzuyolme22TNhoWKe+9hL4OFbn+qaddc0DV3oi1obtmBZVCjxEgB8D A6GN9XQ8hLEWjhWxPM/PqGyrWI0Bw5usM7v6pktDl3R0M/B8jEcu5YnwQimxGy+8g5n+ P4q1MUx4gCUiQ2X7d54m0yg1PVkhPJcvotLmABIZ9uoTLVNBu1hVbeIysi+M6S9R6v66 venw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=7ShCsuEwOpySa80GIclqOHA+vd3r6hEekwwlwEQjbjg=; b=FF35c3jWcs1OGyX+WaHJ41a2XO/OfDCbcDcVRUUhJSDA+kulrOG8ZSUkc1ePT4wQuv LS/zm7DTl1QeJ7dZtwpwjbzFFdLIh8NnxthUGGcRaK8/C8FqeJLWPytcJq+Pwaik6vLm yCq7pxTMMn3I6+ATJs16MLQtImkMNxkJ0BNkC9/mIViMZbdNY6AAATrdsv+G9N/a4Hdg 2ht2FvRH/jIT+NrYb8qHxWuNrih1mppIcNVUCeJ0YVXZzb8qP3xCo51Z4IR/amS7+cHz GiZPoiPdifk1gsbjbgbzolz0bDhYizxS/09kYOiFJ57bdghc1Y7ftWkuPrV9mFtMbkop ioHw== X-Gm-Message-State: ALyK8tKb6JVUGvDH9bi/N3E/sZR9mDtTjj8azyBqgLLC38dEAo4nqrCZBAh8wZtIpAfHabgG X-Received: by 10.28.74.20 with SMTP id x20mr16029884wma.14.1467715503888; Tue, 05 Jul 2016 03:45:03 -0700 (PDT) Received: from 6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id a4sm2698437wjq.40.2016.07.05.03.45.02 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 05 Jul 2016 03:45:03 -0700 (PDT) From: Adrien Mazarguil To: dev@dpdk.org Cc: Jan Viktorin Date: Tue, 5 Jul 2016 12:44:46 +0200 Message-Id: X-Mailer: git-send-email 2.1.4 In-Reply-To: <1459865290-10248-1-git-send-email-adrien.mazarguil@6wind.com> References: <1459865290-10248-1-git-send-email-adrien.mazarguil@6wind.com> Subject: [dpdk-dev] [PATCH v2 00/11] Fix build errors related to exported headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jul 2016 10:45:04 -0000 DPDK uses GNU C language extensions in most of its code base. This is fine for internal source files whose compilation flags are controlled by DPDK, however user applications that use exported "public" headers may experience compilation failures when enabling strict error/standard checks (-std and -pedantic for instance). Exported headers are installed system-wide and must be as clean as possible so applications do not have to resort to workarounds. This patchset affects exported headers only, compilation problems are addressed as follows: - Adding the __extension__ keyword to nonstandard constructs (same method as existing libraries when there is no other choice). - Adding the __extension__ keyword to C11 constructs to remain compatible with pure C99. - Adding missing includes so exported files can be included out of order and on their own. - Fixing GNU printf-like variadic macros as there is no magic keyword for these. Changes in v2: - Rebased on top of the current HEAD. - Added script to check headers automatically (check-includes.sh), for both C and C++ compilation. - Updated test-build.sh to use it. - Fixed consistency of new #include directives, now inside extern "C" blocks for files that already do that (Jan, fixing these was too much work for this patchset so I settled on this solution in the meantime). - Updated headlines to address check-git-log.sh complaints. Adrien Mazarguil (11): lib: work around braced-groups within expressions lib: work around large enum values lib: use C99 syntax for zero-size arrays lib: work around nonstandard bit-fields lib: work around structs with no members lib: work around unnamed structs/unions lib: add missing include dependencies lib: work around forward reference to enum types lib: remove named variadic macros in exported headers lib: hide static functions never defined scripts: check compilation of exported header files MAINTAINERS | 1 + lib/librte_acl/rte_acl.h | 2 +- lib/librte_cfgfile/rte_cfgfile.h | 2 + lib/librte_cmdline/cmdline.h | 1 + lib/librte_cmdline/cmdline_parse_portlist.h | 1 + lib/librte_cmdline/cmdline_socket.h | 3 + lib/librte_cryptodev/rte_crypto.h | 2 + lib/librte_cryptodev/rte_crypto_sym.h | 3 + lib/librte_cryptodev/rte_cryptodev.h | 40 ++- lib/librte_cryptodev/rte_cryptodev_pmd.h | 6 +- .../common/include/arch/arm/rte_byteorder.h | 2 + .../common/include/arch/arm/rte_memcpy_32.h | 3 +- .../common/include/arch/arm/rte_prefetch_32.h | 1 + .../common/include/arch/arm/rte_prefetch_64.h | 1 + .../common/include/arch/arm/rte_vect.h | 1 + .../common/include/arch/ppc_64/rte_atomic.h | 1 + .../common/include/arch/ppc_64/rte_byteorder.h | 1 + .../common/include/arch/ppc_64/rte_cycles.h | 2 + .../common/include/arch/ppc_64/rte_memcpy.h | 3 +- .../common/include/arch/ppc_64/rte_prefetch.h | 1 + .../common/include/arch/x86/rte_atomic.h | 2 + .../common/include/arch/x86/rte_atomic_32.h | 9 + .../common/include/arch/x86/rte_atomic_64.h | 8 + .../common/include/arch/x86/rte_byteorder.h | 2 + .../common/include/arch/x86/rte_byteorder_32.h | 7 + .../common/include/arch/x86/rte_byteorder_64.h | 7 + .../common/include/arch/x86/rte_cycles.h | 2 + .../common/include/arch/x86/rte_memcpy.h | 4 +- .../common/include/arch/x86/rte_prefetch.h | 1 + .../common/include/arch/x86/rte_rtm.h | 1 + .../common/include/arch/x86/rte_vect.h | 8 +- .../common/include/generic/rte_atomic.h | 1 + .../common/include/generic/rte_byteorder.h | 2 + .../common/include/generic/rte_cpuflags.h | 3 + .../common/include/generic/rte_memcpy.h | 4 + lib/librte_eal/common/include/rte_common.h | 22 +- lib/librte_eal/common/include/rte_devargs.h | 1 + lib/librte_eal/common/include/rte_eal.h | 1 + lib/librte_eal/common/include/rte_interrupts.h | 2 + lib/librte_eal/common/include/rte_memory.h | 4 + lib/librte_eal/common/include/rte_memzone.h | 2 + lib/librte_eal/common/include/rte_time.h | 8 + lib/librte_eal/common/include/rte_version.h | 1 + .../eal/include/exec-env/rte_interrupts.h | 1 + .../eal/include/exec-env/rte_kni_common.h | 6 +- lib/librte_ether/rte_dev_info.h | 2 + lib/librte_ether/rte_eth_ctrl.h | 4 + lib/librte_ether/rte_ethdev.h | 4 + lib/librte_hash/rte_fbk_hash.h | 2 +- lib/librte_hash/rte_thash.h | 3 + lib/librte_ip_frag/rte_ip_frag.h | 2 +- lib/librte_lpm/rte_lpm.h | 7 +- lib/librte_lpm/rte_lpm_neon.h | 1 + lib/librte_lpm/rte_lpm_sse.h | 1 + lib/librte_mbuf/rte_mbuf.h | 9 + lib/librte_mempool/rte_mempool.h | 3 + lib/librte_pdump/rte_pdump.h | 4 + lib/librte_pipeline/rte_pipeline.h | 4 +- lib/librte_reorder/rte_reorder.h | 2 + lib/librte_ring/rte_ring.h | 2 +- lib/librte_sched/rte_bitmap.h | 3 +- lib/librte_sched/rte_reciprocal.h | 2 + lib/librte_sched/rte_sched_common.h | 1 + lib/librte_timer/rte_timer.h | 2 + scripts/check-includes.sh | 286 +++++++++++++++++++ scripts/test-build.sh | 14 + 66 files changed, 511 insertions(+), 33 deletions(-) create mode 100755 scripts/check-includes.sh -- 2.1.4