From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f172.google.com (mail-wr0-f172.google.com [209.85.128.172]) by dpdk.org (Postfix) with ESMTP id C049B9E3 for ; Wed, 21 Jun 2017 01:29:46 +0200 (CEST) Received: by mail-wr0-f172.google.com with SMTP id r103so111469857wrb.0 for ; Tue, 20 Jun 2017 16:29:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=TMFmPcDbB/mfP+6ZuSrEXPiLcqReVqkBU6fRRJJ+0Ec=; b=AYBj3aOsMVacS9o19ePff3nwvOPM9d6zYieWwBUZAOBrhnleSGu7bAnWZJPse3qQli QIPtx02z8fTCj9U85HyAxnwaIpB49erlGhJ2JTW9gpvZwySdTjbiskrC4vBTzA4tvHag 4nw2QhoVqkvdMpg7LS7VHAvafMWVnhNR7wRRYrS33Eaxmj12sLtEEALYcrFYCPJhjxC+ x4x9mUf74GjNnCJcgtpG82uCSjA5IK+RGT3niOV/k3N4D4pXlcryKcrADnEYd7ew341W X8r7u2sHBwKI6PooFhxsktT3rau9stxrlaJwQ3H166iSZDpkuTOXdQLkJxBlKEFLZwUb x6OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=TMFmPcDbB/mfP+6ZuSrEXPiLcqReVqkBU6fRRJJ+0Ec=; b=huQIlSslu9SOcSJaTbnYF/BqQazGgGBP9/C1E8aKHAq4pJv6ICJvnryv8IpBcOr0CS 5zVvY+vt6LYV/TC6z7J79Gs7EmVSNLah95XMxBgydArjx7O3l57+/WI5D6D1keBz72XD uyJCnb6csHQGgVS86pg0eUOjGv0wXnBvmvKUc0w1ylWJ0COF7RJRCvulcIGv6lGpSB5Q n5W0gzu10B0pUWLEuCxjZp6q1Q18B6Wq3zKRIxunGyXFWYF0Q38ajgRgZxjnkdn/YB7l MnQZXeqJAMmuHpEQ/IxTyWnxaG7zxUDhsxQeqA4IUuXVeFrO9D7SHn4CLDZuEONj9YnP raYA== X-Gm-Message-State: AKS2vOzQ3U7yOKmz/287xB74Hu1lsQDVKMec4sj+tvcCRM8MTJ/bEFFi lQSJ1Uy4qskRRTWpDQk= X-Received: by 10.28.19.11 with SMTP id 11mr4363167wmt.123.1498001385863; Tue, 20 Jun 2017 16:29:45 -0700 (PDT) Received: from bidouze.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id l127sm8592248wml.26.2017.06.20.16.29.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 20 Jun 2017 16:29:44 -0700 (PDT) From: Gaetan Rivet To: dev@dpdk.org Cc: Gaetan Rivet , Jan Blunck , Shreyansh Jain , Stephen Hemminger Date: Wed, 21 Jun 2017 01:29:21 +0200 Message-Id: X-Mailer: git-send-email 2.1.4 In-Reply-To: References: Subject: [dpdk-dev] [PATCH v4 0/9] bus: attach / detach API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jun 2017 23:29:47 -0000 Following the work from Jan: This patchset introduces the attach / detach API to rte_bus. The rte_device structure is used as the generic device representation. This API is implemented for the virtual bus. The functions rte_eal_dev_attach and rte_eal_dev_detach are updated to use this new interface. -- v2 0. API rework ------------- I would like to propose an evolution on the API developed by Jan. The attach / detach rte_bus API is necessary to support the attach/detach rte_dev API. Those are two different levels for one similar functionality. Attach / detach does not allow true hotplugging, because the attach function expects the devices operated upon to already exist within the buses / sub-layers. This means that this API expects devices meta-datas (bus-internal device representation and associated device information read from the system) to be present upon attach. This part of the work is done during scanning. While it is best to avoid changing the public rte_dev API as it already exists, nothing prevents this new rte_bus API from superseeding it. It has been said during the previous release cycle that device hotplug was a feature that interested users. True hotplug is not allowed by the current attach / detach API. Worse, this API hinders the effort to bring this new functionality by squatting its semantic field. Thus, I propose to rename rte_bus attach / detach; plug / unplug. As it is a superset of the attach / detach functionality, it can be used to implement rte_dev attach / detach. Now is the right time to pivot to this new feature. This should help maintainers understanding the aim of this API and the differences with the APIs higher-up, clarify the field and allow a new functionality to be proposed. The vdev bus is inherently supporting the new API, however it has been made explicit. My implementation in the PCI bus in further patchset also follows the rte_bus hotplug API instead of only attach / detach. One remaining problem with the vdev bus is the rte_dev attach implementation, which needs the rte_devargs rework to be properly fixed. 1. Additional evolutions in the patchset ---------------------------------------- The RTE_VERIFY on the find_device is too stringent I think and forces all buses to implement a public device iterator. While it could be argued that it would push for quicker support for the functionality, I think it's possible that some buses are not interested at all in it and should simply be ignored. The bus devices iterator has been fixed. The internal rte_device handle was not properly setup within the net_ring PMD. -- v3 The new API is now typedef struct rte_device * (*rte_bus_plug_t)(struct rte_devargs *da); typedef int (*rte_bus_unplug_t)(struct rte_device *dev); So, plugging a device takes an rte_devargs as input and returns an rte_device. While implementing related subsystems, I found that I usually needed this rte_device handle upon a successful device plugging. This seems the sensible and useful thing to do. As such, on error NULL is returned and rte_errno is set by the bus. Unplugging a device however now returns to the first version, which used an rte_device. The explicit contract here is that if one has an rte_device that has been obtained by calling bus->plug(), then this handle can be used for bus->unplug(). Additionally, bus and device comparators now returns 0 on match, following strcmp-like behavior. -- v4 * rte_bus_find now takes a *start* parameter, that can be null. The bus search starts from this element if set. * A few doc fixes. * The rte_device field was fixed within the rte_ring PMD in a previous patch. This fix has been integrated by other means, it is not necessary anymore. Gaetan Rivet (1): vdev: implement hotplug functionality Jan Blunck (8): bus: add bus iterator to find a particular bus bus: add device iterator bus: add helper to find bus for a particular device bus: add bus helper iterator to find a particular device bus: introduce hotplug functionality vdev: implement find_device bus operation eal: make virtual driver probe and remove take rte_vdev_device ethdev: use embedded rte_device to detach driver lib/librte_eal/bsdapp/eal/rte_eal_version.map | 4 + lib/librte_eal/common/eal_common_bus.c | 70 ++++++++++++++++ lib/librte_eal/common/eal_common_dev.c | 100 +++++++++++++++++----- lib/librte_eal/common/eal_common_vdev.c | 49 +++++++++++ lib/librte_eal/common/include/rte_bus.h | 107 ++++++++++++++++++++++++ lib/librte_eal/common/include/rte_dev.h | 28 +++++++ lib/librte_eal/linuxapp/eal/rte_eal_version.map | 3 + lib/librte_ether/rte_ethdev.c | 31 +++---- 8 files changed, 349 insertions(+), 43 deletions(-) -- 2.1.4