From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f175.google.com (mail-wr0-f175.google.com [209.85.128.175]) by dpdk.org (Postfix) with ESMTP id 9D7A65F2D for ; Thu, 29 Mar 2018 23:24:14 +0200 (CEST) Received: by mail-wr0-f175.google.com with SMTP id s18so6549909wrg.9 for ; Thu, 29 Mar 2018 14:24:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=etF0z9fWcP95KMAem2QGVEMxzaSho7ipkeT9X0yy9BY=; b=A+ffh4aRS+JFbqXYBeMUlFuXlgmZ0L2+uiSfnBlyfznc8GKEJeWYg1YcDu0zuqb1ER xfBN1D8JLYJ/dQtAGIeTvNDskp4LlxZXnWPZdIZDly1YJKgvQdfc8Tg0Q/MUhRDyfR7V Qh1cZFkvvQqiyONyb2jVOHb8dpz4xP/6yVqli5yj9FtGwzF8V6nGTnxGenK2958jY2mX 5zTgz11B2xuRp+AkvXjN0kEa97WL+tnVBQESGX61iiviXxmTdf0rj1NbH8TCEULzfsc7 JbxCACRFDup2KhOKowLhr7i9zKMB0sLNlGhBIzw3VqyuxnXOTtJW93a6O4dpnRMhuThU F+NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=etF0z9fWcP95KMAem2QGVEMxzaSho7ipkeT9X0yy9BY=; b=O5HfCojMs3+O3ZQIL+chNnx4UnF0fIqXctTPBJB+G0qsEnEiHEmvlmm74SB4iR3wdy y7/Yqrhkvw885GLPKWKd30wdJV9fvWdP0DEH2sozp/z1D9czOvmkshOL4KT0Qv8wp0gl wcpepqjUbfyqmpl76hFnnNY+LHUrvgOGIvxiLhKBF2x660Z8/wLGcP19ArRjt8AU6RgO e0cSBcr29kb4l66sJQlvlj7F3DJuJOsWW93SHCqOMS4BFXF7Z0jMm7Jt81oqC/nKTXKB +A4O2/ylrnBglKzoG8kDQjIjqiAhSLiW6wDYt7W5YhOvWgy/wury32/6N3gf9L827wuO kLHw== X-Gm-Message-State: AElRT7FLXG8Ba/FCsRlXCNHXOA2BQKB9gZ3c2MPLbKoh+ZflLP7IyMmk 2zIZroZ6wF9yvHFeN2i9QtRfzfuc X-Google-Smtp-Source: AIpwx4/L8JMM4j/4j9+AUiCo0I9hI1Mv4QN0WwrRAdDqo2mAEToxUAEXNrV99T97d4+FtH8BAodd6Q== X-Received: by 10.223.200.138 with SMTP id k10mr8086573wrh.282.1522358653566; Thu, 29 Mar 2018 14:24:13 -0700 (PDT) Received: from bidouze.dev.6wind.com. (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id m35sm11907457wrm.59.2018.03.29.14.24.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Mar 2018 14:24:12 -0700 (PDT) From: Gaetan Rivet To: dev@dpdk.org Cc: Gaetan Rivet Date: Thu, 29 Mar 2018 23:23:24 +0200 Message-Id: X-Mailer: git-send-email 2.11.0 In-Reply-To: References: Subject: [dpdk-dev] [PATCH v4 00/20] Device querying X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Mar 2018 21:24:14 -0000 This patchset introduces a new EAL API for querying devices, filtered by arbitrary properties. The following elements are introduced to this end: * A new object, "rte_class", is used to describe the device class abstraction layer (eth, crypto, ...). * Both rte_bus and rte_class now offer a way to list their devices and filter the result using locally defined properties. * The rte_dev API now has an rte_dev_iterator, which is the way for the user to define the device filter and iterate upon the resulting set. As an example, the "eth" device class is implemented. Additionally, the device filters for + rte_bus_pci + rte_bus_vdev + rte_class_eth are implemented and can be used with some properties each, to show how to extend those. Some example of filters: "bus=pci/class=eth" "bus=pci" "class=eth" "class=eth,name=net_ring0" "bus=pci,id=00:00.0" "bus=vdev,driver=net_ring" --- v2: * Reworked the dev_iterate callback to simplify its implementation. Now dev_iterate implementation do not need to learn about the intricacies of the rte_dev_iterator. The rte_dev_iterator is managed purely by the rte_dev_iterator_next function. Buses and classes then do not have to care about settings things right. Additionally, dev_iterate implementations do not have to sanitize their dev string anymore, they are prepared by the rte_dev layer prior, which also reduces the number of dynamic allocations. v3: * Introduced central constructor priority list. * Removed lightweight kvarg parsing utility, using librte_kvargs instead. * Reversed dependencies of librte_kvargs and librte_eal. * Fixed a few bugs. * @Bruce: I have noted the request for meson support. I will install it and attempt it once the bulk of the work is done. v4: * Fixed a few bugs, added relevant acks, fixed some typos. * Made each matching functions actually check for a proper list of accepted properties. * rte_kvargs now includes rte_eal directly and keeps rte_log. * added generic string comparison function to rte_kvargs, as some kind of comparison should probably be shared by many layers. Gaetan Rivet (20): kvargs: build before EAL eal: list acceptable init priorities eal: introduce dtor macros eal: introduce device class abstraction eal/class: register destructor eal/dev: add device iterator interface eal/class: add device iteration eal/bus: add device iteration eal/dev: implement device iteration initialization eal/dev: implement device iteration kvargs: add generic string matching callback bus/pci: fix find device implementation bus/pci: implement device iteration and comparison bus/pci: add device matching field id bus/vdev: fix find device implementation bus/vdev: implement device iteration bus/vdev: add device matching field driver ethdev: register ether layer as a class ethdev: add device matching field name app/testpmd: add show device command app/test-pmd/cmdline.c | 52 ++++ drivers/bus/pci/Makefile | 2 +- drivers/bus/pci/pci_common.c | 87 +++++- drivers/bus/pci/rte_bus_pci.h | 3 + drivers/bus/vdev/Makefile | 3 +- drivers/bus/vdev/rte_bus_vdev.h | 3 + drivers/bus/vdev/vdev.c | 66 +++- lib/Makefile | 7 +- lib/librte_eal/bsdapp/eal/Makefile | 2 + lib/librte_eal/common/Makefile | 4 +- lib/librte_eal/common/eal_common_class.c | 62 ++++ lib/librte_eal/common/eal_common_dev.c | 334 +++++++++++++++++++++ lib/librte_eal/common/eal_common_log.c | 2 +- lib/librte_eal/common/include/rte_bus.h | 3 +- lib/librte_eal/common/include/rte_class.h | 127 ++++++++ lib/librte_eal/common/include/rte_common.h | 32 +- lib/librte_eal/common/include/rte_dev.h | 95 ++++++ lib/librte_eal/linuxapp/eal/Makefile | 2 + lib/librte_eal/rte_eal_version.map | 4 + lib/librte_ether/Makefile | 3 +- lib/librte_ether/rte_class_eth.c | 79 +++++ lib/librte_kvargs/Makefile | 3 +- lib/librte_kvargs/rte_kvargs.c | 12 +- lib/librte_kvargs/rte_kvargs.h | 28 ++ lib/librte_kvargs/rte_kvargs_version.map | 7 + .../include => librte_kvargs}/rte_string_fns.h | 0 26 files changed, 995 insertions(+), 27 deletions(-) create mode 100644 lib/librte_eal/common/eal_common_class.c create mode 100644 lib/librte_eal/common/include/rte_class.h create mode 100644 lib/librte_ether/rte_class_eth.c rename lib/{librte_eal/common/include => librte_kvargs}/rte_string_fns.h (100%) -- 2.11.0