From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by dpdk.org (Postfix) with ESMTP id 1FEFE1BBD6 for ; Thu, 20 Dec 2018 18:07:15 +0100 (CET) Received: by mail-wm1-f67.google.com with SMTP id n190so2825126wmd.0 for ; Thu, 20 Dec 2018 09:07:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=cLEJpebV892UB9VPamao0xdhigQIbPgpj4BYqnp50cU=; b=cT4fXnpc6lY2loPBhSD02ht1ZMXPQrgPEU+4hB/CAoOVUMFG6RzEYIQKcqKaP+QbxT IHgX2vB5eKiqlr/ly2VVOIK7L1r46iSUVUComDp+2jTBu3F0mSA4hw57oexYDSCb1C/W NdANHLbSsNbkhdH/qhTmkAEp8elQP56FdeiCK/KeJzzaNmqC/Xzq/LzAYyzfciz3NfG5 cKvQCihy3kLCLNii+3W44yaMIcSPqsE92waArtB+Px5D0P1/oQaZeSdz1OeUEHcto5Yd AOIVB/zoaCHIdNLzhv00iOs3umPoemZgrbbHsu+v+YivAPqHFtBiebWpZUkifhhAcMvb 7QYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=cLEJpebV892UB9VPamao0xdhigQIbPgpj4BYqnp50cU=; b=mC9sCvIotzlMxbqU8xi5oqQFvjZu6tT5ZFLwndsjcuZfL4Ju89OOwcfk6UQEBozJch 0ZxnRa80kyfLBjPfTeBk8QilCQz76LcMBSml65pTuuV5uiWmb3qdK4L1o4vqRVupPj/X Ng4naEBfn4mIhO18P+9GHgOvWjKBkqk6VGKEsty71fhb+5KxL30obDE5t+lqXgWruVC2 QTy7UhxJE0vTesVIKxVT0KJhlmUIYAJ7KLFcB/G4KBPqaHoIeZ4QN6hUrTJK/G/hwks4 cY6pSTO0W/Nu5a0JLxYKSk52I3FT+Mvse7ofcQIpLnp6KHEs0oL5IQ+V8FLw4JHxP3oJ KmCA== X-Gm-Message-State: AA+aEWZabxbfGB3xcX3xH4aAwzIv2ffEIqESc5VDgOQCtjBQd6FZsQCj DnY9wkaH30E5vYDWzoTaG2ivs/ajixw= X-Google-Smtp-Source: AFSGD/Vx0SMVuw2lBZ3fuUz2HYcONjES4mMY2mYiKc7cQsOa3qxt5NLTQH6NoECbOMIl5i9jOibHng== X-Received: by 2002:a1c:b455:: with SMTP id d82mr12701576wmf.78.1545325634154; Thu, 20 Dec 2018 09:07:14 -0800 (PST) Received: from bidouze.dev.6wind.com. (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id n5sm11951688wrr.94.2018.12.20.09.07.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 20 Dec 2018 09:07:13 -0800 (PST) From: Gaetan Rivet To: dev@dpdk.org Cc: Gaetan Rivet Date: Thu, 20 Dec 2018 18:06:39 +0100 Message-Id: X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v1 0/8] Clean up rte_option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Dec 2018 17:07:15 -0000 rte_option lib might benefit from a few improvements. Overview: - list registered options on /rte/app --help - check duplicates within base EAL options - rename some fields to be closer to standard struct option and just cleaner overall. - fix some strange code (static iterator?) - fix doc, improve API a little... Gaetan Rivet (8): option: use bare option string as name option: do not use static iterator option: add usage string option: rename name field option: check against common option on register option: fix log level of error in register option: improve library documentation option: return an error when register fail lib/librte_eal/common/eal_common_options.c | 1 + lib/librte_eal/common/eal_private.h | 7 +++ lib/librte_eal/common/include/rte_option.h | 17 +++++-- lib/librte_eal/common/rte_option.c | 57 +++++++++++++++++++--- lib/librte_telemetry/rte_telemetry.c | 3 +- 5 files changed, 72 insertions(+), 13 deletions(-) -- 2.19.1