From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 75EC81B522 for ; Wed, 20 Jun 2018 17:10:21 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Jun 2018 08:10:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,247,1526367600"; d="scan'208";a="68572583" Received: from dhunt5-mobl2.ger.corp.intel.com (HELO [10.237.221.44]) ([10.237.221.44]) by orsmga002.jf.intel.com with ESMTP; 20 Jun 2018 08:10:15 -0700 To: Ferruh Yigit , Declan Doherty , Chas Williams , Bruce Richardson , Harry van Haaren , Cristian Dumitrescu , Konstantin Ananyev , Remy Horton , Ori Kam , Pablo de Lara , Radu Nicolau , Akhil Goyal , Tomasz Kantecki , Anatoly Burakov , John McNamara , Jijiang Liu Cc: dev@dpdk.org, Liang Ma , Xueming Li References: <20180620150122.45945-1-ferruh.yigit@intel.com> From: "Hunt, David" Message-ID: Date: Wed, 20 Jun 2018 16:11:50 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180620150122.45945-1-ferruh.yigit@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH] examples: fix RSS hash function configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jun 2018 15:10:22 -0000 Hi Ferruh, On 20/6/2018 4:01 PM, Ferruh Yigit wrote: > ethdev layer introduced checks for application requested RSS hash > functions and returns error for ones unsupported by hardware > > This check breaks some sample applications which blindly configures > RSS hash functions without checking underlying hardware support. > > Updated examples to mask out unsupported RSS has functions during device > configuration. > Prints a log if configuration values updated by this check. > > Fixes: aa1a6d87f15d ("ethdev: force RSS offload rules again") > > Signed-off-by: Ferruh Yigit > --- > Return error added in this release, so no need to backport the fix to > previous versions. > > Cc: David Hunt > Cc: Liang Ma > Cc: Xueming Li > --- > examples/bond/main.c | 12 ++++++++++ > examples/distributor/main.c | 11 ++++++++++ > examples/eventdev_pipeline/main.c | 11 ++++++++++ > examples/ip_pipeline/link.c | 8 +++++-- > examples/ip_reassembly/main.c | 12 ++++++++++ > examples/ipsec-secgw/ipsec-secgw.c | 12 ++++++++++ > examples/l3fwd-acl/main.c | 12 ++++++++++ > examples/l3fwd-power/main.c | 14 ++++++++++-- > examples/l3fwd-vf/main.c | 12 ++++++++++ > examples/l3fwd/main.c | 12 ++++++++++ > examples/load_balancer/init.c | 12 ++++++++++ > examples/multi_process/symmetric_mp/main.c | 12 ++++++++++ > .../performance-thread/l3fwd-thread/main.c | 12 ++++++++++ > examples/qos_meter/main.c | 22 +++++++++++++++++++ > examples/vmdq_dcb/main.c | 13 +++++++++++ > 15 files changed, 183 insertions(+), 4 deletions(-) > > --snip-- I tested distributor_app, l3-fwd and l3-fwd-power, they all started OK, giving the additional message that some flags were not available on my hardware. Looks good. Regards, Dave.