From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 04C0A425A5; Fri, 15 Sep 2023 15:49:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7E69540295; Fri, 15 Sep 2023 15:49:30 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2061.outbound.protection.outlook.com [40.107.92.61]) by mails.dpdk.org (Postfix) with ESMTP id 8D08D40041 for ; Fri, 15 Sep 2023 15:49:29 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PqNjwdOVgNaZd9Qxl3IoX2YDWWq/pvCn4t6BFzvSWzQXA51jBRIiBr0FH0Z0bsVxu5EAiLkOCd9H4cs/ozeOJ3HRBV1aERyPxYSI5U2CuFRZQWIzEZVQOXEvyEkr7TOPEeOafdY2uU99NUEeFcReiDYIrEFLFFMRyapOxO7xU8yPIQyMFZvV0cQmp9zipRpR0zUb9tW0+DTC8cC8MS5zCLndqc05ICgqZaIJPv02JkPPTnljvxtb7R9cPft7ATaq3N6rHGPHLrshZblFituczFR93H8QYak3fGzP1Q4WEIeehVQ6U0GDj+omraj7vDAab3TgsmO+Km3zIH20Hj9nHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V0r40aDNhAKNgMCAE4wMZwZwFwlv1kwQlgR/4Rjpc4A=; b=k5yfaPwF6UbNgv12ru7YMOpgZEbnKYI4AnhOdpIWHLuBWh2BWk3k0gLNg17dHaKfe6VGLS4y/v2IbnAFv6rS6s66yOJ5FncS5NFxLPZAxqzDTsZt0KG+agrS5ryi9QaY9UGVtQEfYOKMAtpbTBHXM/rH0GbefgIkOkrGHM7BxYmUlM2x7kI6F8cVNTTcA3OuqplN3KZdzpuKrxR2MQZCqTDDNYOW44sHg8JVeYeyuTdErDQMeF3LTzh06cB88rVuaSAcL+y/UH54AKNAM1deBYl9YoDw9B4riy+5bGIfP99g+8v9K/MTV5FJ4RxKG7IeO+n/qZpEZP7XHxtGMttuLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V0r40aDNhAKNgMCAE4wMZwZwFwlv1kwQlgR/4Rjpc4A=; b=kEUEK2RksYDqXJagrZkF5w6QqeKTiAqDKxTTDLsDz6bfJhoD5B4CXah1peNOT+m57isB31zj/On/M7s3bbiO3orKqXVs+yDakCA6qxSa+b6UTuWKhUoh1/cFx+0vqZ+X8Vt7qeg6m1Sos5lj00oWTVE5/oJzTL1eAUCo6ykxKZU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SN7PR12MB8820.namprd12.prod.outlook.com (2603:10b6:806:341::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.20; Fri, 15 Sep 2023 13:49:26 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8%4]) with mapi id 15.20.6792.021; Fri, 15 Sep 2023 13:49:26 +0000 Message-ID: Date: Fri, 15 Sep 2023 14:49:20 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 00/27] refact the nfpcore module Content-Language: en-US To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com References: <20230830021457.2064750-1-chaoyong.he@corigine.com> <20230915091551.1459606-1-chaoyong.he@corigine.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJjb9DJBQkC+3/YAAoJEFRTPtCK Km/6d94P/irGq3mPa7LamXMIioQ8i6ppMSjpr8g+SxH9RnzbmoUjUY6hVzCpXYxEejiJHubg 7lwD+bOocYpiU8Pe0UncVBhIPNk/dIWQAyH0IWK1nd+hOnjxHv3AQpP80Be2o1mUn3oq/b+B QYiyvvre2gIugYq0hzLcG7z4zREeT+Nl0DMDfnLx+Tj2FAOHrOfudUqjdr/VjF5PoTK0bxnb Brqulp0I0ft7hNsufhzf+TlqaB5l0eQO4gDo5xGTP97TT1cGYsXVMsyDhHqW6P3cuj8kkLkO Ch4oq8OLL8GElgRy5y5svU6CJu3f8hT9aiqIoaRpfNv6N8iEk6g4/HNN+uydb9YCA+1pbwBx skmDhtxQrmXpI+Fmfq0aX2NmqHcy6JR8Ekm/nfwLAW/aDpwoMImVN5pPXtOBSjYi4pj7hiJk UA0ZFi8HCW+fic85p8MXn1GPDmbO82Mm3JVJ1uJNAzGsBbW5SP1ol6+XTeaSxcmzFlrDs8vL XQJMRTpcG6Pti7GbbsOtldvmxRQpq9PmCgQg9IrPXpMoaKE3WwtiSiCALs0kYj4F+hhgAfjI RsOuaAJTnKYW31pC/QdroMNAEqIpLveql03jj+xD9ntJIVAsXiCitsLIXzKP0L5tcHkoVLC3 NAjVYq6XkAEssPF4mMRLoEwpvxOytHe1BCJoRl0YA0aQzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmNv0PAFCQL7f/8ACgkQVFM+0Ioqb/oU9hAAisAJJ09j/kiEeA1HGKUg3DyFnYW22zRL z1IHYmcHQanMx4+FAwsb1bonVldQMIYNJ9z69UNIU16zIqLZt3D5QK7Je5F5q4NZgfP2jtjX rc3jyu0PuDerFZQyxNcYhhmlF9JO9NV976WYbBAM3AAr0TDohUk+YicYTKab+ZHYOABXbqHX qi+bzDCH1vKBDfpJviprthhK1tIABUK5lsp9aFwFU2jfu2J3XX3pwQhPMjtn2C4v37XUnOqM SJPr2HLU27IW5I3BBpJn7dZE/BkmDmnceHF8E4tRlXCQ/cf81+eErL832sfhVJo1MpubKh3B j89ZLmw0cDXZP2hqlC9vdXnoWWHI8PDPkiw9z11yLrT9Wd4cTJTjFV49Z9G96rgnOtWDcZ1J xHBAnXYQ7V2k9abY+ZqY1PtAPr/smqzQfPHXyTAhRVZp2f3yQmj7UqB07FJuLQjJ4CGk97Qx ///qeSg7D8x/sGEA8Yp2jgIj6u7tspuz+RgBYrWpfI0VIHhWED0jNXzqztrVX18CzA6r0ReY SG+CSyycKkco6UI9ZeUrXFwnoUJqIJY9wTJo5gD9EgGIbItv3qWTq29dihLYpzd6dqB708k7 4RBz9051oLaFVGkguFw/tXmA17nx+c2uR5jx8wb4j68umG2X++0dSta5eHAVhmtXvrqPW6Ku 3FQ= In-Reply-To: <20230915091551.1459606-1-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO0P123CA0012.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:354::20) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SN7PR12MB8820:EE_ X-MS-Office365-Filtering-Correlation-Id: ef7f40bc-6133-4c19-e853-08dbb5f2935d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PqycWXsacEeJm7J1F44Mcr62Lih8cSX8W/teWLr32LFPQd9uxalQyGURwGoQ6FL03fEQjE34vlOx/ZuMDbxLFl8RbSCzvqPSXaFX4K1rAAqR5pW4zag9SgOW8ZiBpL7a0zLUMdULMzt2hbOqlSNuxYyZQc1t/PknpCYdjk4SvVhbgZTU1Yk7KjkUzT98IV4iALlprIsVssjPi6lGFUEkIeq9GU92soHGygj2JWMBTFtKV1enUX0okMUdCVTrDsA0uvkUqXbClfPLYJhGBjd44yDYbSpdyuLE23gTVORSuMV24tIRORKnHNvuTGZKryDYAWVRCkm/Cf5rip8nniKT6vU0bWU8KuKLvw3a0PsUTahCzEO2EIwcnpR+UjFmbapdB5jAZT/RcN+el5xuK+eB238MYzGqciSI1f1udwYcJjg449bbxdGgFiuv6LjUfjIvfd/9j/Ii/lqHI0yIlRMQoxB6SktmxpcDq8s868mkLcIwiAdqcMBjH2K53HaE6d7ph4lxJiWs8WxTlsmewmQkkfOnXvtrrdMDks8oLgRG7NgQzcIxdisU3tnci8bAS8vx+ns83qtiW1hKZsisSlfsDKDJsPGEtxBZ47GNOt/4Q0S91RtvUCHCYJmJtAFe/NYBrdFc693TYkPT3xHQIF0pHw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(136003)(366004)(39860400002)(396003)(346002)(451199024)(1800799009)(186009)(26005)(2616005)(478600001)(6666004)(6512007)(2906002)(6506007)(6486002)(53546011)(31696002)(86362001)(5660300002)(8676002)(4326008)(8936002)(36756003)(41300700001)(66556008)(66946007)(66476007)(316002)(31686004)(44832011)(38100700002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b1F6aG8yWXBUaDl4bkVUZnpWRHFGT08rYjFhYTBjcEtseVhKRVd3czlnTlJO?= =?utf-8?B?MXNlOTdSbk90Sng1L3pkOFo0MlNaTHhkcHY4STRCR0RRZjlGUXlQY0V6UWQ3?= =?utf-8?B?YXEvVWFTQTl5VlpXSDV1cGE2NUM2eDd6anhsZEZMVnhTSnZqOC9wWTFKRSs1?= =?utf-8?B?aDhlZlZmTnBjcVo1V2gzQXcvQXgvMXRuZE1EZzNaTG5CWFoyN1prZUNwNWtF?= =?utf-8?B?QUQ5QTh1K3FiVmEyQW5jYjlja3Z5OWFYQ3pRZGU1cndEZlVXSFR2aDJZUDI1?= =?utf-8?B?dzg0TGFTUFNsQVM4d2ZUUzViN1djUmxBNC9VQVNpK3RpMzdtcU9EWVFGV1hM?= =?utf-8?B?N1pmVlBEYzZSRm1VVVZta2RWcXE3aWY2cFdBMXFqdDJkMzlUbUxmZ3c2V01j?= =?utf-8?B?VWl0bXdKSmUxS2d3OUszM1ZzK3MzSjdIcUhsY2swb29BSnoxZk43VkxjRldQ?= =?utf-8?B?aE4rbDcrOE53RXVRSFhtSkpTZ3JCMVpYdTd1SEFyRTFheEJkVGlMb2lkNVBQ?= =?utf-8?B?bVFpT0U5WnVFd0NDQlNUV3M0SXZKdm9GYXVSRkN2WGplV3hNdUM4cnhGbksw?= =?utf-8?B?YUxodE0xMFJlKzArVVhHdVNoUnlRWHJ5SlEyMWVHcmpZLzRLMXNpQ2FoMXVn?= =?utf-8?B?YXNMNHZTSXNDZHJNaVlyUmRnSjdrMlB4WUYvbUl1UllDWnZHeHc3QzRIU3dw?= =?utf-8?B?NWs4cjNDRHlLU1E1YTdrMFJVbm11VFZIZWZHNDlZVGtDcFVRZnNwV2dISkhB?= =?utf-8?B?a0FUNkJZR2NZcGd6NDJSTW1CUGI3OUdHZldrcDcyU3RuYjlIZ1gvVEs1TWs2?= =?utf-8?B?Rk5MbXZLV0ZVdnl2RWRPazR2emNzK1FnbUROVVJ4TWFiRGMvaTVKcG5Ub3NP?= =?utf-8?B?b1FKUXJlNWhNcmYrd2pIeUtoSUFPODJvdlJ5d0V0M1Z6NjlrcDdSV1VLUURO?= =?utf-8?B?VWFYQ1JFOEJDbHZxNllBcHQ0RFNVSXlibVQ5WHc2Y21UVkJLRE1vL2phU3ND?= =?utf-8?B?cktSUFl3aldMekJIdk1qeGxYWHBQRmx5QUhBZk1tZzVJUEhZeVlMUS9ZV1lU?= =?utf-8?B?dEJ3VUs0Tk9BdExsYWtCUVRkMFNXZ1NQYmNGUkVBcGRxK0FTb0FHd3ZvdUhT?= =?utf-8?B?TTF4K0c5S0F0cFpJemRCZlRIaWtTa1hUa2lUd0dZZ3F4SEFwVnpKbEpQZXdK?= =?utf-8?B?ZlBlbVgxSm1UWGMzZzlIVE9ZMWxid0h3dUZEWjI5Q1BkM3lubEhOSUhZc2I5?= =?utf-8?B?VnA3enZ3WE9qZUpZdXZvR2lDcFNjZzAvcG45endhUU1iQWJOZGxiL1VjWCtY?= =?utf-8?B?Wm1XL0V6UHVGTVB4RnlUSGNqKzhwdG5sdCt1am55akdGTDlSdUJna2o3NmVF?= =?utf-8?B?M0hEQ0RTbVNFMENRWE1ycXdBaGt4SEFiZEN5QTRBYnd2U1owTzRQSEpQaElH?= =?utf-8?B?S3ZRM3hTSEcxVnlwbXZWbmZLSDNDd1pXMlJaU1dzU050VXpHUkVzNmJscTc5?= =?utf-8?B?NVdNQjZmVVZYSDQybk05MTU5VzM1MzdESmRVSUs5WHpSZlp4ZWVVYkljVXg3?= =?utf-8?B?emtRMUhscGpqZ2Q0RjVkT3dXNzc1QXEwWnc2NGd3U2dMUy94bjR3MkZKaG5q?= =?utf-8?B?M0JPRk96TmRkWWtFUENJd1AyVEhJbnIxdzNFWk03ckNuaUV3R0sxMXpCdHJt?= =?utf-8?B?RUZqd29QVlJoaS9VMGVRWmt3Y09QU3FpWUxRUlMzU0FlVnFhdzl2MCtsM3ZX?= =?utf-8?B?Q0dsQUhZSGZ2RG1ZUGZuZ1o0RFhJb25DYUYyS3I5cWU5ZGlRbTBPeGN0cHZQ?= =?utf-8?B?ZWdMK2lwTm1SWEt5Sm5mNzc1eUE1UENqM1haL29LQjA2VTVZdVFzQW0wMWhF?= =?utf-8?B?N2FOVGxFMlhNNGlGU2gvdDhxVWFqQjVyU3czb250eHUrTzR3Y3J3elNGYkJD?= =?utf-8?B?Qk5wb0VJRzkweG9Bc1paQ3FNVnVHbEd5cHhUZ2VyQXVyYlkzWWxPY0ZrU1ZQ?= =?utf-8?B?UVBHSUJuQUZrWmZrUklQdnh3bUUxSitTUmhkbm1OZlorZjB5SkZQcjBaZWo0?= =?utf-8?B?SjArUnJmSk5PS2Y0ZlZiK0NZK3BpQytLWTAzUUY5NjAwZVlRbDZZVlJacExx?= =?utf-8?Q?yLqOVXugykTptZyffpiXHsNFm?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: ef7f40bc-6133-4c19-e853-08dbb5f2935d X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2023 13:49:26.3994 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iFeqMqsoIm9kbU9PCJUGz6RiRvXcm9g3yH8p/kudwVtu5a8jmwE3uT1iP3dCSwFk X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB8820 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/15/2023 10:15 AM, Chaoyong He wrote: > This patch series aims to: > - Make the coding style satisfy with DPDK. > - Sync the logic with kernel driver. > - Make the sub-module more modular. > - Extend the nfp configure BAR from 8 to 24. > > --- > v3: > * Fix one bug in the BAR find logic. > * Modify more coding style. > v2: > * Fix the compile error in Fodora 37 environment. > --- > > Chaoyong He (27): > net/nfp: explicitly compare to null and 0 > net/nfp: unify the indent coding style > net/nfp: unify the type of integer variable > net/nfp: remove the unneeded logic > net/nfp: standard the local variable coding style > net/nfp: adjust the log statement > net/nfp: standard the comment style > net/nfp: using the DPDK memory management API > net/nfp: standard the blank character > net/nfp: unify the guide line of header file > net/nfp: rename some parameter and variable > net/nfp: refact the hwinfo module > net/nfp: refact the nffw module > net/nfp: refact the mip module > net/nfp: refact the rtsym module > net/nfp: refact the resource module > net/nfp: refact the target module > net/nfp: add a new header file > net/nfp: refact the nsp module > net/nfp: refact the mutex module > net/nfp: rename data field to sync with kernel driver > net/nfp: add the dev module > net/nfp: add header file for PCIe module > net/nfp: refact the cppcore module > net/nfp: refact the PCIe module > net/nfp: refact the cppcore and PCIe module > net/nfp: extend the usage of nfp BAR from 8 to 24 > Hi Chaoyong, Niklas, I put some comments on patches, mostly minor comments, only critical one is the decision to use rte memory management widely or not, please check comments.