From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id C4AAD201 for ; Fri, 5 Oct 2018 14:20:47 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Oct 2018 05:20:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,344,1534834800"; d="scan'208";a="94890956" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.252.17.112]) ([10.252.17.112]) by fmsmga004.fm.intel.com with ESMTP; 05 Oct 2018 05:20:46 -0700 To: Alejandro Lucero Cc: dev References: <1538741212-7922-1-git-send-email-alejandro.lucero@netronome.com> <1538741212-7922-2-git-send-email-alejandro.lucero@netronome.com> From: "Burakov, Anatoly" Message-ID: Date: Fri, 5 Oct 2018 13:20:45 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 1/6] mem: add function for checking memsegs IOVAs addresses X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Oct 2018 12:20:48 -0000 On 05-Oct-18 1:19 PM, Alejandro Lucero wrote: > > > On Fri, Oct 5, 2018 at 1:15 PM Burakov, Anatoly > > wrote: > > On 05-Oct-18 1:06 PM, Alejandro Lucero wrote: > > A device can suffer addressing limitations. This function checks > > memsegs have iovas within the supported range based on dma mask. > > > > PMDs should use this function during initialization if device > > suffers addressing limitations, returning an error if this function > > returns memsegs out of range. > > > > Another usage is for emulated IOMMU hardware with addressing > > limitations. > > > > It is necessary to save the most restricted dma mask for checking out > > memory allocated dynamically after initialization. > > > > Signed-off-by: Alejandro Lucero > > > --- > > Reviewed-by: Anatoly Burakov > > > > Thanks Anatoly. > > I have just noticed I did not remove the previous keeping of the dma mask. > > I will send another version just with this change and will add you > review if you are happy if I do so. > Sure :) -- Thanks, Anatoly