From: Ranjit Menon <ranjit.menon@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
Pallavi Kadam <pallavi.kadam@intel.com>
Cc: dev@dpdk.org, thomas@monjalon.net, John.Alexander@datapath.co.uk,
dmitry.kozliuk@gmail.com, Narcisa.Vasile@microsoft.com,
talshn@nvidia.com
Subject: Re: [dpdk-dev] [PATCH v2] bus/pci: netuio interface for windows
Date: Wed, 16 Sep 2020 17:48:36 -0700 [thread overview]
Message-ID: <d04d7b18-188e-2a56-6055-c300920f6de6@intel.com> (raw)
In-Reply-To: <20200915185409.7af0f626@hermes.lan>
Hi, Stephen
On 9/15/2020 6:54 PM, Stephen Hemminger wrote:
> On Tue, 15 Sep 2020 16:28:03 -0700
> Pallavi Kadam <pallavi.kadam@intel.com> wrote:
>
>> + if (IsEqualGUID((const void *)&(device_info_data->ClassGuid),
>> + (const void *)&GUID_DEVCLASS_NETUIO))
> Is there anyway to get rid of casts and have the right types?
> Casts are evil
Unfortunately, this macro is defined inside the Windows SDK and it
simply calls the C library function memcmp() which expects a (void *).
Would something like this be acceptable?
const void *guid = &(device_info_data->ClassGuid);
const void *guid_netuio = &GUID_DEVCLASS_NETUIO;
if (IsEqualGUID(guid, guid_netuio)
....
ranjit m.
next prev parent reply other threads:[~2020-09-17 0:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 1:59 [dpdk-dev] [PATCH] " Pallavi Kadam
2020-09-13 18:42 ` Tal Shnaiderman
2020-09-15 20:13 ` Ranjit Menon
2020-09-15 23:28 ` [dpdk-dev] [PATCH v2] " Pallavi Kadam
2020-09-16 1:54 ` Stephen Hemminger
2020-09-17 0:48 ` Ranjit Menon [this message]
2020-09-17 1:20 ` Ranjit Menon
2020-09-21 21:08 ` [dpdk-dev] [PATCH v3] " Pallavi Kadam
2020-09-22 3:05 ` [dpdk-dev] [PATCH v4] " Pallavi Kadam
2020-09-25 1:53 ` [dpdk-dev] [PATCH v5] " Pallavi Kadam
2020-09-29 8:28 ` Tal Shnaiderman
2020-09-29 17:29 ` Ranjit Menon
2020-09-30 7:58 ` Tal Shnaiderman
2020-10-06 23:31 ` Kadam, Pallavi
2020-10-06 21:57 ` [dpdk-dev] [PATCH v6] " Pallavi Kadam
2020-10-08 17:46 ` Tal Shnaiderman
2020-10-08 18:56 ` [dpdk-dev] [PATCH v7] " Pallavi Kadam
2020-10-08 21:50 ` Tal Shnaiderman
2020-10-09 2:12 ` Narcisa Ana Maria Vasile
2020-10-14 20:27 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d04d7b18-188e-2a56-6055-c300920f6de6@intel.com \
--to=ranjit.menon@intel.com \
--cc=John.Alexander@datapath.co.uk \
--cc=Narcisa.Vasile@microsoft.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=pallavi.kadam@intel.com \
--cc=stephen@networkplumber.org \
--cc=talshn@nvidia.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).