From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>, dev@dpdk.org
Cc: hujiayu.hu@foxmail.com, roretzla@linux.microsoft.com,
bruce.richardson@intel.com, anatoly.burakov@intel.com,
vladimir.medvedkin@intel.com,
Konstantin Ananyev <konstantin.ananyev@huawei.com>,
stable@dpdk.org, kumaraparamesh92@gmail.com
Subject: Re: [RFC 1/4] gro: fix overwrite unprocessed packets
Date: Wed, 12 Jun 2024 01:48:03 +0100 [thread overview]
Message-ID: <d065e1e6-1c06-4357-9417-46130d66fff2@amd.com> (raw)
In-Reply-To: <20240523162604.2600-2-konstantin.v.ananyev@yandex.ru>
On 5/23/2024 5:26 PM, Konstantin Ananyev wrote:
> From: Konstantin Ananyev <konstantin.ananyev@huawei.com>
>
> gro_vxlan_tcp4_tbl_timeout_flush() is called without taking into account
> that first entries in pkts[] can be already occupied by
> un-processed packets.
>
> Fixes: 74080d7dcf31 ("gro: support IPv6 for TCP")
> Cc: stable@dpdk.org
>
> Signed-off-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>
> ---
> lib/gro/rte_gro.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/gro/rte_gro.c b/lib/gro/rte_gro.c
> index d824eebd93..db86117609 100644
> --- a/lib/gro/rte_gro.c
> +++ b/lib/gro/rte_gro.c
> @@ -327,7 +327,7 @@ rte_gro_reassemble_burst(struct rte_mbuf **pkts,
> /* Flush all packets from the tables */
> if (do_vxlan_tcp_gro) {
> i += gro_vxlan_tcp4_tbl_timeout_flush(&vxlan_tcp_tbl,
> - 0, pkts, nb_pkts);
> + 0, &pkts[i], nb_pkts - i);
> }
>
> if (do_vxlan_udp_gro) {
Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
next prev parent reply other threads:[~2024-06-12 0:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-23 16:26 [RFC 0/4] remove use of VLA Konstantin Ananyev
2024-05-23 16:26 ` [RFC 1/4] gro: fix overwrite unprocessed packets Konstantin Ananyev
2024-06-12 0:48 ` Ferruh Yigit [this message]
2024-05-23 16:26 ` [RFC 2/4] gro: remove use of VLAs Konstantin Ananyev
2024-06-12 0:48 ` Ferruh Yigit
2024-06-13 10:20 ` Konstantin Ananyev
2024-06-14 15:11 ` Ferruh Yigit
2024-06-28 12:57 ` Konstantin Ananyev
2024-05-23 16:26 ` [RFC 3/4] net/ixgbe: " Konstantin Ananyev
2024-06-12 1:00 ` Ferruh Yigit
2024-05-23 16:26 ` [RFC 4/4] net/ice: " Konstantin Ananyev
2024-06-12 1:12 ` Ferruh Yigit
2024-06-13 10:32 ` Konstantin Ananyev
2024-06-14 15:31 ` Ferruh Yigit
2024-06-12 1:14 ` [RFC 0/4] remove use of VLA Ferruh Yigit
2024-06-13 10:43 ` Konstantin Ananyev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d065e1e6-1c06-4357-9417-46130d66fff2@amd.com \
--to=ferruh.yigit@amd.com \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=hujiayu.hu@foxmail.com \
--cc=konstantin.ananyev@huawei.com \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=kumaraparamesh92@gmail.com \
--cc=roretzla@linux.microsoft.com \
--cc=stable@dpdk.org \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).