From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5966845645; Thu, 18 Jul 2024 14:35:17 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 451E3402D8; Thu, 18 Jul 2024 14:35:17 +0200 (CEST) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id DF827402D5 for ; Thu, 18 Jul 2024 14:35:15 +0200 (CEST) Received: from mail.maildlp.com (unknown [172.19.163.48]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4WPsb943WvzyN4g; Thu, 18 Jul 2024 20:30:29 +0800 (CST) Received: from kwepemm600004.china.huawei.com (unknown [7.193.23.242]) by mail.maildlp.com (Postfix) with ESMTPS id 9852918005F; Thu, 18 Jul 2024 20:35:13 +0800 (CST) Received: from [10.67.121.59] (10.67.121.59) by kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 18 Jul 2024 20:35:12 +0800 Message-ID: Date: Thu, 18 Jul 2024 20:35:12 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v2 0/3] bugfix about KEEP CRC offload To: Jie Hai , , , , , CC: , References: <20240206011030.2007689-1-haijie1@huawei.com> <20240718114806.577298-1-haijie1@huawei.com> From: "lihuisong (C)" In-Reply-To: <20240718114806.577298-1-haijie1@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.121.59] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemm600004.china.huawei.com (7.193.23.242) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org For series. Acked-by: Huisong Li 在 2024/7/18 19:48, Jie Hai 写道: > From: Dengdui Huang > > For hns3 NIC, when KEEP_CRC offload is enabled, the CRC data is still be stripped in rare scenarios. > Some users of hns3 are already using this feature. So driver has to recaculate packet CRC. > > In addition, in the mbuf, the data that exceeds the length specified by pkt_len is invalid. > Therefore, if the packet contains CRC data, pkt_len should contain the CRC data length. > However, almost of drivers supported KEEP CRC feature didn't add the CRC data length to pkt_len. > This patch adds description for KEEP CRC offload. > > Dengdui Huang (3): > ethdev: add description for KEEP CRC offload > net/hns3: fix packet length do not contain CRC data length > net/hns3: fix Rx packet without CRC data > > drivers/net/hns3/hns3_ethdev.c | 5 + > drivers/net/hns3/hns3_ethdev.h | 23 +++++ > drivers/net/hns3/hns3_rxtx.c | 134 ++++++++++++++++---------- > drivers/net/hns3/hns3_rxtx.h | 3 + > drivers/net/hns3/hns3_rxtx_vec.c | 3 +- > drivers/net/hns3/hns3_rxtx_vec_neon.h | 19 ---- > drivers/net/hns3/hns3_rxtx_vec_sve.c | 3 +- > lib/ethdev/rte_ethdev.h | 6 ++ > 8 files changed, 124 insertions(+), 72 deletions(-) >