From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by dpdk.org (Postfix) with ESMTP id E749C2C18;
 Wed,  7 Mar 2018 14:17:54 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga004.jf.intel.com ([10.7.209.38])
 by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 07 Mar 2018 05:17:53 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.47,435,1515484800"; d="scan'208";a="180657116"
Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.62])
 ([10.237.221.62])
 by orsmga004.jf.intel.com with ESMTP; 07 Mar 2018 05:17:51 -0800
To: "Patil, Harish" <Harish.Patil@cavium.com>,
 Pascal Mazon <pascal.mazon@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>,
 "Mody, Rasesh" <Rasesh.Mody@cavium.com>,
 "Shaikh, Shahed" <Shahed.Shaikh@cavium.com>
Cc: "stable@dpdk.org" <stable@dpdk.org>
References: <cef0a87d69a78f57c938a099a85041d3b612d7b3.1519390269.git.pascal.mazon@6wind.com>
 <556c05beb248ea48331fe9ae3daa3a1260b7ffec.1519631456.git.pascal.mazon@6wind.com>
 <D6B99406.1B25DC%Harish.Patil@cavium.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <d0743950-8309-5aec-0c69-503092fbc7a6@intel.com>
Date: Wed, 7 Mar 2018 13:17:50 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <D6B99406.1B25DC%Harish.Patil@cavium.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2] net/qede: fix alloc from socket 0
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Mar 2018 13:17:56 -0000

On 2/26/2018 6:38 PM, Patil, Harish wrote:
> -----Original Message-----
> From: Pascal Mazon <pascal.mazon@6wind.com>
> Date: Monday, February 26, 2018 at 12:01 AM
> To: "dev@dpdk.org" <dev@dpdk.org>, "Mody, Rasesh"
> <Rasesh.Mody@cavium.com>, Harish Patil <Harish.Patil@cavium.com>, "Shaikh,
> Shahed" <Shahed.Shaikh@cavium.com>
> Cc: "pascal.mazon@6wind.com" <pascal.mazon@6wind.com>, "stable@dpdk.org"
> <stable@dpdk.org>
> Subject: [PATCH v2] net/qede: fix alloc from socket 0
> 
>> In case osal_dma_alloc_coherent() or osal_dma_alloc_coherent_aligned() are
>> called from a management thread, core_id turn out to be LCORE_ID_ANY, and
>> the resulting socket for alloc will be socket 0.
>>
>> This is not desirable when using a NIC from socket 1 which might very
>> likely be configured to use memory from that socket only.
>> In that case, allocation will fail.
>>
>> To address this, use master lcore instead when called from mgmt thread.
>> The associated socket should have memory available.
>>
>> Fixes: ec94dbc57362 ("qede: add base driver")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Pascal Mazon <pascal.mazon@6wind.com>
>> Acked-by: Harish Patil <harish.patil@cavium.com>

> Acked-by: Harish Patil <harish.patil@cavium.com>

Applied to dpdk-next-net/master, thanks.