DPDK patches and discussions
 help / color / mirror / Atom feed
From: Chengchang Tang <tangchengchang@huawei.com>
To: Thomas Monjalon <thomas@monjalon.net>,
	Ferruh Yigit <ferruh.yigit@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, <linuxarm@openeuler.org>
Subject: [dpdk-dev] [Question about 'rte_eth_tx_prepare']
Date: Mon, 8 Feb 2021 14:29:49 +0800	[thread overview]
Message-ID: <d0a0f70d-c9ce-01a0-d5e5-593b255f8f20@huawei.com> (raw)

Hi, Thomas Monjalon and Ferruh Yigit and others.

I have some questions about 'rte_eth_tx_prepare'.

When I use TSO offload in bond mode, the checksum error occurs. It is
because the bond PMD does not implement 'tx_prepare'. So, it will not
invoke the 'tx_prepare' of each PMDs to do prepare for the PMDs. I am
not sure whether to add the 'tx_preapre' implementation for the bond
PMD or put the process of pseudo header in the apps.

And we are now designing the outer UDP cksum offload for HNS3 PMD.
I find that many PMDs process these pseudo headers in 'tx_prepare', but
does not process the pseudo header for outer UDP checksum offload.
Instead, it is processed in csum forward mode of testpmd. Does this mean
that the pseudo header should be completed by the apps and the apps does
not need to call 'tx_prepare' to avoid repeated processing? (it seems
not transplantable) If so, it seems that PMDs need to avoid doing this
in 'tx_prepare'.

Here are two questions:
1. What functions should be included in the 'tx_prepare' for PMDs?
2. Whether an app must invoke 'rte_eth_tx_prepare' or under which
conditions an app must invoke the 'rte_eth_tx_prepare'?

Thanks
Chengchang Tang


             reply	other threads:[~2021-02-08  6:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-08  6:29 Chengchang Tang [this message]
2021-02-08  8:07 ` Thomas Monjalon
2021-02-08  8:40   ` Olivier Matz
2021-02-09  1:13     ` Chengchang Tang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d0a0f70d-c9ce-01a0-d5e5-593b255f8f20@huawei.com \
    --to=tangchengchang@huawei.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=linuxarm@openeuler.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).