From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 30DB945694; Tue, 23 Jul 2024 13:43:54 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DC09D40151; Tue, 23 Jul 2024 13:43:53 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by mails.dpdk.org (Postfix) with ESMTP id 06E4840150 for ; Tue, 23 Jul 2024 13:40:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1721734854; x=1753270854; h=message-id:date:subject:to:cc:references:from: in-reply-to:mime-version; bh=/jG/f7Q/ZeTen/ymIGxsenjI2SsUA4+j3UQ97eKHiaE=; b=QghGarTALzQ0N2BiTtjMgdYKbTIrzvLlrP5KkVSS9ttUXhAdaJYlSx42 o9Tt4KcPZtQhiYnBO7rlaCjLhfjQVv6Zuafh3zZekkUzBIFrE3hRYkIpR Orhk+sr46st05H2mtzoqlXyQYneOVeDhURMtEm3b5piwzBQX3izgCF0oM C1+sBt1aJfW0CYmgfOT2MK7cC57t2C+D40n4gIFi6/BJJa6qVL4Ai/OaI LU/kRvV2o536/JJF3eqWMLi+oKiIM4h9NI5frVsn4jgRrwcoWjGGu84OM cTKYeYzHwNeAeI4P0DTDffZmqgxfHhfeORuPwypOOFzpgEC0M8hAHRoJo A==; X-CSE-ConnectionGUID: NmTyIxFOTlqHRtB1AO1+Qg== X-CSE-MsgGUID: I1n6y4cKTTqJx1tG0GDOAA== X-IronPort-AV: E=McAfee;i="6700,10204,11141"; a="29944148" X-IronPort-AV: E=Sophos;i="6.09,230,1716274800"; d="scan'208,217";a="29944148" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jul 2024 04:40:53 -0700 X-CSE-ConnectionGUID: RYcJZAQnQTOAlADmAfMA4w== X-CSE-MsgGUID: fO56QvphRJKJ1pDJXFj+7g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,230,1716274800"; d="scan'208,217";a="89677609" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 23 Jul 2024 04:40:53 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 23 Jul 2024 04:40:52 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 23 Jul 2024 04:40:52 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 23 Jul 2024 04:40:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gu4BwgObkmLz4J84OV9IXKqVqMxgbqX8Z1E6t9Mt0v6LrOfABhMDN7vfCJhNxnJzo7QPvckuccHiuvV/oWh41vywpb0tuBKArctbFE7KY/tuzo/qG5VZAMVvHSsCK9syvGtDATpZG+rAfAU6vrd4WLXYqt8U2uBWg0xeRUACD3hGO47f/JuBFJsGcNcaX7iePIa3SldfmQe3QK1YiPgtwnaPhBFJJOYEegkgyubtuRMQrFDg0I4RJf7u5f+YkLupedH3CcBOjZ3nPm0WKOrUN3l6tUlhQU5ge38wAfLenYHX7gOrjzJPa3xn4zpqzvF9OYL5N+g7usTL5PlY2GxzTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GaGg2RBnmFAY9v4eOHgzRG9A1w7XotFhaISt1dZrFxQ=; b=yfCrm4PkcOiHNH4qOn+fFX4+cnVbX9AA1sLiZfNPvPVUJHWDcsFxhKBoWUmSuwaBn1cZlyKoo3CNyCT+MpMn3B8Pwpr30zC5tQyLCDSmdTq8k5/nQadSPvOnsIF6Syu2QiPKRBVfJCTRADhjg7ZOzFnlg3ENhjdp6FPWFKiaUN5DCSt2/PoeJM2VQ77bXlDkWVVdfkYtl13xMKZITdPZ0iLPjnOzdZKExbGdyHwmOWa2pPOKxN78MrwyRCW9veZ3kdfOVJOAf9B+4JgAc0UXLPVVT7I3TZtMsu1AryPYmUOhegWDItkHaXe77qvxf4urFqfjVrvuh/dNGlzQgh3hPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from LV3PR11MB8579.namprd11.prod.outlook.com (2603:10b6:408:1b6::7) by SJ2PR11MB8470.namprd11.prod.outlook.com (2603:10b6:a03:56f::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.17; Tue, 23 Jul 2024 11:40:44 +0000 Received: from LV3PR11MB8579.namprd11.prod.outlook.com ([fe80::ec3c:7b9a:2442:1ce4]) by LV3PR11MB8579.namprd11.prod.outlook.com ([fe80::ec3c:7b9a:2442:1ce4%4]) with mapi id 15.20.7784.016; Tue, 23 Jul 2024 11:40:44 +0000 Content-Type: multipart/alternative; boundary="------------8l8KbbppxiPZpAvnNiFQRNMY" Message-ID: Date: Tue, 23 Jul 2024 12:40:40 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] power: fix number of uncore freqs To: Stephen Hemminger , CC: Anatoly Burakov , Sivaprasad Tummala , Tadhg Kearney References: <20240721021806.67465-1-stephen@networkplumber.org> <20240722201535.12522-1-stephen@networkplumber.org> Content-Language: en-US From: "Hunt, David" In-Reply-To: <20240722201535.12522-1-stephen@networkplumber.org> X-ClientProxiedBy: DB8P191CA0023.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:130::33) To LV3PR11MB8579.namprd11.prod.outlook.com (2603:10b6:408:1b6::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV3PR11MB8579:EE_|SJ2PR11MB8470:EE_ X-MS-Office365-Filtering-Correlation-Id: 902c0052-1414-4dcf-3680-08dcab0c4996 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?cy9LYUJLcExzd1VYMkZCUGhUS0psODRQbktvZlRtaHJsU3RjQVpxclNSYjJh?= =?utf-8?B?NmU5NjRJbGhOSTBqK0ZseEs1VW41TEx4VWVaczFRVkk0V2d1MnZBbzRTM3h3?= =?utf-8?B?YTlQb0JhNlNYVFJlYjNXbkF4MTE5OThwTHpFMGFLL0JxWndhT0FpMFlwR2ZI?= =?utf-8?B?UzZGcThPc0NHb2dpbk5LSGU4RTRuTHZweGVGUGdXVEhqczlsOW1FTklOTjAw?= =?utf-8?B?aEJUU2ZMcjdBaXJPYlFSOEtCWHc1TDlRUDVQM1FIcDQ5MnVNcHpBQUVyNkNq?= =?utf-8?B?dUxEaHJyRW02RFBXd3hBZEZaM1k2aEJzd1ZNUkZCSzFIMG9OMG9CNlNaczFw?= =?utf-8?B?ZXpqdUxIK2hqTWx1M1AxM1lRems4V2dOVWQxVUZrL1M3aU9oRXV3bkJrdlNC?= =?utf-8?B?VlVsajcwWVRrSEZGQXBQTk1rRmhmQVZIQ205bGY4NFVORDZaVThwVFZiRUFL?= =?utf-8?B?REJ6ek04cUIvcExCQ1JmelAzRlpuWHY4UDYxdm9Jc1dHN1NQRWd3K1RUcjNM?= =?utf-8?B?cTdaS1U1YmllTW91SFR4VlVsQjNyWWVhWmJxNThkTmo2d3RMeGozdTNzZ0c3?= =?utf-8?B?ZHFXN2cvbGVkK0llMmhLQkZSZ2ZwbzdPMXI4UFhURVRMSG83c2RpU2lYVlha?= =?utf-8?B?RWMvUUpuWDlZMm5vaDVML1FNUUV0VTlNOFFLOUNKb3dodjZkTDlYZ3B1Tnc5?= =?utf-8?B?QStLOStqK1dMZEdxODZvUnZ4bTA4OG5Mam5nQjlFUXFOVmtaTDVwTzg4OTJ1?= =?utf-8?B?ZnVyRkNwTUNTRytIekhHSkErelBoQy9BVW8ra3ptY2NKMGdrRnBaV0RmaGVJ?= =?utf-8?B?YmpWVmxQUzN0MXRyQklXZUgzVUcxNzJMcHA0dE41YzVIMERlcDgrUW4wMXZa?= =?utf-8?B?ZlBuT0hwZzQ1dlUyWGhDL1lES3Y2TmR2L01DMlhFb251RzlVTkdLTU8rV3BD?= =?utf-8?B?RitRc21pNzRSbHZoU3ludnF1MUdXNlBkditVcmh6T1Y5bmp3SXRDNCtaRmF4?= =?utf-8?B?NWFxQVBkZFh0b2c4YUEwN0dMdzBsNm5wWWYydEVEMmZyZExCMVAwR2YwZHMv?= =?utf-8?B?c2hic3QzMlAzVnpBOFZMSmtFYWdYNnBtTnNvUWdQYUVlMnRMQzZOQkNtTllj?= =?utf-8?B?VUh4MFU2KzRaS3gvdnRTcmNjWVN1YVFGeUY3Wis0cHVmaFBzT1hjQkd4L2tD?= =?utf-8?B?Yk1Sa0pIV0duZC8zZ2pyTVdSSXRBNnd4SzJlOVdTMWcvZy8rTTN1dFpnS1pZ?= =?utf-8?B?R1dFZGlRMDF6eldmdndkL3pPbDVEVzRZTUdxTTVVSngwOTFYVGp1Zmt6TEsr?= =?utf-8?B?TXR6NE9HcGI0M01NeFBxc0QvVW51R3pRODRmNXo1T3JTRU9MRDhBUU5qaVM0?= =?utf-8?B?Y2NSNHI2MEFpblhvNkRQMm1kZmxTT1paSUFyeTh3TThqd0drQmV5Z3JqaVQ4?= =?utf-8?B?TGRRaCs5QUNwUmFPanY0bURxZXZ5d1B6T0JOU29QbjdWUjM4SXhQL0d0UFBI?= =?utf-8?B?aE9nc2l0NEsxRGZnQUN1SHFMWXcyT3hyaFg1ZTQyeTl6K2poVEh2Z0QyY0xh?= =?utf-8?B?TWZ6YnQ5bFBUZ1VjN0hrUnM3WUF2VzFGOTFSbmNEdWlLOWhjcW53Vm9GQW5R?= =?utf-8?B?TjdCSUxPa3VEV2N0SlhhS0VFUGdWNk9QVjZyUVNpeDA2OUs3MG5mQkJnMUhB?= =?utf-8?B?MVlxY1FCbXMraUJnb1NKNDk1MXlDOUNPeVFrTkN4ZjVhMVpYRFNJT0JSSUZi?= =?utf-8?B?cTQ2QXpjcTAzQlFJWVJac3BHbzFZTkVlZ3VQZWJheFdCT0NORkladSsrUWZz?= =?utf-8?B?d25TOThJVFZsaHZGcnhoZz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:LV3PR11MB8579.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VTlMRy9UUlBHalJ2WnZ2UnVSM1pjUGd3azNRR2U3bDRjU2dRZDJYRDhQVW40?= =?utf-8?B?eUNhZG9DaHNKcTEwZlZOeXBZSzZFNmV0R1ZkRGtvK1pqUjM0K1lwQlJKQ2ZO?= =?utf-8?B?SFFDVFErUytsb01NTktzL0hBandRaHhyS2g3dmNwclhoempxMDhNenBWOElK?= =?utf-8?B?NFhlUUJLSWFoeU9RODB1VDBSQ0wwTStnNklBdmdEZTkvdWZZWUN3OUNEZzlJ?= =?utf-8?B?V0VUa2RVMVU2V2RWU3N3bmVvUnFsOGNOS08wemFWd2plVVR6clNUVHF1aERu?= =?utf-8?B?M1pzeitQY1hYN25pSkprL2dxSzF5bUxvWFQ1dEZBdGtlOEVYT0JKMVE4bFla?= =?utf-8?B?Qm5Xcm5CYURaTkNaam13bjY4dS9MWHNaZzg1RUhBcEc0VzBmeFJhaGxwcVZm?= =?utf-8?B?eC8xWTQ2UHZwTVZLMG9vRlRxSk1pSnV3Y2pjUzl5aHVIdUY5UEtDaWd6MFcx?= =?utf-8?B?NHhHb1NWdWdpRWZ2ZDJNcVJjZmZodlMwc2lmRlNRVk5RWkRWQ0wyY2djSGdK?= =?utf-8?B?aGRtZ2o0Z2hLdEhPZXFjcmtXR2F2UlozbExCS1Fuby9hME5naTJTS3dCQVRH?= =?utf-8?B?dEVVRGNxa2FjVms1aXJoc0RaZzBrUDB2QXZHS3pLRnlIOFhXaEprRzgyR2ZQ?= =?utf-8?B?dnhia3Z4eGZrQjJLZVoxQ3AwV0lVUzB1THAzSVV3eVBJY01CVXBicFA4Q29o?= =?utf-8?B?Nmx3dk1WNjN2UEVRRVlRRHhCbC8ySXdYeEpoQytLMGYyMEdncmQzR0hZZjFP?= =?utf-8?B?dlpGb1pFWExiTVh5aGZKMzd5TmpKanlKY0Y3QWw1T1VPK1R0Tkw2U0Q3dFRz?= =?utf-8?B?dG5BaWczNGozcTVIdCtoUWViVk5ETEFTblFvNVVKbXhZL1k1VmxlbVVHVDZ1?= =?utf-8?B?RXVDZnVQd29kNVFkWWdicWhKSUIyeVhYWExaUURiR1NaNTNscldMbkpPaHp4?= =?utf-8?B?L0JTK1F2L25ZbFE1RDdLeFc4R2wwR3RPSlJQU1U1ckNObjFqUHlBOGRsREtn?= =?utf-8?B?UVkwdVpjWTRVRTlXNE04bWhFTjY2aDNpTTZCMFQrRmdadDBqMER6VDNXU2Vo?= =?utf-8?B?djdKVWNaRmJsMVpsVmVIeFpzc1RGUWJCZlRGSEM2Q1ZWMk5EZWxHQ2EwU2ZW?= =?utf-8?B?UnhzVGtrUGhQeEwxbjh5Y0V0UVh1ZEZBcDhPaE1ocHdLYWJtOHk3MWU1UDBi?= =?utf-8?B?K1dWZ2lEaWxvTGlqVmhnclRrSVpOMEJ4eml5OW9RODZhUjJuUUQ2TWVHdVc0?= =?utf-8?B?ajJ2OFBNWVV3dU45eUFudGJQeGFUWGhPdEJja3dyQm0rNWg2K3ZyS09xYUhU?= =?utf-8?B?YXVYRnVsQ01ZUFVydnZnc1FmRWNmTlhJQlpVOWpEUkNVaWZ2UC82TkQ4NjdC?= =?utf-8?B?N05qQkMvRVhDTWNxUGY1eHZqcTd1ODlOQUVkbkkzN1NjbVo3SDdvbDR0ZXpZ?= =?utf-8?B?c0kvZzJ1VTRLMFJsOEZLbUZuSktLQkdtTEtqbEQzaEhsWmRxMGRNUEFHR0ZP?= =?utf-8?B?RjJVd2VHRUd0RGdMK0QrQmZtbjgwOE43S3JKczVBSEIybG5sZHpISW9uaUMz?= =?utf-8?B?NWFZemdxenBCUjZQNFVpTVpNQys5TmRoSlI1aGt0Tnp5cDIwNXVvSWZZWTJG?= =?utf-8?B?enZHamFySm1hQzlTMnRyMkhMS0xHMmRiSVFEVUtjaWxUeWE4YlMwM2N3d01w?= =?utf-8?B?MzNnaU5lYUpPZUc5MTYrTTdjL1pDcFBuYUVIYzRLaEdMWnpzV0RsTC9YaXpi?= =?utf-8?B?OXNNeXN0U1BNOVEyVXR6MXlXb0pwZ3hPWm9BeHJOcThQWWQ4bHh0TDJMSUVn?= =?utf-8?B?bkVOd2ltQVNsOXh2aWJKRXlPakdJcEVvOU5qbjFuSjkvR1NpeUZ3Z0taL3Jz?= =?utf-8?B?aWtMVkZnQjlud0FMdm9iYmF0VHNtbXkzSWJmc2FqdC9JNk14YkVwamtPNzBi?= =?utf-8?B?ZlBZVHB5VXpnMjVRaGJpbXJKc3ZtM2plYjcySTU5ZGoyN1BXYUxxbkFKM1VI?= =?utf-8?B?NVFTVWgveER4TU9HL0NaeWZ6Umt0cVJla25JYlVPNXBld3dFbDRHWlVZYmZS?= =?utf-8?B?RWVFRlVScC81STZRRVR4VURTeHRZN2ZmYWFjYnhaYlh4WGVHWDR6dFBEVXZi?= =?utf-8?B?b3hleUdTSzM5aGdjaGNXbDNjUUEvNmlzTTVwdllVeDAyL3VybDlhR0JUYVIv?= =?utf-8?B?Qmc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 902c0052-1414-4dcf-3680-08dcab0c4996 X-MS-Exchange-CrossTenant-AuthSource: LV3PR11MB8579.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jul 2024 11:40:44.3933 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DkXye0yFroiiVjFwkxyZfVcNEf292HmZ5+RUUQU6w+Sk4vAimX+yZAPyqSiZbaWxKsILo/ezUnG/4rtW5YXqcA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB8470 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --------------8l8KbbppxiPZpAvnNiFQRNMY Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit On 22/07/2024 21:15, Stephen Hemminger wrote: > The number of uncore frequencies was defined in three places, > and two of them were too small leading to test failures. > All places should be using RTE_MAX_UNCORE_FREQS. > > Bugzilla ID: 1499 > Fixes: 60b8a661a957 ("power: add Intel uncore frequency control") > Signed-off-by: Stephen Hemminger > --- > > v3 - restore one change lost in V2 > > app/test/test_power_intel_uncore.c | 4 +--- > lib/power/power_intel_uncore.c | 7 +++---- > 2 files changed, 4 insertions(+), 7 deletions(-) > --snip-- LGTM. Acked-by: David Hunt --------------8l8KbbppxiPZpAvnNiFQRNMY Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: 7bit


On 22/07/2024 21:15, Stephen Hemminger wrote:
The number of uncore frequencies was defined in three places,
and two of them were too small leading to test failures.
All places should be using RTE_MAX_UNCORE_FREQS.

Bugzilla ID: 1499
Fixes: 60b8a661a957 ("power: add Intel uncore frequency control")
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---

v3 - restore one change lost in V2

 app/test/test_power_intel_uncore.c | 4 +---
 lib/power/power_intel_uncore.c     | 7 +++----
 2 files changed, 4 insertions(+), 7 deletions(-)

--snip--

LGTM.

Acked-by: David Hunt <david.hunt@intel.com>

--------------8l8KbbppxiPZpAvnNiFQRNMY--