From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8E3FEA0543; Thu, 7 Jul 2022 15:12:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 17842406B4; Thu, 7 Jul 2022 15:12:08 +0200 (CEST) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2064.outbound.protection.outlook.com [40.107.101.64]) by mails.dpdk.org (Postfix) with ESMTP id 2B1814069D for ; Thu, 7 Jul 2022 15:12:06 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GfVILjVFF4hazYg+xeoc4wpiqM+NCa2UPSceqbHeAwpaNvMwE/lm7EONw7y96prUbLQOffomCFnktJLqLOHdNLb7vfGH4/DraYdv0zGP3itkmsu8ut1M/aj1BBYXfcEg8dnOF5ljO85EBkG771AJ3+7o10F+4FkCAFDz8eFrsyaP5q3SYCwn79A5PnAv91mRM+0mcjRvJ4aw+s3/nb4sk2g9yQqTcCCcs7+GGtJ9D/L8V5xZVnIL9qDuWWU8H71xgiksgd08SxLpWSIVs2TmmfJ8WGGpMjva9k3wWD72wyoWUJXlDL8kow9ndcRc3StlIyPwvzkQSDDGDq9vBQK+AA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=csSCxXLXV9SnksD2+5kyny6/0qM2GYSt3qoxqAobIkY=; b=J2gagk3NSO5nSHDVnd7PdYE9eoDshbtcBfjbsK06pb7tcAmjpszWW5829yGZcfAf88o56ki9qEQ+jxTI63lhGHOnIy5Mo7oCY+qMnEsYlo+bQtEc+0SmMgVqe8la7B5zog94LoleZHGCHavXHFKU9tiZmArBBcX/YSSWV311aAWtzbCYzVusHknBH9AWNR/7SdpdVc0flu35jdOyYiHmgcZIpsYvWOqBZFIowYCIWmOhkCwRTy/k+hAsfQnzzMnDClUi/RXB6ZSkgMuBDCGogxWnnhY8r60wb2FTTdXL5BR39nGkspTr5g1Z4KGSL465ZpGjKL3BmZNuXdu9I/fHrw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=huawei.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=csSCxXLXV9SnksD2+5kyny6/0qM2GYSt3qoxqAobIkY=; b=L2ashDLwnqTD09826nCbkri90bOfuf065UKN5M6BILwlmq1HgG3rTjaasCaAYLEvyDn6FrXri6St5RSmR/T6pCSyOD81QFuaZSonTOtwEq1l4E3ABxqtveornWnZYihbgjiCHb6AHZyVaenvrEnasZaTBwMPSfdafrEYSPpfDfg= Received: from DS7PR03CA0180.namprd03.prod.outlook.com (2603:10b6:5:3b2::35) by MN2PR02MB6237.namprd02.prod.outlook.com (2603:10b6:208:181::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Thu, 7 Jul 2022 13:12:03 +0000 Received: from DM3NAM02FT053.eop-nam02.prod.protection.outlook.com (2603:10b6:5:3b2:cafe::98) by DS7PR03CA0180.outlook.office365.com (2603:10b6:5:3b2::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Thu, 7 Jul 2022 13:12:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com; pr=C Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by DM3NAM02FT053.mail.protection.outlook.com (10.13.5.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5417.15 via Frontend Transport; Thu, 7 Jul 2022 13:12:02 +0000 Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Thu, 7 Jul 2022 14:12:00 +0100 Received: from smtp.xilinx.com (172.21.105.197) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Thu, 7 Jul 2022 14:12:00 +0100 Envelope-to: lihuisong@huawei.com, andrew.rybchenko@oktetlabs.ru, dev@dpdk.org, thomas@monjalon.net, weiyuanx.li@intel.com, huangdaode@huawei.com, liudongdong3@huawei.com Received: from [172.21.33.98] (port=49519) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1o9RIW-000303-9T; Thu, 07 Jul 2022 14:12:00 +0100 Message-ID: Date: Thu, 7 Jul 2022 14:12:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] app/testpmd: fix display types failure when query RSS rule Content-Language: en-US To: "lihuisong (C)" , CC: , , , , References: <20220707105044.10567-1-lihuisong@huawei.com> <773cea2b-68e3-ac28-b6cc-dd57377144b1@xilinx.com> <4757b6d3-1796-05c3-1324-39c4e541085b@huawei.com> From: Ferruh Yigit In-Reply-To: <4757b6d3-1796-05c3-1324-39c4e541085b@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c552ae30-46dd-493e-3394-08da601a4841 X-MS-TrafficTypeDiagnostic: MN2PR02MB6237:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3jU4s2QGuhLrO556oDTROMm6/ojPNVsOf2mtorddxT2xNPZ0qLWfLBkhVeIg/I0OPy1wFfHFwVoohL2DE75ftzZYufeefPLSXFxccAIhBcMPR82TcwfjggfHZz/MrGepLjkGYwMHNjv14F3hDenxgvWjzbFjmNhV/FVpl+69VqIxImL3fzO8oxmVU9bqhQME//cMzZ05EpRSWeSiY01vmwzdUtJ2djqpodXxJT7pgWwlXrpywvLZ/fN1Uqih9/rqx1VdDu9VlIrYU5fbWtB1OuUPAPlQBSp1AQDWKCexbf2RN5s2H6PedDZyOTApGwCqeWdHAB3z+rCq0nErdv0olv+vVrBPipSGb2xv7IgX9HcLfhpZB5ivAM2xxrfcsQuXI+yaZAk3Eadzv9zJQ+ohkBBo2IpG9VHCN+EE1AQlugtiJz9PCeJmfI/KixdZ8EuAlC0D4z12BXph+nyEilYCGFDURuQk1nESQa8w7KMEkdS5UQ68nXUmW/U1grHRGh/5ALC8p7pJOB9J29qkW29yMGQ2TaKxWEarICNmls6YGCjD95pVUlGU3xMosYH6FJ1LLzHTM1lON+ntmhfAQ6JIWUEFm7ud8F//LM+Z0Qv6Xe4T4SLIFPAtOga58RnQV3l+aGbbPIzK+2nYhRIdhe1xp7Zvls5eUv3utukdLvX6i1nioqgmJxCVGaEqk1RvfTVgtlXjdL/VlcJV+qM87Sq32HFvQ7K/tDMO/+8yIyQfxT4AXQL0+qy6tqmbYDTbTEHI/SnPZqkQbC87UlYAPXQVP8LdvHC8lSt+ns0DBcN228LRfmspTg7fLhFMkZr9+iJ+1VO0cGVK/UJg3Uu8OydunXn75Txx/YyqmjF7vOj8mQIebZMZIXakSemgysLyfXp/oQT2nY1Jy9w0WIgHFO9Icw== X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch01.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230016)(4636009)(376002)(136003)(39860400002)(346002)(396003)(36840700001)(40470700004)(46966006)(70586007)(82740400003)(8676002)(7636003)(186003)(2616005)(36756003)(47076005)(70206006)(31686004)(426003)(36860700001)(53546011)(356005)(82310400005)(40480700001)(110136005)(83380400001)(4326008)(26005)(5660300002)(478600001)(54906003)(44832011)(31696002)(41300700001)(9786002)(40460700003)(316002)(2906002)(336012)(8936002)(50156003)(21314003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2022 13:12:02.1182 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c552ae30-46dd-493e-3394-08da601a4841 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT053.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR02MB6237 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/7/2022 1:42 PM, lihuisong (C) wrote: > CAUTION: This message has originated from an External Source. Please use > proper judgment and caution when opening attachments, clicking links, or > responding to this email. > > > 在 2022/7/7 20:22, Ferruh Yigit 写道: >> On 7/7/2022 11:50 AM, Huisong Li wrote: >>> Now testpmd fails to display types when query RSS rule. The failure is >>> because the '\n' character is missing at the end of the function >>> 'rss_config_display()'. >>> >> >> Bugzilla ID: 1048 >> >>> Fixes: 534988c490f1 ("app/testpmd: unify RSS types display") >>> >>> Signed-off-by: Huisong Li >>> --- >>>   app/test-pmd/config.c | 1 + >>>   1 file changed, 1 insertion(+) >>> >>> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c >>> index 608bec9796..bcb6d42da3 100644 >>> --- a/app/test-pmd/config.c >>> +++ b/app/test-pmd/config.c >>> @@ -1693,6 +1693,7 @@ rss_config_display(struct rte_flow_action_rss >>> *rss_conf) >>>           return; >>>       } >>>       rss_types_display(rss_conf->types, >>> TESTPMD_RSS_TYPES_CHAR_NUM_PER_LINE); >>> +    printf("\n"); >> >> >> Thanks Huisong for the fix. >> >> What do you think to have '\n' in the 'rss_types_display()' function >> and update 'port_rss_hash_conf_show()' usage? >> >> And can do same change for 'rss_offload_types_display()', having last >> '\n' in the function. > For the quering RSS rule command, the 'rss_types_display()' is the last > function > of 'port_flow_query(). But it is not the case in other RSS commands, and > all have > ''printf("\n")'' after 'xxx_types_display()'. It shouldn't matter if it is last function or not. I think we can make 'xxx_types_display()' functions self sufficient, without needing additional '\n' after them. Current output of functions: " A B C D E" Suggested output" " A B C D E " >> >>>   } >>>     static struct port_indirect_action * >> >> .