From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 932A45B3A for ; Wed, 24 Oct 2018 17:13:14 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Oct 2018 08:13:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,420,1534834800"; d="scan'208";a="268427303" Received: from mkovacev-mobl.ger.corp.intel.com (HELO [10.237.221.98]) ([10.237.221.98]) by orsmga005.jf.intel.com with ESMTP; 24 Oct 2018 08:13:12 -0700 To: Akhil Goyal , "dev@dpdk.org" Cc: "roy.fan.zhang@intel.com" , "arkadiuszx.kusztal@intel.com" References: <20181012144501.19562-1-marko.kovacevic@intel.com> <20181017124937.38052-1-marko.kovacevic@intel.com> <20181017124937.38052-2-marko.kovacevic@intel.com> <64103ec5-2f25-1648-4d47-27a0f13e30e0@nxp.com> <8a58ae31-5d73-f97a-05fa-8d4fd06786c6@nxp.com> From: Marko Kovacevic Message-ID: Date: Wed, 24 Oct 2018 16:13:11 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <8a58ae31-5d73-f97a-05fa-8d4fd06786c6@nxp.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v5 1/8] examples/cryptodev_fips_validate: add fips validation into examples X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Oct 2018 15:13:15 -0000 On 24/10/2018 15:36, Akhil Goyal wrote: > > On 10/24/2018 7:47 PM, Marko Kovacevic wrote: >> On 24/10/2018 13:13, Akhil Goyal wrote: >>> On 10/17/2018 6:19 PM, Marko Kovacevic wrote: > snip [..] >>>> +int >>>> +fips_test_parse_one_case(void) >>>> +{ >>>> +    uint32_t i, j = 0; >>>> +    uint32_t is_interim = 0; >>>> +    int ret; >>>> + >>>> +    if (info.interim_callbacks) { >>>> +        for (i = 0; i < info.nb_vec_lines; i++) { >>>> +            for (j = 0; info.interim_callbacks[j].key != NULL; j++) >>>> +                if (strstr(info.vec[i], >>>> +                    info.interim_callbacks[j].key)) { >>> it looks interim_callback is a single structure and there is no need for >>> treating as an array. >> For some tests interim data could be multiple lines. > here you are not incrementing j, which means you are not using the other > ones. Also I cannot see it getting incremented in this function in rest > of the patches.   for (j = 0; info.interim_callbacks[j].key != NULL; j++) j is incremented as shown in the above line