From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5392AA052A; Wed, 27 Jan 2021 00:50:05 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 11B9C140D4F; Wed, 27 Jan 2021 00:50:05 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 42109140D47 for ; Wed, 27 Jan 2021 00:50:03 +0100 (CET) IronPort-SDR: 89M6XCwLNpDvxS5iDXG4yZ8Qdnoqd3WJbMhmfpzymxWEl49puW3RexEVeZoDuHntfrfLzfQMVv scD94lgiqpng== X-IronPort-AV: E=McAfee;i="6000,8403,9876"; a="159766463" X-IronPort-AV: E=Sophos;i="5.79,377,1602572400"; d="scan'208";a="159766463" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2021 15:50:02 -0800 IronPort-SDR: 6B9z44pqs7J7pmsQWr0tuX29qoZa11CixlYbhElXuySNier197iy0as00TTxFE8LOknrUaSL8O XMgIrw5OF2Lw== X-IronPort-AV: E=Sophos;i="5.79,377,1602572400"; d="scan'208";a="362177600" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.227.53]) ([10.213.227.53]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2021 15:50:02 -0800 To: lironh@marvell.com, jerinj@marvell.com Cc: dev@dpdk.org References: <20201202101212.4717-1-lironh@marvell.com> <20210122191925.24308-1-lironh@marvell.com> <20210122191925.24308-16-lironh@marvell.com> From: Ferruh Yigit Message-ID: Date: Tue, 26 Jan 2021 23:50:00 +0000 MIME-Version: 1.0 In-Reply-To: <20210122191925.24308-16-lironh@marvell.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 15/37] net/mvpp2: add dsa mode support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/22/2021 7:19 PM, lironh@marvell.com wrote: > From: Liron Himi > > Extend the config file with 'start-hdr' field. > currently 'eth' (default) and 'dsa' headers are supported. > > Signed-off-by: Liron Himi <...> > @@ -575,13 +607,15 @@ mrvl_get_qoscfg(const char *key __rte_unused, const char *path, > (*cfg)->port[n].mapping_priority = > PP2_CLS_QOS_TBL_IP_PRI; > else if (!strncmp(entry, MRVL_TOK_VLAN, > - sizeof(MRVL_TOK_VLAN))) > + sizeof(MRVL_TOK_VLAN))) { > (*cfg)->port[n].mapping_priority = > PP2_CLS_QOS_TBL_VLAN_PRI; > - else > - rte_exit(EXIT_FAILURE, > + } else { > + MRVL_LOG(ERR, > "Error in parsing %s value (%s)!\n", > MRVL_TOK_MAPPING_PRIORITY, entry); > + return -1; > + } +1 to replace the rte_exit() in PMD; > @@ -628,7 +666,8 @@ mrvl_get_qoscfg(const char *key __rte_unused, const char *path, > } else { > if ((*cfg)->port[n].use_global_defaults == 0) { > MRVL_LOG(ERR, > - "Default Traffic Class required in custom configuration!"); > + "Default Traffic Class required in " > + "custom configuration!"); It is preferred to not break the log strings, if you don't mind I will merge it back in the next-net.