From: Pascal Mazon <pascal.mazon@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, Matan Azrad <matan@mellanox.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/2] net/tap: fix indentation in flow file
Date: Mon, 16 Oct 2017 10:04:50 +0200 [thread overview]
Message-ID: <d0f5ef56-260c-851a-fef4-0bfc0bcae660@6wind.com> (raw)
In-Reply-To: <b7a1faa0-60b3-32d0-e95d-bc24937e357e@intel.com>
Hi,
Sorry for the delay, I was on vacation.
Nevermind this indent patch for now.
Matan, could you integrate it (squashed) when you'll have a new patch
modifying tap_flow.c?
Thank you.
Regards,
Pascal
On 05/10/2017 23:33, Ferruh Yigit wrote:
> On 10/4/2017 6:26 PM, Ferruh Yigit wrote:
>> On 10/4/2017 9:15 AM, Pascal Mazon wrote:
>>> Hi,
>>>
>>> I'm surprised there's only one place in the file with indent problem,
>>> but I'm ok with the patch otherwise.
>>>
>>> Ferruh, I didn't get what you mean; Matan is modifying tap_flow.c in
>>> patch 2/2, right?
>> I wasn't sure about getting the patch that fixes only syntax in one place.
>> Good to have proper syntax but a commit for this looked like overkill to
>> me. So I was suggesting keep it as it is and fix syntax when that piece
>> of code updated later.
>>
>> But you are the maintainer of the driver, if you have strong opinion to
>> get it, sure I can.
> What has been fixed is still in next-net, so I can squash this.
>
> <...>
>
>>>>> Missed 4 spaces were added after break if line.
>>>>>
>>>>> Fixes: 7a6811d78ed6 ("net/tap: fix flow and port commands")
>>>> What do you think fixing this when that code has been touched next time?
>>>>
>>>>> Signed-off-by: Matan Azrad <matan@mellanox.com>
> Squashed into relevant commit in next-net, thanks.
next prev parent reply other threads:[~2017-10-16 8:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-03 14:55 Matan Azrad
2017-10-03 14:55 ` [dpdk-dev] [PATCH 2/2] net/tap: allow RSS flow action Matan Azrad
2017-10-04 8:19 ` Pascal Mazon
2017-10-04 8:37 ` Pascal Mazon
2017-10-05 21:34 ` Ferruh Yigit
2017-10-03 22:07 ` [dpdk-dev] [PATCH 1/2] net/tap: fix indentation in flow file Ferruh Yigit
2017-10-04 8:15 ` Pascal Mazon
2017-10-04 17:26 ` Ferruh Yigit
2017-10-05 21:33 ` Ferruh Yigit
2017-10-16 8:04 ` Pascal Mazon [this message]
[not found] <1507042327-9501-1-git-send-email-root@pegasus12.mtr.labs.mlnx>
2017-10-03 15:07 ` Matan Azrad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0f5ef56-260c-851a-fef4-0bfc0bcae660@6wind.com \
--to=pascal.mazon@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=matan@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).