From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id EE2921B3AB for ; Mon, 16 Oct 2017 10:04:53 +0200 (CEST) Received: by mail-wm0-f41.google.com with SMTP id t69so388410wmt.2 for ; Mon, 16 Oct 2017 01:04:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=aAcFqAHkG0HBn5gHPcMm3lmWGmtt0VNTyMxQRw5mc2E=; b=KwASnEpK6lTnZArdZO1wTA2mQiIWFKwyjeuycj0spVEewDfeTfwz3T7c6L5Mqfipul u3edH1Lnf/Cpiv1E5Y/c//sQ+A2p2m+UT/dLHN9gNVptOQEqxrTAqti25d3VJZDCBqdT TNkfJP+JmMWl9cbFI+Z24abK4r8rSfxCMGBgtJh8qqU/AygKHpX+8/+hzN5zq372vEjo kH4x1bU6KCtCk19lxDNIchuyxDzwKC8Z26KFvP2tjaS9ncwVyLM5hbzlBVf975WyfiRD XHdO/8JEXaLDpFHyEe9gX7m4b0SeyMAJYg+vKBVJ9fTEDD2XgmccELOh/ad6jf006AaW e1xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=aAcFqAHkG0HBn5gHPcMm3lmWGmtt0VNTyMxQRw5mc2E=; b=CxRcQkmJvz6HaEW+lwojxo4axAy0HmGONQZRJf+JppMA44SPVIaRdZpyL6JdQ0KaEF HWOEoW5cADiOGB4xcHldnFS6gXUmAXNEHA4399t1tYLCDlA3mDM7//O8wgaL4hk1OYbG eueKb6n8dKED7QWLqwJatOMOaDo8evoT3ZHUe76yytlcnD0JzvJrR6xUohBE4pmSSAh3 01PvR31NKQuCxKWY3on1imiTqPi8/peN7ZCEADJtsaV78RBg1FUHUvBE27xSIJOLT5Bu x6SwCQ/RlSdiDMGKQVuyPSdL33yV0HtM3rvIEYD0PnodV8mAqNH5cPkKSrqU2MW2WGZz cQXA== X-Gm-Message-State: AMCzsaXPrVZGPrwgovD2OqTpv5lKwaIkORx3cNd+ggSbDjFOvcG+/4AH 8Kh+sv1QzDWgy3p3OCAgIAqj+lz2fdg= X-Google-Smtp-Source: ABhQp+QuKKvM60sZs4HS1WHqem/N4Qd4xOCvTAWF3TkZ1WOzm7ZnzlsBZIUTlr2JYd5GRrtpe6XunA== X-Received: by 10.28.66.215 with SMTP id k84mr93006wmi.143.1508141093425; Mon, 16 Oct 2017 01:04:53 -0700 (PDT) Received: from [192.168.1.79] (82.107.69.91.rev.sfr.net. [91.69.107.82]) by smtp.gmail.com with ESMTPSA id y23sm8862954wry.62.2017.10.16.01.04.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Oct 2017 01:04:52 -0700 (PDT) To: Ferruh Yigit , Matan Azrad Cc: dev@dpdk.org References: <1507042556-9839-1-git-send-email-matan@mellanox.com> <551c25bb-5888-00d0-30a5-0d3a0964132d@intel.com> <28a38c08-efac-3a4f-24d8-028dd35749db@intel.com> From: Pascal Mazon Message-ID: Date: Mon, 16 Oct 2017 10:04:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH 1/2] net/tap: fix indentation in flow file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Oct 2017 08:04:54 -0000 Hi, Sorry for the delay, I was on vacation. Nevermind this indent patch for now. Matan, could you integrate it (squashed) when you'll have a new patch modifying tap_flow.c? Thank you. Regards, Pascal On 05/10/2017 23:33, Ferruh Yigit wrote: > On 10/4/2017 6:26 PM, Ferruh Yigit wrote: >> On 10/4/2017 9:15 AM, Pascal Mazon wrote: >>> Hi, >>> >>> I'm surprised there's only one place in the file with indent problem, >>> but I'm ok with the patch otherwise. >>> >>> Ferruh, I didn't get what you mean; Matan is modifying tap_flow.c in >>> patch 2/2, right? >> I wasn't sure about getting the patch that fixes only syntax in one place. >> Good to have proper syntax but a commit for this looked like overkill to >> me. So I was suggesting keep it as it is and fix syntax when that piece >> of code updated later. >> >> But you are the maintainer of the driver, if you have strong opinion to >> get it, sure I can. > What has been fixed is still in next-net, so I can squash this. > > <...> > >>>>> Missed 4 spaces were added after break if line. >>>>> >>>>> Fixes: 7a6811d78ed6 ("net/tap: fix flow and port commands") >>>> What do you think fixing this when that code has been touched next time? >>>> >>>>> Signed-off-by: Matan Azrad > Squashed into relevant commit in next-net, thanks.