From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B2E5AA04C3; Mon, 28 Sep 2020 12:33:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 69E241D703; Mon, 28 Sep 2020 12:33:10 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 879FD1D6FD for ; Mon, 28 Sep 2020 12:33:06 +0200 (CEST) IronPort-SDR: VLbGFSF8jaegOwtblpyVz4PAvg27zbxhpiYemB5aziiLtN/PPCI23EKiiNX4Yq4woml1UdKBzD O2EMIKprschg== X-IronPort-AV: E=McAfee;i="6000,8403,9757"; a="159313421" X-IronPort-AV: E=Sophos;i="5.77,313,1596524400"; d="scan'208";a="159313421" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2020 03:33:03 -0700 IronPort-SDR: OKdXWtIjQtPrC+jekC+QwwBKeGoLDMbt6171vm0OLwKGheZlbehIeBfz1dacpcMU7R+tf7BoA4 RpL/KmCX5rDg== X-IronPort-AV: E=Sophos;i="5.77,313,1596524400"; d="scan'208";a="456772808" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.193.117]) ([10.213.193.117]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2020 03:32:59 -0700 To: David Marchand , Jerin Jacob Cc: Manish Chopra , Gaetan Rivet , dpdk-dev , Igor Russkikh , Rasesh Mody , GR-Everest-DPDK-Dev , Rosen Xu , Tianfei zhang , Heinrich Kuhn , Qiming Yang , Qi Zhang , Thomas Monjalon References: <20200925115508.4179-1-manishc@marvell.com> <20200925115508.4179-2-manishc@marvell.com> From: Ferruh Yigit Message-ID: Date: Mon, 28 Sep 2020 11:32:56 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v6 1/6] drivers: add generic API to find PCI extended cap X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/28/2020 9:59 AM, David Marchand wrote: > On Sun, Sep 27, 2020 at 2:21 PM Jerin Jacob wrote: >> >> On Fri, Sep 25, 2020 at 5:26 PM Manish Chopra wrote: >>> >>> By adding generic API, this patch removes individual >>> functions/defines implemented by drivers to find extended >>> PCI capabilities. >>> >>> Signed-off-by: Manish Chopra >>> Signed-off-by: Igor Russkikh >>> Reviewed-by: Gaetan Rivet >> >> Reviewed-by: Jerin Jacob >> >> @Thomas Monjalon @David Marchand @Ferruh Yigit >> >> Othe patches in the qede series is depending on this patch, Let me >> know, how we are planning to pull this patch? Is through main or >> dpdk-next-net or dpdk-next-net-mrvl? > > Just two small comments, that can be fixed by whoever applies it. > > - The title does not reflect that we are adding an API to the pci bus. > My suggestion is: "bus/pci: query PCI extended capabilities" > > - There is an unneeded empty line added to lib/librte_pci/rte_pci.h: > diff --git a/lib/librte_pci/rte_pci.h b/lib/librte_pci/rte_pci.h > index 1d89651ec8..f89c7dbbea 100644 > --- a/lib/librte_pci/rte_pci.h > +++ b/lib/librte_pci/rte_pci.h > @@ -22,7 +22,6 @@ extern "C" { > #include > #include > > - > /* > * Conventional PCI and PCI-X Mode 1 devices have 256 bytes of > * configuration space. PCI-X Mode 2 and PCIe devices have 4096 bytes of > > > The patch is reviewed by Gaëtan. > Either through next-net or next-net-mrvl is fine to me. > > I'll leave the decision to Ferruh. > > Since other patches in the set requires Jerin's review, @Jerin can you get the patchset to dpdk-next-net-mrvl?