From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0048.outbound.protection.outlook.com [104.47.33.48]) by dpdk.org (Postfix) with ESMTP id 895AB1B1DE for ; Wed, 17 Jan 2018 06:04:53 +0100 (CET) Received: from CY1PR03CA0020.namprd03.prod.outlook.com (10.174.128.30) by BY2PR0301MB0725.namprd03.prod.outlook.com (10.160.63.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.407.7; Wed, 17 Jan 2018 05:04:52 +0000 Received: from BL2FFO11FD014.protection.gbl (2a01:111:f400:7c09::146) by CY1PR03CA0020.outlook.office365.com (2603:10b6:600::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.407.7 via Frontend Transport; Wed, 17 Jan 2018 05:04:51 +0000 Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BL2FFO11FD014.mail.protection.outlook.com (10.173.160.222) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.345.12 via Frontend Transport; Wed, 17 Jan 2018 05:04:51 +0000 Received: from [10.232.14.39] ([10.232.14.39]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id w0H54nvK008364; Tue, 16 Jan 2018 22:04:50 -0700 To: Stephen Hemminger , Ferruh Yigit References: <20180116183755.24542-1-stephen@networkplumber.org> From: Shreyansh Jain CC: Message-ID: Date: Wed, 17 Jan 2018 10:49:03 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180116183755.24542-1-stephen@networkplumber.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131606390919909004; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(39380400002)(396003)(346002)(376002)(39860400002)(2980300002)(1109001)(1110001)(339900001)(199004)(189003)(24454002)(6346003)(1720100001)(8936002)(81166006)(229853002)(76176011)(81156014)(97736004)(8676002)(65826007)(65956001)(966005)(77096006)(498600001)(31696002)(26005)(68736007)(86362001)(50466002)(2486003)(2906002)(59450400001)(4326008)(305945005)(104016004)(31686004)(83506002)(23676004)(230700001)(2950100002)(58126008)(53376002)(106466001)(316002)(6246003)(64126003)(53936002)(67846002)(110136005)(5660300001)(105606002)(6306002)(65806001)(356003)(6666003)(47776003)(36756003); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR0301MB0725; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD014; 1:QDJtywM+EerLkjOLDZctk0YnldnW0YU9Yu3D0OmnYCXItxkHIACVrHwdHunFWNynpWb1uWr8h6xsIbwx4DChrtxH5aep6LiB6DMPGcNqFLpc9IcADUEnhIQ6HDjJjzna X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d6db3d8e-22f1-4db7-ce8c-08d55d67d76a X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(5600026)(4604075)(2017052603307); SRVR:BY2PR0301MB0725; X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB0725; 3:1wVm2S4mE1N+O+y4W+ecnFKjcWdp0KQTRvi4bKuEQiO2TAUkmJoAQxJeTQIFB3J1T2W+nYn7rD/MIH9cs7NsxJoc8oq24zHY5TtsGRPVOnOghjmXIMBJlShzlOYPt2kv8aYLtnDYwM77K78lh2eD14GiVYBfvScpmKJZxOfckhKfiZ5JvOYHxAuidJAIs20NRTWMuAd6ghiDp4EVVdaMwpLeLC3clJt9W+57K2B+VfpDcGUAiDMAGaIR/B3FbEDfmnESLdbvmtUIJHYC09qFbedRgWtvz+YpXhnYwMoMeFz6PbhEJfGyUEDqvOJXuUsKBZSuZY2GwBLqtPkqSznjBUVgP4q+pHeqE5fqEh7vI+w=; 25:uIp4yygpLxQQje/jqKULfXKLKhADfLpTu2FDuruLGzeKaYYdTTOoFXXaIBKoFxIlNncrA1+d0GSvZbDALpkalkgK2a5YFguYx/weHsAWphN7jvKdOgSO9yZaNdK+JCvXHDb9g5YA9norA32rF+Ouzaf88VP9g93GMs4yFun+tDsenTw7mnPhY9YyZPlOOnftf1BBDy5Vvjkcp9+PjK0wYj1TarHX71hkKD/F4b5UasvgM32dXCYXmVr4iPqVm3VKOYBr7pJXAlR1VO26MRZxRfnwGrHJdDTKsg8vTyUU/2qg6z5OthpXmhjPO5rYba6Mg/N4njj3IRPj53ZJ+1kX2w== X-MS-TrafficTypeDiagnostic: BY2PR0301MB0725: X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB0725; 31:0/VYwUnP70wdSfXruyEl36AgXpvenoTwf6TvUwaD39KdLYulIkzmpLRKpkfKQKIq4fNuXKFd+OW/zpLjJf//wEFDuYfGzk1GxgYtE+VpYpoGrbvNPuOq3Evnx3Z/ucMWEcdBbx42+Q5ZsN9/TCjdj/+AmXANccJRtrUbsa2ierQioyfqdsWkREvVw7NjRGjC49K3YUzlyUfq5SFAsr2aOAxHZxTOP93fjj5Ny+G8D/s=; 4:9bkw6Msxa4sLA8nbYGSZUKoyrAzZJ9A5mCNnFh7XTDAooC8rHq8etzikyC6EshDG7PD9gqCqgKrPB2RvuzAd6CChuCxKi0yt0vQz2gGvzRNb9j8jMbxKDqK+SWSn7RjJncVvHOaPZDrHsvGKxT5lbb8STXvZ8DsboEgdDk5Cbx7mJlenOEnmt1a2swW0kOPhZZ65gzZAkSQhBM7WOv+0n1M8eDHAoeQnaHvpbJg3JVLwZX5lgefI51vl0MrRELKpdffppvhn8tqu8rqF/weJVQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095135)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(3231023)(2400039)(944501161)(10201501046)(6055026)(6096035)(20161123559100)(20161123563025)(20161123556025)(20161123561025)(20161123565025)(201703131430075)(201703131448075)(201703131433075)(201703151042153)(201708071742011); SRVR:BY2PR0301MB0725; BCL:0; PCL:0; RULEID:(100000803101)(100110400095)(400006); SRVR:BY2PR0301MB0725; X-Forefront-PRVS: 0555EC8317 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTJQUjAzMDFNQjA3MjU7MjM6TVBydGZrVzJUejM4WjM0Y2d6MVgvbXV6?= =?utf-8?B?N051M2VKS0d0bEUwcVZwNmF1RDBtZFNVRlQrTHlHQjQ4QU9NU0xlT0RJN1B1?= =?utf-8?B?c0FpSEtGWmdKdm5xUUVhMzIybEVMSnNIMXhLV25ybVRSdXk4NDRrcGlBbk1n?= =?utf-8?B?a242SjdLcnUwM2pHTkpjN2RydXdQZUQ1UHRwQ0pwQzZqbU82enREZ2dDb2Vy?= =?utf-8?B?dm16dVJKY2Y0V3NLdHN6aUxNT2ZocEo0cURtdFF1ZEV6aGVFdlJLajR3OW1G?= =?utf-8?B?ZVZQV052MXZhd0lDREE4K0s3enlha0UvandzdEZpVEZkcDVtQjZkbVM2MkdG?= =?utf-8?B?SHl4NDd3c0RxYmtVMThiYTA0MXEvMUpoUkVjS1F2VjllbExLcWtQZnJjcTBK?= =?utf-8?B?ZnhGWVVGSUdwY2gxd2N5cnFaVUZ2TkNyRTMwT1hXNTFKN2hxVlAwekZlSWlE?= =?utf-8?B?cDRTSHg2TzhTZnV5YUE1ckdpRk1EalBDdEhvcDNYb1dWZENHK1I5MDBoRXcv?= =?utf-8?B?Y0lBNDJtUHFwTFVPS2taRXRUK0IzdXlxL2NEVTY1QXB4eFBuWW5tVTVlck5z?= =?utf-8?B?VVNVM2hNU2JyenJXR3A0eGVBU0NLVGIxZEhjbEZMbndoanhJdldULytFdXNS?= =?utf-8?B?RHRXVDM2QkhEbEJJeWY3Q1QrK1pvbVhRUTVyYUtYMlFvbkVEa2xpQnRaU0ox?= =?utf-8?B?Yy8wR2JYWDNKTTZQUi8rNXZvYVJjYzVpajNKeVZGd0J4Nld4K0g3ekJGb3pZ?= =?utf-8?B?OWE5VUsrZUdmNGhQbzAvVkNYZGh6RU1GeG4wK2xicDNFSUc4azQ3LytHYTdO?= =?utf-8?B?NW9jQnBYRzY0TzhId0RMQ0x2YjZqUnhDWWdYVHpkVEIyL3FLRnlLZm5hSm1F?= =?utf-8?B?OVNlZVEyRGlmdDZOVXRRZTZHM0daVE5vbDVWa2hBelBHeGF4QWdxaXVJNlYw?= =?utf-8?B?WTFyL0Y0dm9TNVhOSHNQcmNoZmI3S0xrNWxaSG5EYXhEbGkzWUtHRkRkUmxL?= =?utf-8?B?bUV4Y2t3U3BSZ1E1M3FRNlExckV6UkxsKzh3T3VOaDJsQWlUTGZDSnBteldS?= =?utf-8?B?R3VNcTVSNmRneVUzaW9FWVY2OXRQQVBsMW83TUk2dlYvT3VweTEvaFg5cUVl?= =?utf-8?B?OTZKVkNVa0F6S0pBajdUc0N4bUltV21vWGdSb2dzaXFUR3JKS3BJdEtPeHNK?= =?utf-8?B?L3lrSmJmTEp0L1lCSGE0YVk2MXhIeElrTGJMMitZeXE3dlR2aXd4U0xsREJw?= =?utf-8?B?NjdqL0ZlcklxWEV2QUZSWGhsOG1xeUVhSytzRDc4ZkMvMTFEV0FIZENkbjIy?= =?utf-8?B?N0FUMSsrWFptVERPQkFGSVNOMlVySzVuT2NhVmhXSXVvcDZDR0pQTmtNVmFZ?= =?utf-8?B?eEF0T1VOZDI0WHRWMlN5TE1rcUEwRjNjMnpaWUE1ejdXcHczQ2l1UnpzVDVS?= =?utf-8?B?MVBxQklFTUtnSWNYWkpBV0NmUzZ5c0JHaVh3RDhrYlAzbWxFQ2ErZ2JUV2w4?= =?utf-8?B?VnJRZmJJL2FSTGJ6aEFFZG1hdEQ1Z1dEYlN0TWxsVXhTZWZWUFJEOXJ1MjBS?= =?utf-8?B?RXMxNDBQTzF1djZab2hVNXRiYTN3R2Q5V0dNazNJbnJ5QWIwUlIwaXU2aUdR?= =?utf-8?B?dmxRcVljRWcrRHo2VXdYRnVsL21manVYRldOenNRVkEvbHQ4N1ZhTWVuVDFP?= =?utf-8?B?N1I0Y3VmdXZ2bEVmVW0yZ2ZtTks2K2pMYmMrTGk5SHZpeFFHSThNQXpJOVJs?= =?utf-8?B?eVBYcnpNWE9LOXhxUEEwdzI5SFRMbGRqenY1L3NSUEdSWWZoSkVRWlh2YWtC?= =?utf-8?B?RjBvdzN3R2dBM2dMdFQvOTluTDJOQWx1S2xBZVBURmllaUg5Zz09?= X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB0725; 6:sc1wKLLZhtCxpzsYsw4zSm+cCLnR45EDrIjWWlwm/vnevgItx3PftYRtWpaKjBRgKGhsPRYsTn3MA6fB8aC0JUJ3u6aumkwChgIatkA8sxid9bV9GN8icoA+gzkso4jlqYN7H2wq30DbFy685yx5GLIprC45k8snxuOfZN2YMF2Ehk/v1e+1bS6GqyEEO1wd8EYptY2iGT8dhhHAO35FvEbLsEi7jj3dvoHSHmB1NyJEPynYPYR0qCMwwxa8YjF85qs+sAY59a4B/a0f9Jc0DP5kwuU82rN2am2QVjIXbDZ/Q+oY3P+lEEeMT6XdSX8whyTO9hGLa+1r+48W3FJNfpXrxchkny8F01YIr+Fd8VI=; 5:HTJUtvLwZC8CBefbamrwow8y85sF5gZlWLfC3wyzgvrd5Q6jtIrS8N/u84o1+kQNXp5Utn2rFAfm8o3aTz6krY9+NY3IlWh8b47ZZQ8YReWdZGGxWYobghRGrPyQeq5W65Ahft7pCa/RPDXhwlvxtM7vx56NMwIb2+jDMBFDdGE=; 24:Nij+AWjuqdS29/OLL2Uu2kXuR3nTisWvimXLZGihJmGNkZopwZFjUFS5vFmm5ujgHrWLAt6xIiV31gr2Rtxj0Vi50Ppq+IvjFfpQZ6pzjMM=; 7:+Ak6K/gdeIdkQAk8MKeETMcYGbwPLZFSX+iDKmEBl8MlbfzUWMfiH7KtzS/jdzc27reQpVc2pj1+YinDJLevHyKMpGPom4A2dZGtdzjBIErhdyYCQxw5Yd82V4rPzCa02oHDAvqppC71k11QSA1xb3+mHJ3Idc6iN0xGBA2Wr94RjSlnVd+BsP81siw994Zh3VNv86ekFDM8o+g954ZCHMHAd1LeMx1aJIcBnaUlV2IiH4udpRopRfisI55M/rlm SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2018 05:04:51.8348 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d6db3d8e-22f1-4db7-ce8c-08d55d67d76a X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0301MB0725 Subject: Re: [dpdk-dev] [PATCH v5 00/15] common ethdev linkstatus functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jan 2018 05:04:54 -0000 On Wednesday 17 January 2018 12:07 AM, Stephen Hemminger wrote: > While reviewing drivers, noticed a lot of unnecessary > duplication of code in drivers for handling the eth_dev link status > information. While consolidating this, it also became obvious that > some drivers behave differently for no good reason. > > It also was a good chance to introduce atomic exchange primitives > in EAL because there are other places using cmpset where not > necessary (such as bonding). > > Mostly only compile tested only, don't have all of the hardware > available (except ixgbe and virtio) to test. > > Note: the eth_dev_link_update function return value is inconsistent > across drivers. Should be changed to be void. > > v5 > - checkpatch whitespace cleanup > > v4 > - incorporate review feedback > - rename _rte_linkstatus to rte_linkstatus > - change return value of _rte_linkstatus > - optimize get on 64bit platforms > - change return value of rte_linkstatus_set > > v3 > - align rte_linkstatus_get with rte_atomic64_read > - virtio use ETH_SPEED_NUM_10G > - add net/ > > v2 > - function names changed > - rebased to current master > [...] 1. "--in-reply-to" is recommended way ([1]) 2. Specifically here: there is a v4 already by Ferruh (targeting maintainers directly, I think) and then another by you. And with separate threads it is difficult to compare them. Maybe you prefer flat email threads - it helps people like me who don't. 3. I had put my Ack on v4 by Ferruh, but it seems dpaa2 specific code has changed from Ferruh's v4 to your v4/v5. Please ignore that Ack. I will send my acceptance on your v5. [1] http://dpdk.org/dev