From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 11EDEA034C; Mon, 12 Dec 2022 19:34:36 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A289240687; Mon, 12 Dec 2022 19:34:35 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2065.outbound.protection.outlook.com [40.107.223.65]) by mails.dpdk.org (Postfix) with ESMTP id B3B2E40684 for ; Mon, 12 Dec 2022 19:34:34 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VsbB7p3nYJzZ6y5lUXQG7wk1zHhBcsYmeHNmUR6JL0jYPFw70sfl/5PlURKK3o9Z+hyREdoA8oOQoyJg1gYfRoJY+9UHMQvgsOv9/A749qsU+zL+V569ezldB4L+WoWRDF+ZpZ+c6/IsI6OMPWvO4VFjpwnWQf29hJOCUzllooLJRO69PlbNiD06Pb4As08oSBkI+FLybYEW2iktdUR4TZFiINeeZFwJc0N1ZDFj9unH/R9tY9WMFgxbP8g0IHRxzAKQOD5cfyijIu8jnGZXuz0kEwy/+Tip6tMCGldARYumzCZtvDXtzEqtJDU4eomeP9kr0LwwuXsJYpyYTjNXeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7XldY2GTo9YpXBYn/ojHC8JX14OuK/mb1dmqV0GHoc4=; b=iR+nIEjI9X5pv+IOpoR3dlUoAnJ5//Ijq6TZP9j2bi3Li2ltE4RCeVIi5F+NDBABLNelHklqOSqQ37ek+lI/pj4pZjkQ/wD9ZE/xQO5A3M1S/nsVonrhVTuRWYytzDaYyUffrhnwHp6yPf7G0UnL9SPyl0Avx7+Ds73/M7uL4xoEyKF2b4qKx6srUB/uXgQGYaX82GPakDeMhcB7DWPtRvdyo6E9emdOEejIhPQEDMh8G7KflFBaA4FsxtIhc/cRyUcNMlsAouA448gxsIPAGAwwZeqJenLLA41htSUSanFA0KwnK7EWj5KhSvZETvXA/18HjkkO70ix0kAdMr8RAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7XldY2GTo9YpXBYn/ojHC8JX14OuK/mb1dmqV0GHoc4=; b=ZgnWiEzc/oAWanQNV7x0mn1h7JWTK4zylujzhTe91Y+i5u4Zc5ikCsW2+fnw6cz5g2HHRCx2PTbeTloO1FQw3clcsgMhpDSXzt62lhKsDDmlJ8/Pn2ks9XMlRtt+//UoBSKM6r9OvuysxcuvVK8BeHGD1HQH+FxezS5bA1waVAA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SA0PR12MB4560.namprd12.prod.outlook.com (2603:10b6:806:97::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.19; Mon, 12 Dec 2022 18:34:22 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::b482:d5bd:c7d0:3842]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::b482:d5bd:c7d0:3842%8]) with mapi id 15.20.5880.019; Mon, 12 Dec 2022 18:34:22 +0000 Message-ID: Date: Mon, 12 Dec 2022 18:34:05 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Content-Language: en-US To: Ankur Dwivedi , "dev@dpdk.org" Cc: "thomas@monjalon.net" , "mdr@ashroe.eu" , "orika@nvidia.com" , "ferruh.yigit@xilinx.com" , "chas3@att.com" , "humin29@huawei.com" , "linville@tuxdriver.com" , "ciara.loftus@intel.com" , "qi.z.zhang@intel.com" , "mw@semihalf.com" , "mk@semihalf.com" , "shaibran@amazon.com" , "evgenys@amazon.com" , "igorch@amazon.com" , "chandu@amd.com" , Igor Russkikh , "shepard.siegel@atomicrules.com" , "ed.czeck@atomicrules.com" , "john.miller@atomicrules.com" , "ajit.khaparde@broadcom.com" , "somnath.kotur@broadcom.com" , Jerin Jacob Kollanukkaran , "Maciej Czekaj [C]" , Shijith Thotton , Srisivasubramanian Srinivasan , Harman Kalra , "rahul.lakkireddy@chelsio.com" , "johndale@cisco.com" , "hyonkim@cisco.com" , "liudongdong3@huawei.com" , "yisen.zhuang@huawei.com" , "xuanziyang2@huawei.com" , "cloud.wangxiaoyun@huawei.com" , "zhouguoyang@huawei.com" , "simei.su@intel.com" , "wenjun1.wu@intel.com" , "qiming.yang@intel.com" , "Yuying.Zhang@intel.com" , "beilei.xing@intel.com" , "xiao.w.wang@intel.com" , "jingjing.wu@intel.com" , "junfeng.guo@intel.com" , "rosen.xu@intel.com" , Nithin Kumar Dabilpuram , Kiran Kumar Kokkilagadda , Sunil Kumar Kori , Satha Koteswara Rao Kottidi , Liron Himi , "zr@semihalf.com" , Radha Chintakuntla , Veerasenareddy Burru , Sathesh B Edara , "matan@nvidia.com" , "viacheslavo@nvidia.com" , "sthemmin@microsoft.com" , "longli@microsoft.com" , "spinler@cesnet.cz" , "chaoyong.he@corigine.com" , "niklas.soderlund@corigine.com" , "hemant.agrawal@nxp.com" , "sachin.saxena@oss.nxp.com" , "g.singh@nxp.com" , "apeksha.gupta@nxp.com" , "sachin.saxena@nxp.com" , "aboyer@pensando.io" , Rasesh Mody , Shahed Shaikh , Devendra Singh Rawat , "andrew.rybchenko@oktetlabs.ru" , "jiawenwu@trustnetic.com" , "jianwang@trustnetic.com" , "jbehrens@vmware.com" , "maxime.coquelin@redhat.com" , "chenbo.xia@intel.com" , "steven.webster@windriver.com" , "matt.peters@windriver.com" , "bruce.richardson@intel.com" , "mtetsuyah@gmail.com" , "grive@u256.net" , "jasvinder.singh@intel.com" , "cristian.dumitrescu@intel.com" , "jgrajcia@cisco.com" , =?UTF-8?Q?Morten_Br=c3=b8rup?= References: <20220929102936.5490-1-adwivedi@marvell.com> <20221006151844.23483-1-adwivedi@marvell.com> <20221006151844.23483-2-adwivedi@marvell.com> From: Ferruh Yigit Subject: Re: [PATCH v3 1/4] ethdev: add trace points In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0263.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:37c::12) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SA0PR12MB4560:EE_ X-MS-Office365-Filtering-Correlation-Id: d1034c76-a372-407e-b652-08dadc6f7c2b X-LD-Processed: 3dd8961f-e488-4e60-8e11-a82d994e183d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aq7ReYF4tJ626Bbt4kf9N6f/bgi0aV7q0yJAHaE0DJSstn4nbJMxeGKX0Yrm85C77rmUkr/5FdkeaaTt3WrOFoGvS2qUc98clfK6tlWOP+yS8fuPQ3cjiBsfRzrUgMlHFf5TcyQs8/J/5AzemX5tYhI/wFcFYtcfy1sUA+DWyGyHHpy/vs0t/SNLhNLF76yH6c65uX0+cUfJr80IMpBWzaH3yhXyVf/dNYMAMPxD3OpEW7BgAPq/Bb97Otlxsz/n6AOsSOAgorHb30Rh3Xh8cTvnKkMLLOaw/7xHO708+aE5O2+MT4ZG+dG/nAs3daHCyUdDt7IfzCNguULnrmirLoOqVhaNKIyRX3e5uksNshyOghCeYK75qsiFjEdenfG374ckxwatrZDwZSQqluH9Qqs2HvdTEGMalF9EJFtU6/wjd8NkMU3FV02veHD0w3OaZSZsyXFkNsy+joeof0oWom5RtO38zvQykPrP/FbbLojH1bWxEGZ70E9YEOnMpQ+ielBcng3RECZAECLPk6lD0BlE3i1mPdUxGnzTTiBkAdRr/isvbngYyPS+3neORKwtg07hKytFFDdqEXUUR1ku9I//y0i0qZBdOF1Bqs5CZXbBWZcCYi4hOEJFa3OVkhAb9Z6j1cZyOYYbitbvSQz6g8nMPPiA87FwZkJ+SCcDO4dGthXCjmS7mpvnv5qPUlZaw4n0Q36tw6kctuv3H9Z47ITpVMovPp5c+ge3wFMCCGU= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(366004)(396003)(346002)(376002)(136003)(451199015)(38100700002)(36756003)(86362001)(26005)(6512007)(31696002)(316002)(6486002)(8936002)(478600001)(110136005)(54906003)(6666004)(6506007)(7366002)(7416002)(5660300002)(44832011)(7336002)(83380400001)(7406005)(53546011)(31686004)(2906002)(186003)(41300700001)(66556008)(2616005)(66946007)(4326008)(8676002)(66476007)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QXFRMnBSMWVOcE1MMWhDaW1VeDdNWlhrRWVVeUlpeTdsUURPZHRpZGtyMzFp?= =?utf-8?B?ZFcyenNHZWYvZ1V5MGVwRE16dmhjV3FySytmcnRMa1BGVkpXMGdsM2xBN1hO?= =?utf-8?B?STNhbXErNDBGenZRR01iOTQ4MVVjTEY5dkhRWHQ0QlZkSDNieHJ0UVRZcTZy?= =?utf-8?B?MnVyeGw5M3RaYnNtRStGbjFXYkI1VnBPdENLcUxmcllKcTZaQzUyR2d5SlpX?= =?utf-8?B?VVZWbTh4cXptdExZajZrZUFTU1ZYc3MxdExjTU1MQkVzdzFoVGUwc1MzZ2ZV?= =?utf-8?B?NmlWVGNFS3IzaFMxZlhTVC9tUkZtYXU0S0ZGVE12T3UyazFNNFZqRUxkeUlh?= =?utf-8?B?WWVYRzc0NVVqL0svNVJCa1FYS1FjK1U4N0VUR0VMTjJLQk85Rkl2ZllCUFFx?= =?utf-8?B?RG1qeDd3V3d0Mlk1TGNsdHZQT0dJdE9FODZJS3VjS0VYdW9tQnJiQkVyZDhY?= =?utf-8?B?dWRYRUluTmd4UkhMMUd2RFE4U2JhbVFVUnBXR2h2OExsZkhqTEFiZ3JCQ1FH?= =?utf-8?B?ODdBZ0xPSkJCak83NE50RVBacy9zMC9LUzVibzVPSkcva1RNZVlkaWZySVBJ?= =?utf-8?B?WUhpUzdHajhvY0FtY0hpQWdsRlpFaG4waUVFeDFwNFBCZVRvcFN1RDA2TnVs?= =?utf-8?B?djltcHFVSGlBSmVxTmd1ZSs3dHZTVnJWZTRzU2NRTDRmNWhQa0Flc0VLYVU1?= =?utf-8?B?NTJpZExzSUN5NXJMbjlkVFh6RVJiV1k3dnZWUzNYQUx2OHREQUdWNG9WbEtn?= =?utf-8?B?WlRjTkpFY0xGc1RFdlBqalVtZmpQajlyQUpNWmdxUEwvWElvREY4S0RVMFFj?= =?utf-8?B?a3BybmY0VjRXd2pjTEdVS3h2RU9rV1lrSnNxKzlYd29qc2NPNnRmZFpLb0l2?= =?utf-8?B?bG90aFVIK1RkZ2lhOTNmZlU2NWdoTFJTdFZNQXJVbTN2SjFSVkFOcTROeFoz?= =?utf-8?B?QjZERk9VY0x6L3lmUUdXQkdyOWxTeUNhMWZtTVRheUpkTGtpdHd6eVBEcUZ2?= =?utf-8?B?Z1kzQmdGdzZ5TzJFbEU1MlFIZTFxNDhTY0R3S0FWc3RzMzQ0aXk3K2I0ZFZZ?= =?utf-8?B?SlZCQ0ZWT0tZMVpUZ05VTzJQMnU5MkQ3OHN5VkwyTGlJTjhGQjBma21LRmIx?= =?utf-8?B?Uk5yL0FQRVpmblVFMWdrUlcwY1o2aWNZNXd6eThyb1pRTlp6elBTTFBSaUg0?= =?utf-8?B?ZmM0bnFzbVBXdHNkZzRvYkEyZlNOUFpNMFVJTVNDY0ZYRlVxalphVHF5aUtC?= =?utf-8?B?K21qWWFhS2xsWUFHMUc0VUtKRVZwOFM1VUJYcVNadXdpUXRIdlB4OFEzY05U?= =?utf-8?B?T0o5dzkwcTNIR0l6MGV4NEhzODBpWFlPNkJQa3NwNUYvRjQyY2doOWs5UWdX?= =?utf-8?B?WjhUek81VWNxeGZzejFRZTlOOHBBZ1FRc3kwOVBmMnZuQTVIUFNmRjJrOGNW?= =?utf-8?B?eks0WHFOdExMcWEvTm5DeWpFUVc1WFM3cUxiWGJVUlpNNjB2SWdzU1FSdXBk?= =?utf-8?B?SWs0bmpyY3FvT3hqYm9aT1pwZUpEYkRCRWRXYkJuRDBwWEpONFA5TDVQemx6?= =?utf-8?B?U2RiWlJoL1lwN3lpTG0wSmVIQjQ2anNUV291eTFMS2VXMjNjNjlQdHRzdzhv?= =?utf-8?B?QzBtWDF6NzhWaWQzdCtETUUxWlBvNERvNTdFejhiS0hSWEVTQVEvK3RaT1Qr?= =?utf-8?B?K2xtb3hWd0t5N0FnSmZPbjVBMGtwa0xKbTZSYlRlbTJ6RDNEQmZmODY3aGcx?= =?utf-8?B?VWtMZ2ZxdDA3U0lpZUowSE56K3B0bjRXY1pyUTBVRlpOSXJ2RldqbGhneHNy?= =?utf-8?B?S2kwcm5IL2FzM3lnZUdlam1VeGE5SUNTM3NoaGNIeE9WZ29tVVB5ODlIM1k1?= =?utf-8?B?NHkrSGtxa2xEa0ZoRHVtTHRCajRwOUpMcXA0dm5LTHZvc3ZhMDRYNWM3WU9F?= =?utf-8?B?ck9LT25WQW1RTjBoWTlOQnZTYndPdlFoR3JjQ2lVTWhPSmhCYkcyUUpNemtp?= =?utf-8?B?NThNZ3ZxcFN1bDFaSTdLMjc4U3BERTlOV0V2aFc5c3g1VmdTbXhqN0NNR0Jo?= =?utf-8?B?K2EwQTlXYTlEM21oSEZVNDJ3TFNiY2YwR2pJd3RITGVGWDBOREdMb2k1MkRy?= =?utf-8?Q?qy4xUQ7QDkHt64yNhVrVHP1QT?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: d1034c76-a372-407e-b652-08dadc6f7c2b X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Dec 2022 18:34:21.8752 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 551qw3q9z4rrZEciGlfR7hBXXWnU6j0bN506UWNjQnp0DOWD2w/5u2ir7kZU6NdO X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4560 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/10/2022 7:39 AM, Ankur Dwivedi wrote: >> Yes the functions you mentioned in previous comment are called in while loop >> in worker core. So I think they are fastpath. >> rte_eth_stats_get() is called in fastpath. Similar to rte_eth_macaddr_get(), I >> think functions like >> rte_eth_pro miscuous_get(), rte_eth_allmulticast_get() can also be called in >> fastpath. >> I am not sure which other functions can be fastpath. Is there a guideline/theme >> which can be used to determine this? > [Ankur] I will make the trace call in following functions as fast path trace, considering they are used in while loop in worker core or as rx/tx callback in examples applications. > rte_eth_tx_buffer_drop_callback > rte_eth_tx_buffer_count_callback > rte_eth_tx_done_cleanup > rte_eth_macaddr_get > rte_eth_timesync_read_rx_timestamp > rte_eth_timesync_read_tx_timestamp > rte_eth_timesync_adjust_time > rte_eth_timesync_read_time > rte_eth_timesync_write_time > rte_eth_stats_get > rte_flow_get_restore_info > rte_eth_read_clock > > Please let me know your comments on the patch series. Hi Ankur, I agree that tracing should not cause performance degradation, but not all APIs in your list are for datapath, or for each packet (even called in datapath in sample app). I would use fast path trace for following ones, but keep rest regular trace for rest: fastpath rte_eth_tx_buffer_drop_callback rte_eth_tx_buffer_count_callback rte_eth_tx_done_cleanup btw, I am planning to review series today/tomorrow, so please hold a possible new version for a while.