From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 6DD45292D; Thu, 21 Feb 2019 20:10:16 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9296E3091740; Thu, 21 Feb 2019 19:10:15 +0000 (UTC) Received: from [10.36.116.60] (ovpn-116-60.ams2.redhat.com [10.36.116.60]) by smtp.corp.redhat.com (Postfix) with ESMTP id C86895D9D5; Thu, 21 Feb 2019 19:10:10 +0000 (UTC) From: Kevin Traynor To: Yongseok Koh Cc: olivier.matz@6wind.com, shahafs@mellanox.com, dev@dpdk.org, arybchenko@solarflare.com, roszenrami@gmail.com, david.marchand@redhat.com, stable@dpdk.org References: <20190109085426.39965-1-yskoh@mellanox.com> <20190114211622.6900-1-yskoh@mellanox.com> <20190114211622.6900-2-yskoh@mellanox.com> Message-ID: Date: Thu, 21 Feb 2019 19:10:09 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Thu, 21 Feb 2019 19:10:15 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v5 2/2] net/mlx5: fix instruction hotspot on replenishing Rx buffer X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Feb 2019 19:10:16 -0000 Hi Yongseok, Can you let me know how you want to proceed with the below. I think we could just drop as it's a performance optimization, or maybe you have a different idea. thanks, Kevin. On 06/02/2019 15:54, Kevin Traynor wrote: > On 01/14/2019 09:16 PM, Yongseok Koh wrote: >> On replenishing Rx buffers for vectorized Rx, mbuf->buf_addr isn't needed >> to be accessed as it is static and easily calculated from the mbuf address. >> Accessing the mbuf content causes unnecessary load stall and it is worsened >> on ARM. >> >> Fixes: 545b884b1da3 ("net/mlx5: fix buffer address posting in SSE Rx") >> Cc: stable@dpdk.org >> > > This is using the API introduced in 1/2, so it's not really suitable for > backport. Maybe you want to send an alternative for stable? > >> Signed-off-by: Yongseok Koh >> Acked-by: Shahaf Shuler >> ---