From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 69265A0543; Tue, 21 Jun 2022 10:44:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EA18641132; Tue, 21 Jun 2022 10:44:20 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 4D83440151; Tue, 21 Jun 2022 10:44:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655801058; x=1687337058; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=zOn0xph151E4O+NQGS1qyJmoN61bM4Cg8M+ujQd0WbY=; b=icg5zLxod+X65/dVkESj2UERIh425/lCMoQnO9436lS6MWm2kLL7/pZo 6ezvkAhPR9NfOF3mqBV6+k3RPlHuWGi9Zwjx5qGpqF0yfZg6PGpc41cmN /et2q98rHZDgeBiF+dZQ7Xz/rnQB+natZ8X/FLpDB8i3WdqPH6ac/fTmE AszAyXTKtHT+5NfawI+Nz+/ztc2hJoSVRvcJ5RFjshx3SPWcrOEa7FI56 FIXTxc9a5xaQhTfC6nqBXQmD8BZmHD1+7/WIjOnAd9aOwRMfKOJEJkyBn M6eY6fB20R42qgLocccTYfPy9dQ/FX66/jAwS4sn40mKrNwgT1t9pBaFK A==; X-IronPort-AV: E=McAfee;i="6400,9594,10384"; a="263100154" X-IronPort-AV: E=Sophos;i="5.92,209,1650956400"; d="scan'208";a="263100154" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2022 01:44:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,209,1650956400"; d="scan'208";a="537962963" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga003.jf.intel.com with ESMTP; 21 Jun 2022 01:44:17 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 21 Jun 2022 01:44:17 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 21 Jun 2022 01:44:16 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 21 Jun 2022 01:44:16 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.106) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 21 Jun 2022 01:44:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GtT4O+tWe7u/DwkLAn/iMXtzOuNMIj2exuqHpCjk8ZNXMDkQ05M9sHOkw43s+KhjmO9BrGhAnnJqz4wk0J90oz8fHonKtLNFVtvYFtGrZy4E5B1INeM6O4jZF0ZV2KvHlwJwJcTW4ux0IUmO3BTC5Z8ZmGFmDAcfr84ajloLhicskeY0Y1xaVhGhNgKU1f9bQtr7Agk5d1oiSNl5YgXg1T1uyoc9DawXEw2bx/yS8/po60EoRVgDpJhJsNSgcWcEG5OZpl78Q/T8Tg04X1Udc3XsMrXKY7qLsbcab3iKkg53XBCM0+Dc4Jg1JP5+8vSMu9ppy+Jf9AtZg7FSOQiydw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WAIcaLZ7lAnjpBiRfS/TbyeVd6XZAe5OExJzLSLjA4M=; b=l7F10TlAP9i6o2qd+eeANNTrEqFTj3Vlg5Rx9DtdMxUzoaKjldpaG/DH+L/IfHGBSlzlHcAk02iyRso8LJtdRv5L3aHSIs0Q95CJ5DWWwuFxSlW1QVBsPtNZ27Ea1WpP5zlAkxyvy9WJ/iZG2VZz1lyEol8k9ui3Akj3Yd6MDgnPSdyjXPUcdwT8Znpg5MGo+d8+bBTX1uCISZhRtP8zikDc8nYxESBWfP2orCcQz4kXcqvk038sCWQsa7iogaOBf++SLYBGX2HDhPvv3yyOjwUvDk+dw9MBnt6u73rawI099AgOmd+MSNZJZcd9nf3EajgvTuFIKl+iTgzLCXI3WQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from BYAPR11MB3799.namprd11.prod.outlook.com (2603:10b6:a03:fb::19) by CY4PR11MB1495.namprd11.prod.outlook.com (2603:10b6:910:c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.15; Tue, 21 Jun 2022 08:44:15 +0000 Received: from BYAPR11MB3799.namprd11.prod.outlook.com ([fe80::e424:dc7d:97d3:66a9]) by BYAPR11MB3799.namprd11.prod.outlook.com ([fe80::e424:dc7d:97d3:66a9%3]) with mapi id 15.20.5353.022; Tue, 21 Jun 2022 08:44:15 +0000 Message-ID: Date: Tue, 21 Jun 2022 09:44:10 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] examples/distributor: fix syntax on single core rx and distributor Content-Language: en-US To: Ferruh Yigit CC: , , =?UTF-8?B?QWJkdWxsYWggw5ZtZXIgWWFtYcOn?= , Thomas Monjalon , David Marchand References: <20220620163146.51435-1-omer.yamac@ceng.metu.edu.tr> From: "Hunt, David" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB6PR0501CA0031.eurprd05.prod.outlook.com (2603:10a6:4:67::17) To BYAPR11MB3799.namprd11.prod.outlook.com (2603:10b6:a03:fb::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9c080307-95c4-4f6d-b0cb-08da536238cd X-MS-TrafficTypeDiagnostic: CY4PR11MB1495:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2d4jh9YTZuB+u1JA6krb6RmNHf29r7DdWZf2eiYEoYLMlx+QBYP2tSvKj91Uww986F9NwC0zoUem1Aywe9VKUv9Khch02/nsM+i+dcOPKSGfQBGr8sd3+Zm5O9I+xlT7/CF57FMyd0ixdO9TvKDaEmNJkUsFNGjDQ7gp5QWET1Su8Oo8s4l5ant8ts9GNUPK++tCvlzMNB7IIiB50asPh5/kjfsPXVHUEh/4MQD56xnvpNIKNkEmokt61JSeb6PfWfMPn03IMF9y85t4CKju68aSgbomG3ZtJHx0hpW+6pYAGADuDyB8F2K9KJHXGFQhQuS9txa0S1weGzb65biwKbda3XqriBBuMvrAgF58u21GwtSmZ7/WQkrHv7Sy3SG/gs8/jEPDIX+f66H1StLYShcke8Qs3NVPGqt3YkefEo9S8bpJWM17XcQvSDf2K6LmGqujdxUEju5nL01H/4RDBCmpRdMkMtkhcLOoZD5JIetSR8jCsNwA5/USynov0qi7ALH7IcGhgXl8S39sdnrUJGuGgbkvrCo3gRU7fm2BZC2DMtzG3pCnz17THF/2l7Uh2OAfP25+lVGiIeWfC1Mx0apvt3wCBsHZVUr2m9gWkhTGAP1Nt8BY28GhCMy9/YAJXpm9xYQE/rF/+uqTgFCnDXdespHLmBdN0n/FFNBqjX7l4Gs5uPpQHqoHOfo/8J3U+UF2PfHiWZDqu/3iK3PzvK/m3d71/Zi2jbJobeBGe2E= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3799.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(376002)(346002)(366004)(39860400002)(396003)(136003)(478600001)(4326008)(66556008)(41300700001)(86362001)(82960400001)(8676002)(66946007)(66476007)(31696002)(6486002)(54906003)(6916009)(38100700002)(316002)(6506007)(186003)(26005)(6512007)(2616005)(6666004)(53546011)(2906002)(36756003)(8936002)(5660300002)(4744005)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V1l6b0s2VloyNUlhV0VzOEhHVXdLSkhaK3dEOWNmRTFPdkx4MS8zWVpDM3JH?= =?utf-8?B?d2xEZnBPc1dKS3ZPSGlDMjR0OStkOE5rdmFtRWZ1Z1hSQkU4M253bG5xbmxx?= =?utf-8?B?UXBQWmFscUtsK3dkSk5rVElhUXJMN3FUYjIxYUgwWjZSU3g5SjdDMy9URzVF?= =?utf-8?B?TTQ4Z0wxcFVpWGFhQVQzcGFvOTNYS29HM0YxLzNCY1dCcmtRNHU5dWV2enR1?= =?utf-8?B?NXI3Y2dYbkg1VHVNMUZCZklYZnFtdFk0NWZDUWN5VlUwMEZmSnlXYlNkblI5?= =?utf-8?B?ZUtrRTRQRWpiVFlzVWE3dTkzSTdEYytsR2p5ZUcyUGpPZ253OURMZGg4RDRl?= =?utf-8?B?NFhPcmtxYjY5d2ZlSnFLTXM4SnpiaWowTUVGb05TaTRhS29JeWlVWDRhWWoy?= =?utf-8?B?ZFBuQm1pU1djZ0IwZm1aN1ZaUHc5ZlhObmhXZ2h6eFIrL3FVUE0zcEQyVW9x?= =?utf-8?B?cFpMN3FTZ0RiRThtMVRPZ2NZRUdJczF0Qk5JSHE0d3Nucjh6S1dreTVjeDFt?= =?utf-8?B?WmtxZDlyTERNZ3crVUdvVWlWbU5mWkFnaVRaMXpjcTFhWkNWVm80UlJjQnZM?= =?utf-8?B?SHY1bVg2a0xSL1BNaFBMc0VMQS9Uczd4b1hYTTdHRDNDdXpPcEV2b3R2cTZD?= =?utf-8?B?TEZuczc4U1BpMjZHejdJUW1XZnM2UHBKN0JGc0Jabk9uYXU0RXE2VWxUTGl4?= =?utf-8?B?UlRBYU9wV1U1VlZUbUF6eDdlK0V0dXo2QSsva05aRFBINVBlSzk0N2lYWG4w?= =?utf-8?B?QTFJbUR0ckpHM0R5V1c4NHhzZmVaL0FDdlMzRkZLRGNpNjNSU3FkbVpLNXQ5?= =?utf-8?B?MjVJVHhjSUV5OGQ3Z2h6Rk1HM3pESVQ1R0lnb0w3STk3YUhpdXk1Q2dZSFBq?= =?utf-8?B?ZEthdmRYM1VZc3JlL0JSb3l2cVVldjNqMCtDeE9GUnFmWVZWREx1ZU56a2dn?= =?utf-8?B?OEJCekhnUVdLSVpPeExJbzJQRElDS2FUUUJ1aWtWaE1HR2tUb1ozTlVuUnZl?= =?utf-8?B?cm9uMi9wcy9OeGZjZmZjdE5mR21zQkdQODJUQUNKMjRGNVl1Z2dWaE40MXdD?= =?utf-8?B?QlFPSy95dThpT1lxOWpwM1JIN01ScWIvbW5Ga2RPOVFzSndjcmsxR2gvMk92?= =?utf-8?B?OFBmSngwTUxRc1FGbEkwWldhWWlBcjd3bDVMNmtkTVJBcGFrdm9HeEwwSE5q?= =?utf-8?B?ZmpiaEF2dU9mZkgxK2FZU2RLVEJZaTIvYmg5SkRVTEw3cUhzSFZpdUpXTkhm?= =?utf-8?B?UGp4U0tiNVlDYTQ2bWJ0VlNUZjB1d0JoYUFHRlBZRXF3aTJ0d25qZFp1RFo3?= =?utf-8?B?bVNPdWF5VVVNTmJ2M0czdCs2RXBqR3lqUytwWjZ4TG9yOFN6bHREMHc0eEU0?= =?utf-8?B?TE9Wb3Jpc0g5WlZyeHpnWXB2RkYyaURUQXozYzE5eWQwUmlya2lxa1FqQ1Zm?= =?utf-8?B?c0d2bzhWN21aVjZYOHRQdlUvbHBjZU1OWGVsTWxLYWlURHZtVG5rSjJ2VHlX?= =?utf-8?B?WTBwSGJ6dldNVnkycVk1U1I2VEp2VWJnR0RDcklJd01JMExvSWhubFJvNUFQ?= =?utf-8?B?QThFOTFjZEgzQ2s2OTdkMSs2czZjM1QwK2FPa0pUZXo3T2VXYldDTDhCNXBq?= =?utf-8?B?azhIdjF1Yy9lOW5DT1dxdFlhNnhXeHZiYmJZRGphVkFIK2NUaDF3Vi9DLy8x?= =?utf-8?B?NFFLSnc0andzVVhJZWhKRjNmTlRqd0czeXVDeEswcStNRVMwakxlNUgzRFJq?= =?utf-8?B?VXpjTUFXNzFONndoTVc2MVZuRlgreU9uYjFBaXFzTjE4VXZvZGxqWWM4SSt3?= =?utf-8?B?RkV6QlRiMng3OU0wZ1RlRzdSckVYY1JnSDNrdjgvOTlVN25XcUh2N1hidFp6?= =?utf-8?B?RjNXWDBRMUZXZ2p1TEI3Mk1VeFFuT2ppeDk2clVlWklnK3Y3a0FNeWpXQzk3?= =?utf-8?B?bXczaUhXSENhcnlLYnRKWWpjbUlwS25MTGhUOGdYaHVLVXFhWlRaOVhKOHpj?= =?utf-8?B?REIvZDl6bUwwQXB5Z2l0R2NXcUx5aUxZWitPcUNtVUgySEtCTXROTzFrbEJq?= =?utf-8?B?UFBJLzhyc2NvcCszSzZHbGFzUk8yR2RVMVNWdVYrc2NiS21BdHdsQVgyQXk0?= =?utf-8?B?N3VEK0RScVJyY1k2SUVuenBrWWczYzZ6WmdGV0kyM3AyUlBSSkJBYlhUSzlq?= =?utf-8?B?aDJSMzJjWWd3Sy9BOGVGUHhnWk4zVkxvdEYyK01Tc2U0NXpwNEJ0a0duUGFZ?= =?utf-8?B?cXZHRUJ3Z0JVdmdoK2JQc29IaTZ2NndHY2FKOVRMc3RudlM4Mmd1V09aUzJO?= =?utf-8?B?OVJQT2t4NC95YVllRGRnZTArSmRvTjVpeFRSYjFzZmh0ejhoVE9ib3NFNU1I?= =?utf-8?Q?BAR11vlL65sVnEOc=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 9c080307-95c4-4f6d-b0cb-08da536238cd X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3799.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2022 08:44:15.3750 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6F/idF72pfp8U0Dnr+G+LOKh8Cr8D0TX/oc+xRsnaPjL4+UupkWE8DRKnEO0vYUjMKfa0xuN3YZxOLo4IOIRbw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1495 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Ferruh, On 20/06/2022 18:10, Ferruh Yigit wrote: > On 6/20/2022 5:31 PM, Abdullah Ömer Yamaç wrote: >> This patch fixes the syntax error when using the single-core >> for both rx and distributor functions. >> >> Fixes: 4a7f40c0ff9a ("examples/distributor: add dedicated core") >> Cc: stable@dpdk.org >> >> Signed-off-by: Abdullah Ömer Yamaç > > Acked-by: Ferruh Yigit > > > Can we convert compile time macro to dynamic configuration to prevent > build errors like this? +1 for the dynamic config. Maybe a "-c" on the command line for "combine rx and dist threads"? Tested-by: David Hunt